lp:~benji/landscape-client/bug-1428826-restore-register-function-public-API
- Get this branch:
- bzr branch lp:~benji/landscape-client/bug-1428826-restore-register-function-public-API
Branch merges
- Adam Collard (community): Approve
- Björn Tillenius (community): Approve
-
Diff: 168 lines (+91/-18)2 files modifiedlandscape/configuration.py (+25/-15)
landscape/tests/test_configuration.py (+66/-3)
Related bugs
Related blueprints
Branch information
Recent revisions
- 814. By Benji York
-
A few small review changes:
- tweak a test so as to record the fact that a function got called
and then assert that it didn't instead of making it call
self.fail() when called
- add some commentary about the charm's use of register() in an
additional place - 813. By Benji York
-
restore legacy API used by client charm and add tests to make sure it is maintained
- 812. By Benji York
-
Merge better-
self-signed- cert-ux- 3 [f=] [r=bjornt,danilo] [a=Benji York]
This branch is a pure refactoring of the way the client configuration
communicates so as to separate the UI and network code in preparation
for better SSL error handling and user interaction.Tests were then able to be improved -- but not as far as we would like.
Notes from Chris:
Most of the code breaks out nested function declaration to make them
easier to test, using functools.partial to keep the invocation sane in a
twisted context (test them "flat", use functools to pass closures to
event handlers).We used manual stubs instead of mocks for readability and personal
preference [of both of us]. - 811. By Benji York
-
Merge faster-test-run [f=] [r=bjornt,
free.ekanayaka, chad.smith] [a=Benji York]
A couple of tests inject dpkg failures which are retried 12 times with a 5 second sleep between. For test that's unneccesary, so this branch sets the sleep time to zero for those tests. - 810. By Adam Collard
-
Don't use Python 2.7isms in the test suite (needs to run on Lucid) [trivial] [r=tribaal]
- 808. By Fernando Correa Neto <email address hidden>
-
Merge retry-apt-update [f=1398090] [r=danilo,
free.ekanayaka] [a=Fernando Correa Neto]
Change the package reporter so it retries running apt-get update when an error 100 is returned, pretty much in the same way the charm code does it. - 807. By Chris Glass
-
Merge more-informatio
n-on-ssl- errors [f=1409700] [r=danilo, free.ekanayaka] [a=Chris Glass]
Add a specific error message when the cause of registration failure is an SSL error.
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:~landscape/landscape-client/trunk