lp:~benji/juju-gui/r-263

Created by Benji York on 2012-12-05 and last modified on 2012-12-05
Get this branch:
bzr branch lp:~benji/juju-gui/r-263
Only Benji York can upload to this branch. If you are Benji York please log in for upload directions.

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Benji York
Project:
juju-gui
Status:
Development

Recent revisions

263. By Benji York on 2012-12-04

Combine and minifiy CSS files.

R=matthew.scott, bac
CC=
https://codereview.appspot.com/6865054

262. By Brad Crittenden on 2012-12-03

Add the required charm filter dropdown.

The original design for the charm search results panel had a dropdown
that was to be used to filter the results. After some consideration
the three sets were chosen to be 'all', 'deployed', and 'subordinate'.

This branch implements the dropdown and filter mechanism. The widget
was based on the graph/list picker on the bottom of the page. It was
refactored into a generic LESS function and supports both uses.

The design for the existing picker had a 1px wide design element to
provide the background. It was not tall enough for a picker with
three items. As a work-around an 'outset' mitred HTML border is
used. It will be easy to replace with the proper asset when it is
produced.

If the picker is open and a click outside closes the charm panel then
the picker remains open. That is a wart that needs to be fixed.

R=benji, frankban
CC=
https://codereview.appspot.com/6842119

261. By Benjamin Saller on 2012-11-29

D3 Components Documentation

This make an effort to provide a high level modules writer guide. As a
concession it refers the reader to portions of the YUI event and D3 data
binding docs.

R=teknico, benjamin.saller, gary.poster
CC=
https://codereview.appspot.com/6858085

260. By Madison Scott-Clary on 2012-11-28

Ignore editor files.

Watch functions will throw noisy errors on files not part of the distribution, making debugging watched files (templates, LESS stylesheet) difficult in `make debug`; an ifValidFile function was created to ignore these and slim down useless errors. Quick slack task.

R=benji, gary.poster
CC=
https://codereview.appspot.com/6842104

259. By Madison Scott-Clary on 2012-11-27

Charm panel border improvements

From Matt C.: Shadow should be darker on darker areas in the panel (such as the charm name and search result headings), and the border should extend all the way down to the bottom of the view (was 1px short).

Per UX review, colors updated and inset box-shadow on bottom.

R=
CC=
https://codereview.appspot.com/6855049

258. By Francesco Banconi on 2012-11-27

Tests mutating URL and not removing test nodes.

One of the hotkeys tests mutated the URL.
Both tests in that test case also failed when run
in isolation, and some variables were unused.

Also fixed tests leaving elements in the DOM:
as a consequence, "Environmenton excellent provider"
was visible at the top of the page after a test run.
Now the container used by those tests is removed
after each test is run. Also removed an XXX saying
that removing the elements in afterEach can be
problematic. I've tried to reproduce the erroneus
behavior described, running the test suite several
times, without success. Anyway, removing in afterEach
what was created in beforeEach is something we do
everywhere in the tests. So, that XXX confused me
a bit, any hint?

To avoid flickering in the test page, I tried to
hide the nodes used by tests where possible.

R=
CC=
https://codereview.appspot.com/6856075

257. By Nicola Larosa on 2012-11-26

Compute documentation statistics.

Count the total number of YUIDoc documentation lines by
enhancing the output of the "bin/lint-yuidoc" command.

R=benji, gary.poster
CC=
https://codereview.appspot.com/6845085

256. By Benji York on 2012-11-23

Remove "requires" properties.

The minification process does not read the "requires" parameters defined in
"all-app-debug.js". This parameter should be defined in each custom yui object
that uses some kind of internal or external requirement. The sole use of
"all-app-debug.js" is to define the fullpath of the file that defines a given
module.

This patch removes all the existing "requires" properties from
"all-app-debug.js" and add then where they are needed.

R=
CC=
https://codereview.appspot.com/6845084

255. By Madison Scott-Clary on 2012-11-21

Fix initial creation of subordinates.

When creating a subordinate service initially, it was not being laid out properly by the pack layout, nor was it seeming to have drag events attached. Pack layout was expecting a value accessor function to return some number greater than zero when constructing its radius, which informs the x/y coordinates. Returning zero results in NaN for all three values, thus positioning the service at (0,0) and causing drag events to fail when updating the service's coordinates with dx/dy + NaN. This branch fixes this by ensuring that zero is never returned as the node's value. This fix is quick and intended to make the UI function with the current layout algorithm. Future layout algorithms, if they're designed by hand, will need to keep this in mind as well.

R=benjamin.saller, bac
CC=
https://codereview.appspot.com/6856067

254. By Thiago Veronezi on 2012-11-20

application hotkeys

The user can hit alt+e to open the environment view and alt+s to focus the
charm search field.

R=matthew.scott, benjamin.saller
CC=
https://codereview.appspot.com/6849078

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
Stacked on:
lp:juju-gui/experimental
This branch contains Public information 
Everyone can see this information.

Subscribers