lp:~benji/juju-gui/no-foot-shooting

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:juju-gui/experimental at revision 327

Juju GUI Hackers: Pending requested 2013-01-17

Diff: 1140 lines (+684/-172)

15 files modified

app/templates/overview.handlebars (+1/-1)
app/templates/service-config.handlebars (+12/-6)
app/templates/service-footer-common-controls.partial (+30/-27)
app/templates/service-footer-destroy-service.partial (+7/-8)
app/templates/service.handlebars (+7/-8)
app/views/service.js (+142/-100)
app/views/topology/service.js (+24/-9)
app/views/utils.js (+62/-0)
lib/views/stylesheet.less (+16/-7)
test/index.html (+1/-0)
test/test_application_notifications.js (+2/-0)
test/test_service_view.js (+113/-2)
test/test_templates.js (+128/-0)
test/test_topology.js (+72/-4)
test/test_utils.js (+67/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1090716: GUI should protect GUI charm

High

Fix Released

Link a bug report

Related blueprints

323. By Benji York on 2013-01-17

fix lint

322. By Benji York on 2013-01-17

more review changes

321. By Benji York on 2013-01-17

checkpoint

320. By Benji York on 2013-01-17

merge from trunk

319. By Benji York on 2013-01-17

fix lint

318. By Benji York on 2013-01-17

checkpoint

317. By Brad Crittenden on 2013-01-14

Allow user and password to be set in config.

If the user and password are set in the config files then they will be used
and the user will not be prompted.

The credentials are set in config-debug.js but not config-prod.js by default.

R=benji, gary.poster
CC=
https://codereview.appspot.com/7093062

316. By Brad Crittenden on 2013-01-14

Add tests for new viewport module.

Add tests for the new module. Also removed an unused function. It looked
useful but I didn't think it should hang around if not called. Ben might have
had a plan for it.

R=matthew.scott, benji
CC=
https://codereview.appspot.com/7085057

315. By Madison Scott-Clary on 2013-01-14

Test fix for mousemove.

Mousemove test was failing due to simulated mousemove events not providing a new X/Y coordinate. This caused intermittent failures depending on where the mouse was when tests were started. Fixed by providing coords to ensure the handler is fired. Proposing as I'd like to make sure this works for others.

R=frankban, brad.crittenden
CC=
https://codereview.appspot.com/7102055

314. By Madison Scott-Clary on 2013-01-11

Pending relation from click-to-add-relation fix

The pending relation line was not following the cursor or behaving properly when a relation was being added via the service menu. Conditions were added to the test on this behavior to ensure that mousemove was being called/fired properly.

R=bac, bcsaller
CC=
https://codereview.appspot.com/7081043