lp:~benji/juju-gui/bug-1074336

Branch merges

Propose for merging

No branches dependent on this one.

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

245. By Benji York on 2012-11-30

review fixes

244. By Benji York on 2012-11-20

fix typo

243. By Benji York on 2012-11-20

tweak test container hiding

242. By Benji York on 2012-11-20

- refactored manageUnitsMixin and added tests for it
- added documentation for manageUnitsMixin
- reconsidered our object literal style, updated the style guide to reflect my
  current notions, and used the style in the code as a proof of concept
- captured current naming practice in the style guide (camelCase everywhere)
- tweaked all of the tests so the test container element is "display: none"
  when possible and "visibility: hidden" otherwise
- transmuted an "apply" to a slightly simpler "call"

241. By Benji York on 2012-11-13

merged from :parent

240. By Benji York on 2012-11-13

fix broken charm panel showing

239. By Benji York on 2012-11-13

Remove the fade in/out of the charm panel.

R=gary.poster
CC=
https://codereview.appspot.com/6854043

238. By Benjamin Saller on 2012-11-13

Micro Framework for Environment View

A subclass of Component will container 1 or more modules
which implement their own areas of application concern.

The pattern is that we can declaratively define event listeners
and respond to those across modules. For example A canvas click
might fire an application event 'clickedCanvas' which each module
can have subscribers for that do things like close menus and remove
drag lines, etc.

R=thiago, matthew.scott, benjamin.saller
CC=
https://codereview.appspot.com/6828048

237. By Francesco Banconi on 2012-11-13

Replaced charm panel icons with our assets.

In the charm panel, replaced bootstrap icons with
the ones from our sprite. Also added the back triangle
to the sprite.
This branch also fixes the charm menu chevrons: now they
are correctly replaced on panel open/close.
Added "docstrings" for relevant methods.

R=teknico, bac
CC=
https://codereview.appspot.com/6819131

236. By Madison Scott-Clary on 2012-11-09

Lightweight assets/improve FF performance

Some lighter weight assets for service modules were implemented, via Matt C. Additionally, profiling showed that a lot of slowness for FireFox was caused by FF internals being slow (namely <node>.setAttribute() and <node>.getClientRects()). While we can't fix those being slow, we can reduce the number of times they're used. This is done by modifying attributes on only relevant relation lines when a service is dragged (rather than redrawing or modifying all lines). This results in fewer calls to both of those internals, and speeds up animation in FireFox.

R=gary.poster, benjamin.saller
CC=
https://codereview.appspot.com/6826057