Merge lp:~benji/juju-gui/add-rel-improvements-3 into lp:juju-gui/experimental

[Benji York]

improve draglines

https://codereview.appspot.com/6818107/

[Gary Poster (gary)]

Hey Benji. Thank you for this. It is a nice improvement that worked
well when I tried it. Tests passed and merge with trunk was also fine
for me.

I have a bunch of fairly trivial comments & requests. If you agree,
please just make the changes and treat this as an automatic approval.

Gary

https://codereview.appspot.com/6821088/diff/1/app/views/environment.js
File app/views/environment.js (right):

https://codereview.appspot.com/6821088/diff/1/app/views/environment.js#newcode1
app/views/environment.js:1: 'use strict';
Please add the module yuidoc comment.

https://codereview.appspot.com/6821088/diff/1/app/views/environment.js#newcode10
app/views/environment.js:10: var EnvironmentView =
Y.Base.create('EnvironmentView', Y.View,
Please add the class yuidoc comment.

https://codereview.appspot.com/6821088/diff/1/app/views/environment.js#newcode23
app/views/environment.js:23: /** The user clicked on the "Build
Relation" menu item. */
We had a good conversation in a hangout about my mild concerns about the
fact that this is required because of yuidoc-linter even though yuidoc
ignored it; and about the fact that you are using a /** TEXT */ syntax
when I thought we were standardizing on a multiline syntax:
/**
  * TEXT
  */

I still have those concerns, and would feel slightly happier if you
changed to always use the multiline spelling (particularly given the use
of "/* */" rather than "//") but I am OK with letting you document and
advocate for your positions, in your role as
Bringer-of-YUIDoc-to-the-Masses.

https://codereview.appspot.com/6821088/diff/1/app/views/environment.js#newcode28
app/views/environment.js:28: this.addRelationDragStart.call(this, box,
context);
Could you check to see if "this.addRelationDragStart(box, context);"
will work? I think it will.

https://codereview.appspot.com/6821088/diff/1/app/views/environment.js#newcode82
app/views/environment.js:82: }
not entirely idle thought, but one that is not really directly pertinent
to your branch: I wonder how a service is supposed to make a
relationship to itself, which IIUC is possible.

https://codereview.appspot.com/6821088/diff/1/app/views/environment.js#newcode128
app/views/environment.js:128: */
As mentioned yesterday, please add @method, @param and @return tags with
the appropriate bits and bobs.

Oh, wait: this is an event handler, so yuidoc will not document it.

:-( I find this a bit hard to catch.

https://codereview.appspot.com/6821088/diff/1/app/views/environment.js#newcode133
app/views/environment.js:133: self.rectMousemove.call(node.getDOMNode(),
d, self);
So, where other uses of "call" in this file seem pointless, this one
actually seems to have a point...and it seems like a really odd pattern
to me. As we discussed yesterday, you are following an existing
pattern, so I'm not asking for any changes from you, but could you find
out from Matt or Ben why this pattern exists, and arrange for the
information to be shared with the rest of us, either from them or you?

https://codereview.appspot.com/6821088/diff/1/app/views/environment.js#newcode171
app/views/environment.js:171: */
Add @method, @param, @return, please. ^D^D^D Nevermind, event handler.

Unnecessary ext...

[Gary Poster (gary)]

review: Approve

[Thiago Veronezi (tveronezi)]

https://codereview.appspot.com/6821088/diff/1/app/views/environment.js
File app/views/environment.js (right):

https://codereview.appspot.com/6821088/diff/1/app/views/environment.js#newcode28
app/views/environment.js:28: this.addRelationDragStart.call(this, box,
context);
why do you need to use the 'call' method and pass 'this'?
You could simply call 'this.addRelationDragStart(box, context)', no?

https://codereview.appspot.com/6821088/diff/1/app/views/environment.js#newcode133
app/views/environment.js:133: self.rectMousemove.call(node.getDOMNode(),
d, self);
why to you set the scope to getDOMNode and pass self ('this') as
parameter? You could pass the domNode as parameter instead...

self.rectMousemove(node.getDOMNode(), d);

https://codereview.appspot.com/6821088/diff/1/app/views/environment.js#newcode176
app/views/environment.js:176: self.rectMousemove.call(node.getDOMNode(),
d, self);
It seems we have mousemove more than once in this file. You could
extract it to a common function in this closure.

https://codereview.appspot.com/6821088/diff/1/app/views/environment.js#newcode209
app/views/environment.js:209: self.backgroundClicked.call(self);
You dont need to use 'call'. You can do...

self.backgroundClicked();

https://codereview.appspot.com/6821088/diff/1/app/views/environment.js#newcode446
app/views/environment.js:446: rectMousemove: function(d, self) {
According the the rest of the code, the scope here is domNode. If you
dont change the scope you can do (not tested... :) )...

// *************************
self.rectMousemove(node.getDOMNode());

rectMousemove: function(domNode) {
   var mouse = d3.mouse(domNode);
   d3.event.x = mouse[0];
   d3.event.y = mouse[1];
   this.addRelationDrag(this.get('addRelationStart_service'), domNode);
},
// *************************

btw, you dont use the 'd' parameter.

https://codereview.appspot.com/6821088/diff/1/app/views/environment.js#newcode1231
app/views/environment.js:1231: possible_relations = Y.Array.map(
The indentation in this block is really strange. Maybe you could just
declare the variable and then assign the value to it in another line.

https://codereview.appspot.com/6821088/diff/1/app/views/environment.js#newcode1529
app/views/environment.js:1529: view.startRelation.call(view, service);
It seems you like to use the 'call' function. :)

https://codereview.appspot.com/6821088/diff/1/undocumented
File undocumented (left):

https://codereview.appspot.com/6821088/diff/1/undocumented#oldcode116
undocumented:116: app/views/environment.js click
On 2012/11/07 15:10:41, gary.poster wrote:
> The People of the Future thank you.

Hahahaha!

https://codereview.appspot.com/6821088/

[lp:~benji/juju-gui/add-rel-improvements-3]

223. By Benji York on 2012-11-07

add YUIDoc info to the style guide

224. By Benji York on 2012-11-08

refactorings prompted by review

[Gary Poster (gary)]

On 2012/11/08 17:25:06, benji wrote:
> I have addressed everything other than one comment by Gary about the
tests in
> which I couldn’t figure out what he wanted.

Thank you!

I'd be happy to re-review if you wanted, but it is not up in Rietveld so
I won't unless you ask. I'll reply to a few comments here in-line
below, though.

...

https://codereview.appspot.com/6821088/diff/1/app/views/environment.js#newcode23
> app/views/environment.js:23: /** The user clicked on the "Build
Relation" menu
> item. */
> On 2012/11/07 15:10:41, gary.poster wrote:
> > We had a good conversation in a hangout about my mild concerns about
the fact
> > that this is required because of yuidoc-linter even though yuidoc
ignored it;
> > and about the fact that you are using a /** TEXT */ syntax when I
thought we
> > were standardizing on a multiline syntax:
> > /**
> > * TEXT
> > */
> >
> > I still have those concerns, and would feel slightly happier if you
changed to
> > always use the multiline spelling (particularly given the use of "/*
*/"
> rather
> > than "//") but I am OK with letting you document and advocate for
your
> > positions, in your role as Bringer-of-YUIDoc-to-the-Masses.

> The multi-line format seems to overemphasize the importance of the
comment, so I
> have left these. However, I have updated the style guide to include a
(first
> draft) policy that explains the situations in which you would use one
or the
> other.

Cool, sounds good. Thank you.

...

https://codereview.appspot.com/6821088/diff/1/app/views/environment.js#newcode128
> app/views/environment.js:128: */
> On 2012/11/07 15:10:41, gary.poster wrote:
> > As mentioned yesterday, please add @method, @param and @return tags
with the
> > appropriate bits and bobs.
> >
> > Oh, wait: this is an event handler, so yuidoc will not document it.
> >
> > :-( I find this a bit hard to catch.

> Yep, the plethora of event handlers makes this code hard to grok. I
am not sure
> what we should do instead. As an improvement I refactored the code so
there is
> a single view method that gets called when any of the mousemove events
are
> triggered. That method now has full docs.

Huh, cool. Sounds good, thank you.

https://codereview.appspot.com/6821088/diff/1/app/views/environment.js#newcode133
> app/views/environment.js:133:
self.rectMousemove.call(node.getDOMNode(), d,
> self);
> On 2012/11/07 15:21:04, thiago wrote:
> > why to you set the scope to getDOMNode and pass self ('this') as
parameter?
> You
> > could pass the domNode as parameter instead...

> This was preexisting code (that got moved around). It is indeed
insane. I
> refactored this extensively and it now doesn't do this.

:-) Cool!

Ben told be that ".call" has the advantage of naturally supporting
chaining. However, in my own experiments I could not get this to work
so I may have misunderstood.

https://codereview.appspot.com/6821088/diff/1/app/views/environment.js#newcode171
> app/views/environment.js:171: */
> On 2012/11/07 15:10:41, gary.poster wrote:
> > Add @method, @param, @return, please. ^D^D^D Nevermind, event
han...

=== modified file 'README'
--- README	2012-11-05 19:35:15 +0000
+++ README	2012-11-08 17:28:23 +0000
@@ -105,7 +105,7 @@
 
   $ make yuidoc
 
-The documentation for yuidoc markup is at
+The documentation for YUIDoc markup is at
 http://yui.github.com/yuidoc/syntax/ .
 
 Running lint

=== modified file 'app/views/environment.js'
--- app/views/environment.js	2012-11-07 12:32:38 +0000
+++ app/views/environment.js	2012-11-08 17:28:23 +0000
@@ -1,4 +1,9 @@
 'use strict';
+/**
+ * Provides the main app class.
+ *
+ * @module views
+ */
 
 YUI.add('juju-view-environment', function(Y) {
 
@@ -7,6 +12,12 @@
       Templates = views.Templates,
       models = Y.namespace('juju.models');
 
+  /**
+   * Display an environment.
+   *
+   * @class environment
+   * @namespace views
+   */
   var EnvironmentView = Y.Base.create('EnvironmentView', Y.View,
                                       [views.JujuBaseView], {
         events: {
@@ -20,17 +31,19 @@
           },
           // Menu/Controls
           '.add-relation': {
+            /** The user clicked on the "Build Relation" menu item. */
             click: function() {
               var box = this.get('active_service'),
                   service = this.serviceForBox(box),
                   context = this.get('active_context');
+              this.addRelationDragStart(box, context);
               this.service_click_actions
                         .toggleControlPanel(box, this, context);
-              this.service_click_actions
-                        .addRelationStart(box, this, context);
+              this.service_click_actions.addRelationStart(box, this, context);
             }
           },
           '.view-service': {
+            /** The user clicked on the "View" menu item. */
             click: function() {
               // Get the service element
               var box = this.get('active_service'),
@@ -42,6 +55,7 @@
             }
           },
           '.destroy-service': {
+            /** The user clicked on the "Destroy" menu item. */
             click: function() {
               // Get the service element
               var box = this.get('active_service'),
@@ -72,6 +86,12 @@
               if (!d.containsPoint(mouse_coords, self.zoom)) {
                 return;
               }
+
+              // Do not fire if we're on the same service.
+              if (d === self.get('addRelationStart_service')) {
+                return;
+              }
+
               self.set('potential_drop_point_service', d);
               self.set('potential_drop_point_rect', rect);
               self.addSVGClass(rect, 'hover');
@@ -112,7 +132,8 @@
                 self.dragline.attr('class',
                     'relation pending-relation dragline dragging');
               }
-            }
+            },
+            mousemove: 'mousemove'
           },
           '.sub-rel-block': {
             mouseenter: function(d, self) {
@@ -143,16 +164,30 @@
 
           // Relation Related
           '.rel-label': {
-            click: 'relationClick'
+            /** The user clicked on the relation label. */
+            click: 'relationClick',
+            mousemove: 'mousemove'
           },
 
-          // Canvas related
           '#canvas rect:first-child': {
+            /**
+             * If the user clicks on the background we cancel any active add
+             * relation.
+             */
             click: function(d, self) {
               var container = self.get('container');
               container.all('.environment-menu.active').removeClass('active');
               self.service_click_actions.toggleControlPanel(null, self);
               self.cancelRelationBuild();
+            },
+            mousemove: 'mousemove'
+          },
+          '.dragline': {
+            /** The user clicked while the dragline was active. */
+            click: function(d, self) {
+              // It was technically the dragline that was clicked, but the
+              // intent was to click on the background, so...
+              self.backgroundClicked();
             }
           }
         },
@@ -168,28 +203,12 @@
                   return;
                 }
 
-                // set a flag on the view that we're building a relation
-                self.buildingRelation = true;
-
                 // Sometimes mouseover is fired after the mousedown, so ensure
                 // we have the correct event in d3.event for d3.mouse().
                 d3.event = e;
 
-                // Flash an indicator around the center of the service block.
-                var center = d.getCenter();
-                self.vis.append('circle')
-                  .attr('cx', center[0])
-                  .attr('cy', center[1])
-                  .attr('r', 100)
-                  .attr('class', 'mouse-down-indicator')
-                  .transition()
-                  .duration(750)
-                  .ease('bounce')
-                  .attr('r', 0)
-                  .remove();
-
                 // Start the process of adding a relation
-                self.addRelationDragStart.call(self, d, this);
+                self.addRelationDragStart(d, this);
               }, [d, evt], false);
             },
             'mouseup.addrel': function(d, self) {
@@ -400,6 +419,27 @@
           self.removeRelationConfirm(d, this, self);
         },
 
+        /**
+          * If the mouse moves and we are adding a relation, then the dragline
+          * needs to be updated.
+          *
+          * @method mousemove
+          * @param {object} d Unused.
+          * @param {object} self The environment view itself.
+          * @return {undefined} Side effects only.
+          */
+        mousemove: function(d, self) {
+          if (self.clickAddRelation) {
+            var container = self.get('container'),
+                node = container.one('#canvas rect:first-child').getDOMNode(),
+                mouse = d3.mouse(node);
+            d3.event.x = mouse[0];
+            d3.event.y = mouse[1];
+            self.addRelationDrag
+              .call(self, self.get('addRelationStart_service'), node);
+          }
+        },
+
         /*
          * Sync view models with current db.models.
          */
@@ -461,7 +501,7 @@
               })
             .on('drag', function(d, i) {
                 if (self.buildingRelation) {
-                  self.addRelationDrag.call(self, d, this);
+                  self.addRelationDrag(d, this);
                 } else {
                   if (self.longClickTimer) {
                     self.longClickTimer.cancel();
@@ -483,7 +523,7 @@
               })
             .on('dragend', function(d, i) {
                 if (self.buildingRelation) {
-                  self.addRelationDragEnd.call(self, d, this);
+                  self.addRelationDragEnd();
                 }
               });
 
@@ -1020,23 +1060,26 @@
         },
 
         addRelationDragStart: function(d, context) {
-          // Create a pending drag-line behind services.
-          var dragline = this.vis.insert('line', '.service')
+          // Create a pending drag-line.
+          var dragline = this.vis.append('line')
               .attr('class', 'relation pending-relation dragline dragging'),
               self = this;
 
-          // Start the line in the middle of the service.
-          var point = d.getCenter();
-          dragline.attr('x1', point[0])
-              .attr('y1', point[1])
-              .attr('x2', point[0])
-              .attr('y2', point[1]);
+          // Start the line between the cursor and the nearest connector
+          // point on the service.
+          var mouse = d3.mouse(Y.one('svg').getDOMNode());
+          self.cursorBox = views.BoundingBox();
+          self.cursorBox.pos = {x: mouse[0], y: mouse[1], w: 0, h: 0};
+          var point = self.cursorBox.getConnectorPair(d);
+          dragline.attr('x1', point[0][0])
+              .attr('y1', point[0][1])
+              .attr('x2', point[1][0])
+              .attr('y2', point[1][1]);
           self.dragline = dragline;
-          self.cursorBox = views.BoundingBox();
 
           // Start the add-relation process.
           self.service_click_actions
-          .addRelationStart(d, self, context);
+            .addRelationStart(d, self, context);
         },
 
         addRelationDrag: function(d, context) {
@@ -1057,7 +1100,7 @@
           }
         },
 
-        addRelationDragEnd: function(d, context) {
+        addRelationDragEnd: function() {
           // Get the line, the endpoint service, and the target <rect>.
           var self = this;
           var rect = self.get('potential_drop_point_rect');
@@ -1133,11 +1176,80 @@
             this.dragline.remove();
             this.dragline = null;
           }
+          this.clickAddRelation = null;
           this.set('currentServiceClickAction', 'toggleControlPanel');
+          this.buildingRelation = false;
           this.show(this.vis.selectAll('.service'))
                   .classed('selectable-service', false);
         },
 
+        /**
+         * The user clicked on the environment view background.
+         *
+         * If we are in the middle of adding a relation, cancel the relation
+         * adding.
+         *
+         * @method backgroundClicked
+         * @return {undefined} Side effects only.
+         */
+        backgroundClicked: function() {
+          if (this.clickAddRelation) {
+            this.cancelRelationBuild();
+          }
+        },
+
+        /**
+         * An "add relation" action has been initiated by the user.
+         *
+         * @method startRelation
+         * @param {object} service The service that is the source of the
+         *  relation.
+         * @return {undefined} Side effects only.
+         */
+        startRelation: function(service) {
+          // Set flags on the view that indicate we are building a relation.
+          this.buildingRelation = true;
+          this.clickAddRelation = true;
+
+          this.show(this.vis.selectAll('.service'));
+
+          var db = this.get('db'),
+              getServiceEndpoints = this.get('getServiceEndpoints'),
+              endpoints = models.getEndpoints(
+                  service, getServiceEndpoints(), db),
+              // Transform endpoints into a list of relatable services (to the
+              // service).
+              possible_relations = Y.Array.map(
+                  Y.Array.flatten(Y.Object.values(endpoints)),
+                  function(ep) {return ep.service;}),
+              invalidRelationTargets = {};
+
+          // Iterate services and invert the possibles list.
+          db.services.each(function(s) {
+            if (Y.Array.indexOf(possible_relations,
+                s.get('id')) === -1) {
+              invalidRelationTargets[s.get('id')] = true;
+            }
+          });
+
+          // Fade elements to which we can't relate.
+          // Rather than two loops this marks
+          // all services as selectable and then
+          // removes the invalid ones.
+          this.fade(this.vis.selectAll('.service')
+              .classed('selectable-service', true)
+              .filter(function(d) {
+                return (d.id in invalidRelationTargets &&
+                          d.id !== service.id);
+              }))
+              .classed('selectable-service', false);
+
+          // Store possible endpoints.
+          this.set('addRelationStart_possibleEndpoints', endpoints);
+          // Set click action.
+          this.set('currentServiceClickAction', 'ambiguousAddRelationCheck');
+        },
+
 
         /*
          * Zoom in event handler.
@@ -1403,51 +1515,10 @@
            * flow.
            */
           addRelationStart: function(m, view, context) {
-            view.show(view.vis.selectAll('.service'));
-
-            var db = view.get('db'),
-                getServiceEndpoints = view.get('getServiceEndpoints'),
-                service = view.serviceForBox(m),
-                endpoints = models.getEndpoints(
-                    service, getServiceEndpoints(), db),
-
-                /* Transform endpoints into a list of
-                 * relatable services (to the service in m)
-                 */
-                possible_relations = Y.Array.map(
-                    Y.Array.flatten(Y.Object.values(
-                        endpoints)),
-                    function(ep) {return ep.service;}),
-                invalidRelationTargets = {};
-
-            // Iterate services and invert the possibles list.
-            db.services.each(function(s) {
-              if (Y.Array.indexOf(possible_relations,
-                  s.get('id')) === -1) {
-                invalidRelationTargets[s.get('id')] = true;
-              }
-            });
-
-            // Fade elements to which we can't relate.
-            // Rather than two loops this marks
-            // all services as selecable and then
-            // removes the invalid ones
-            view.fade(view.vis.selectAll('.service')
-              .classed('selectable-service', true)
-              .filter(function(d) {
-                  return (d.id in invalidRelationTargets &&
-                          d.id !== m.id);
-                }))
-              .classed('selectable-service', false);
-
-
-
+            var service = view.serviceForBox(m);
+            view.startRelation(service);
             // Store start service in attrs.
             view.set('addRelationStart_service', m);
-            // Store possible endpoints.
-            view.set('addRelationStart_possibleEndpoints', endpoints);
-            // Set click action.
-            view.set('currentServiceClickAction', 'ambiguousAddRelationCheck');
           },
 
           /*
@@ -1479,19 +1550,8 @@
               return a[0].name + a[1].name < b[0].name + b[1].name;
             });
 
-            // Create a pending line if it doesn't exist, as in the case of
-            // clicking to add relation.
-            if (!view.dragline) {
-              var dragline = view.vis.insert('line', '.service')
-                  .attr('class', 'relation pending-relation dragline'),
-                  points = m.getConnectorPair(
-                      view.get('addRelationStart_service'));
-              dragline.attr('x1', points[0][0])
-                .attr('y1', points[0][1])
-                .attr('x2', points[1][0])
-                .attr('y2', points[1][1]);
-              view.dragline = dragline;
-            }
+            // Stop rubberbanding on mousemove.
+            view.clickAddRelation = null;
 
             // Display menu with available endpoints.
             var menu = container.one('#ambiguous-relation-menu');

=== modified file 'docs/style-guide.rst'
--- docs/style-guide.rst	2012-10-04 17:07:28 +0000
+++ docs/style-guide.rst	2012-11-08 17:28:23 +0000
@@ -5,6 +5,7 @@
 This guide is an attempt to describe a code style that both works well with the
 JavaScript beautifier and helps developers avoid pitfalls.
 
+
 Indentation
 ===========
 
@@ -13,18 +14,21 @@
 beautifier ("make beautify").  The lowest (least leading whitespace) acceptable
 indention will be applied.
 
+
 For loops
 =========
 
 Unless you are counting something, for loops (and for-in loops) are a trap.
 Use Y.Object.each instead.
 
+
 Whitespace
 ==========
 
 No trailing whitespace on lines or at the end of the file (i.e., the file
 should end with a non-blank line).
 
+
 Object literal formatting
 =========================
 
@@ -61,6 +65,7 @@
                 type: 'int'}},
         errors = utils.validate(values, schema);
 
+
 Chaining method calls
 =====================
 
@@ -118,6 +123,7 @@
             .bing()
             .zing());
 
+
 Creating HTML
 =============
 
@@ -148,3 +154,35 @@
 
 It is important that the indentation of the calls communicates the structure of
 the resulting DOM tree.  Compare and contrast the above examples.
+
+
+Comments
+========
+
+We use YUIDoc to document the applications internals.  YUIDoc comments
+start with "/**" and end with "*/".  The Makefile includes a simple
+linter that enforces YUIDoc comments for each function in the
+application.
+
+This simple linting sometimes means that functions that we might not
+otherwise document require documentation.  If a one-line comment is
+sufficient in those situations, a comment of this form may be used:
+
+    /** Handle errors */
+    error_callback: function(err) {
+      ...
+    }
+
+Most functions (or methods) will call for normal, multi-line YUIDoc
+comments like this:
+
+    /**
+     * Frob the thingy.
+     *
+     * @method frob
+     * @param {object} type How the thingy should be frobbed.
+     * @return {undefined} Side-effects only, eturns nothing.
+     */
+
+Full documentation for the various YUIDoc directives is at
+http://yui.github.com/yuidoc/syntax/ .

=== modified file 'test/test_environment_view.js'
--- test/test_environment_view.js	2012-11-01 13:21:53 +0000
+++ test/test_environment_view.js	2012-11-08 17:28:23 +0000
@@ -340,6 +340,9 @@
          container.all('.selectable-service')
                .size()
                .should.equal(2);
+         container.all('.dragline')
+               .size()
+               .should.equal(1);
          service.next().simulate('click');
          container.all('.selectable-service').size()
             .should.equal(0);
@@ -370,6 +373,28 @@
          view.get('rmrelation_dialog').hide();
        });
 
+    it('should stop creating a relation if the background is clicked',
+        function() {
+          var db = new models.Database(),
+              endpoint_map = {'service-1': {requires: [], provides: []}},
+              view = new views.environment(
+              { container: container,
+                db: db,
+                env: env,
+                getServiceEndpoints: function() {return endpoint_map;}}),
+              service = new models.Service({ id: 'service-1'});
+
+          db.services.add([service]);
+          view.render();
+
+          // If the user has clicked on the "Add Relation" menu item...
+          view.startRelation(service);
+          assert.isTrue(view.buildingRelation);
+          // ...clicking on the background causes the relation drag to stop.
+          view.backgroundClicked();
+          assert.isFalse(view.buildingRelation);
+        });
+
     // TODO: This will be fully testable once we have specification on the
     // list view itself.  Skipped until then.
     it.skip('must be able to switch between graph and list views',
@@ -390,6 +415,7 @@
         }
     );
   });
+
   describe('view model support infrastructure', function() {
     var Y, views, models;
 

=== modified file 'undocumented'
--- undocumented	2012-11-06 02:04:22 +0000
+++ undocumented	2012-11-08 17:28:23 +0000
@@ -110,7 +110,6 @@
 app/views/environment.js attachSceneEvents
 app/views/environment.js buildScene
 app/views/environment.js cancelRelationBuild
-app/views/environment.js click
 app/views/environment.js destroyService
 app/views/environment.js destroyServiceConfirm
 app/views/environment.js detachSceneEvents