Merge lp:~benji/charmworld/bundle-feature-ui into lp:~juju-jitsu/charmworld/trunk

[Benji York]

Add a user interface for setting the featured flag for bundles.

Add a user interface for setting the featured flag for bundles.

[lp:~benji/charmworld/bundle-feature-ui]

377. By Benji York on 2013-09-04

merge from trunk, fixing conflicts

378. By Benji York on 2013-09-04

fix failing test

[Brad Crittenden (bac)]

Thanks for cleaning up my lint in those tests.

At 206 except ValidationFailure as form:
  This use is too subtle, I think, if the intent is to re-assign the form variable for the remainder of the method. Perhaps catching it as a temporary and reassigning the real 'form' in the handler would be more explicit.

The rest looks good. The tests are nice. Thanks for including the routing test, we need more of them.

QA:

http://127.0.0.1:2464/~bac/bundles/wiki/wiki/featured/edit

This URL should not be supported and gives a 404

http://127.0.0.1:2464/bundles/wiki/wiki/featured/edit

This one, maybe should be supported, but it is not promulgated. It cause an exception to be raised in bundle_featured_edit because find_bundle returns None.

I think you should call found(bundle) to force a 404 in this case.

review: Needs Fixing

[lp:~benji/charmworld/bundle-feature-ui]

379. By Benji York on 2013-09-04

make non-promulgated charms and bundles generate a 404 when the feature edit form is visited

[Brad Crittenden (bac)]

Thanks

review: Approve (code)

=== modified file 'charmworld/routes.py'
--- charmworld/routes.py	2013-09-03 19:57:54 +0000
+++ charmworld/routes.py	2013-09-04 16:51:29 +0000
@@ -83,9 +83,11 @@
     # Quality Assessment
     config.add_route('charm-qa-edit', 'charms/{charm}/{series}/qa/edit')
 
-    # Featured charms
+    # Featured charms and bundles.
     config.add_route('charm-featured-edit',
                      'charms/{series}/{charm}/featured/edit')
+    config.add_route('bundle-featured-edit',
+                     'bundles/{basket}/{bundle}/featured/edit')
 
     # Search
     config.add_route("search", "/search")

=== modified file 'charmworld/search.py'
--- charmworld/search.py	2013-09-04 13:38:14 +0000
+++ charmworld/search.py	2013-09-04 16:51:29 +0000
@@ -135,9 +135,9 @@
         settings = get_ini()
         self._client.create_index(
             self.index_name, settings={
-                "index" : {
-                    "number_of_shards" : settings['es_shards'],
-                    "number_of_replicas" : settings['es_replicas'],
+                "index": {
+                    "number_of_shards": settings['es_shards'],
+                    "number_of_replicas": settings['es_replicas'],
                 }
             })
         # The ES server may need some time to actually create the index

=== modified file 'charmworld/views/bundles.py'
--- charmworld/views/bundles.py	2013-08-29 13:55:25 +0000
+++ charmworld/views/bundles.py	2013-09-04 16:51:29 +0000
@@ -4,7 +4,10 @@
 from charmworld import cached_view_config
 from charmworld.models import Bundle
 from charmworld.views.api import json_response
-from charmworld.views.helpers import found
+from charmworld.views.helpers import (
+    find_bundle,
+    found,
+)
 
 
 class BundleDetail(Bundle):
@@ -63,27 +66,6 @@
                 raise
 
 
-def find_bundle(request, promulgated=False):
-    """Find the bundle.
-
-    May return None, which must be handled by the caller.
-    """
-    spec = dict(
-        name=request.matchdict['bundle'],
-    )
-    basket = request.matchdict.get('basket')
-    rev = request.matchdict.get('rev')
-    if basket is not None:
-        spec['basket_name'] = basket
-    if rev is not None:
-        spec['basket_revision'] = int(rev)
-    if promulgated:
-        spec["promulgated"] = True
-    else:
-        spec["owner"] = request.matchdict['owner']
-    return Bundle.from_query(spec, request.db)
-
-
 def _bundle_view(request, bundle):
     bundle = BundleDetail(dict(bundle))
     try:

=== modified file 'charmworld/views/charms.py'
--- charmworld/views/charms.py	2013-08-30 21:03:41 +0000
+++ charmworld/views/charms.py	2013-09-04 16:51:29 +0000
@@ -8,13 +8,11 @@
 import json
 import os
 import pymongo
-from pyramid.httpexceptions import HTTPFound
 from pyramid.view import view_config
 from webob import Response
 
 from charmworld import cached_view_config
 from charmworld.forms.qa_assessment import get_qa_form_schema
-from charmworld.forms.featured import CharmFeaturedness
 from charmworld.models import (
     Charm,
     CharmFileSet,
@@ -30,6 +28,7 @@
 )
 from charmworld.views.api import API3
 from charmworld.views.helpers import (
+    find_charm,
     format_change,
     format_proof,
     found,
@@ -278,23 +277,6 @@
     return found_charm_collection(request.db, query, sub_only)
 
 
-def find_charm(request, promulgated=False):
-    spec = {
-        "name": request.matchdict['charm'],
-        "series": request.matchdict['series'],
-    }
-    if promulgated:
-        spec["promulgated"] = True
-    else:
-        spec["owner"] = request.matchdict['owner']
-    charm_data = found(request.db.charms.find_one(
-        spec, sort=[('store_data.revision', pymongo.DESCENDING)]))
-    # We are phasing out is_featured from the charm data, so remove it if this
-    # is an old charm record that still has it.
-    charm_data.pop('is_featured', None)
-    return charm_data
-
-
 @cached_view_config(
     route_name="personal-charm",
     renderer="charmworld:templates/charm.pt")
@@ -437,38 +419,3 @@
         'form': form,
         "values": valid_data,
     }
-
-
-@view_config(
-    route_name="charm-featured-edit",
-    renderer='charmworld:templates/qa_edit.pt',
-    permission='edit',
-)
-def featured_edit(request):
-    charm = find_charm(request, promulgated=True)
-    form = Form(CharmFeaturedness(), buttons=('submit',))
-    form.css_class = 'form-horizontal well'
-    featured_source = FeaturedSource.from_db(request.db)
-
-    if 'submit' in request.POST:
-        try:
-            data = request.POST.items()
-            valid_data = form.validate(data)
-            if valid_data['is_featured']:
-                featured_source.set_featured(charm, 'charm')
-            else:
-                featured_source.clear_featured(charm, 'charm')
-            series = request.matchdict['series']
-            name = request.matchdict['charm']
-            url = request.route_url('charm', series=series, charm=name)
-            return HTTPFound(url)
-        except ValidationFailure as form:
-            valid_data = {}
-    else:
-        valid_data = {
-            'is_featured': featured_source.is_featured(charm, 'charm')}
-
-    return {
-        'form': form.render(valid_data),
-        'values': valid_data,
-    }

=== added file 'charmworld/views/featured.py'
--- charmworld/views/featured.py	1970-01-01 00:00:00 +0000
+++ charmworld/views/featured.py	2013-09-04 16:51:29 +0000
@@ -0,0 +1,81 @@
+# Copyright 2012, 2013 Canonical Ltd.  This software is licensed under the
+# GNU Affero General Public License version 3 (see the file LICENSE).
+
+from deform import (
+    Form,
+    ValidationFailure,
+)
+from pyramid.httpexceptions import HTTPFound
+from pyramid.view import view_config
+
+from charmworld.forms.featured import CharmFeaturedness
+from charmworld.models import FeaturedSource
+from charmworld.views.helpers import (
+    find_charm,
+    find_bundle,
+    found,
+)
+
+
+def featured_edit(request, item, kind, url):
+    """Back end for featuring an "item" which can be a charm or bundle."""
+    form = Form(CharmFeaturedness(), buttons=('submit',))
+    form.css_class = 'form-horizontal well'
+    featured_source = FeaturedSource.from_db(request.db)
+
+    if 'submit' in request.POST:
+        try:
+            data = request.POST.items()
+            valid_data = form.validate(data)
+            if valid_data['is_featured']:
+                featured_source.set_featured(item, kind)
+            else:
+                featured_source.clear_featured(item, kind)
+            # Send the user back to the item's main page after saving.
+            return HTTPFound(url)
+        except ValidationFailure as form:
+            valid_data = {}
+    else:
+        valid_data = {
+            'is_featured': featured_source.is_featured(item, kind)}
+
+    return {
+        'form': form.render(valid_data),
+        'values': valid_data,
+    }
+
+
+@view_config(
+    route_name="charm-featured-edit",
+    renderer='charmworld:templates/qa_edit.pt',
+    permission='edit',
+)
+def charm_featured_edit(request):
+    """Back end for featuring a charm."""
+    charm = find_charm(request, promulgated=True)
+    found(charm)
+    series = request.matchdict['series']
+    charm_name = request.matchdict['charm']
+    url = request.route_url('charm', series=series, charm=charm_name)
+    return featured_edit(request, charm, 'charm', url)
+
+
+@view_config(
+    route_name="bundle-featured-edit",
+    renderer='charmworld:templates/qa_edit.pt',
+    permission='edit',
+)
+def bundle_featured_edit(request):
+    """Back end for featuring a bundle."""
+    bundle = find_bundle(request, promulgated=True)
+    # Assert that the bundle was found, generating a 404 if not.
+    found(bundle)
+    basket = request.matchdict.get('basket')
+    basket_name = request.matchdict.get('bundle')
+    # Since there is not yet a web page for promulgated bundles, we redirect
+    # to the owner's page for the bundle.
+    # TODO Change this to the promulgated bundle page when they exist.
+    url = request.route_url(
+        'personal-bundle', owner=bundle.owner, basket=basket,
+        bundle=basket_name)
+    return featured_edit(request, dict(bundle), 'bundle', url)

=== modified file 'charmworld/views/helpers.py'
--- charmworld/views/helpers.py	2013-07-31 14:45:14 +0000
+++ charmworld/views/helpers.py	2013-09-04 16:51:29 +0000
@@ -3,13 +3,17 @@
 
 from datetime import datetime
 from pyramid.exceptions import NotFound
+import pymongo
 
-from charmworld.models import Charm
+from charmworld.models import (
+    Bundle,
+    Charm,
+)
 from charmworld.models import find_charms
 
-
 # View helpers used throughout various views
 
+
 def format_change(change, charm=None):
     """Format a bzr commit."""
     parts = []
@@ -131,3 +135,41 @@
         names.append(c.name)
     results.sort(lambda x, y: cmp(x.name, y.name))
     return results
+
+
+def find_charm(request, promulgated=False):
+    spec = {
+        "name": request.matchdict['charm'],
+        "series": request.matchdict['series'],
+    }
+    if promulgated:
+        spec["promulgated"] = True
+    else:
+        spec["owner"] = request.matchdict['owner']
+    charm_data = found(request.db.charms.find_one(
+        spec, sort=[('store_data.revision', pymongo.DESCENDING)]))
+    # We are phasing out is_featured from the charm data, so remove it if this
+    # is an old charm record that still has it.
+    charm_data.pop('is_featured', None)
+    return charm_data
+
+
+def find_bundle(request, promulgated=False):
+    """Find the bundle.
+
+    May return None, which must be handled by the caller.
+    """
+    spec = dict(
+        name=request.matchdict['bundle'],
+    )
+    basket = request.matchdict.get('basket')
+    rev = request.matchdict.get('rev')
+    if basket is not None:
+        spec['basket_name'] = basket
+    if rev is not None:
+        spec['basket_revision'] = int(rev)
+    if promulgated:
+        spec["promulgated"] = True
+    else:
+        spec["owner"] = request.matchdict['owner']
+    return Bundle.from_query(spec, request.db)

=== modified file 'charmworld/views/tests/test_auth.py'
--- charmworld/views/tests/test_auth.py	2013-09-04 12:40:00 +0000
+++ charmworld/views/tests/test_auth.py	2013-09-04 16:51:29 +0000
@@ -56,8 +56,8 @@
 
     def test_login_route(self):
         path = '/login/openid'
-        response = self.app.get(path, status=200)
+        self.app.get(path, status=200)
 
     def test_logout_route(self):
         path = '/logout'
-        response = self.app.get(path, status=302)
+        self.app.get(path, status=302)

=== modified file 'charmworld/views/tests/test_charms.py'
--- charmworld/views/tests/test_charms.py	2013-08-30 21:03:41 +0000
+++ charmworld/views/tests/test_charms.py	2013-09-04 16:51:29 +0000
@@ -10,7 +10,6 @@
 from charmworld.models import (
     Charm,
     CharmSource,
-    FeaturedSource,
     QADataSource,
     getfs,
 )
@@ -37,7 +36,6 @@
     found_charm_collection,
     hook,
     interface,
-    featured_edit,
     personal_collection,
     personal_config,
     personal_hook,
@@ -746,100 +744,3 @@
                 charm['series']),
                 status=200)
             self.assertEqual(resp.status_code, 200)
-
-
-class TestFeaturedForm(ViewTestBase):
-
-    def test_form_renders(self):
-        """Sanity check that the form renders without errors."""
-        cid, charm = factory.makeCharm(self.db, promulgated=True, owner='foo')
-        request = self.getRequest()
-        request.matchdict = {
-            'charm': charm['name'],
-            'series': charm['series'],
-        }
-        response = featured_edit(request)
-
-        self.assertIn('form', response)
-        self.assertIn('<label', response['form'])
-
-    def test_checking_checkbox_sets_featured_status(self):
-        """Verify checking the checkbox causes the charm to be featured."""
-        charm = factory.get_charm_json(name='name1', promulgated=True)
-        self.use_index_client()
-        self.enable_routes()
-        charm_source = CharmSource.from_request(self)
-        charm_source.save(charm)
-        # Add the submit button to trigger the right path through the view.
-        post_data = {
-            '_charset_': 'UTF-8',
-            '__formid__': 'deform',
-            'submit': 'submit',
-            'is_featured': 'true',
-        }
-        request = self.getRequest(post=post_data)
-        request.matchdict = {
-            'charm': charm['name'],
-            'series': charm['series'],
-        }
-        # Before processing the request, the charm is not featured.
-        featured_source = FeaturedSource.from_db(self.db)
-        self.assertFalse(featured_source.is_featured(charm, 'charm'))
-        response = featured_edit(request)
-        self.assertEqual(302, response.status_code)
-        self.assertRegexpMatches(response.headers['Location'],
-                                 'http://[^/]*/charms/precise/name1')
-        for found in charm_source._get_all(charm['_id']):
-            self.assertTrue(featured_source.is_featured(found, 'charm'))
-
-    def test_unchecking_checkbox_clears_featured_status(self):
-        """Verify unchecking the checkbox causes the charm to be unfeatured."""
-        charm = factory.get_charm_json(name='name1', promulgated=True)
-        self.use_index_client()
-        self.enable_routes()
-        charm_source = CharmSource.from_request(self)
-        charm_source.save(charm)
-        # Add the submit button to trigger the right path through the view.
-        post_data = {
-            '_charset_': 'UTF-8',
-            '__formid__': 'deform',
-            'submit': 'submit',
-        }
-        request = self.getRequest(post=post_data)
-        request.matchdict = {
-            'charm': charm['name'],
-            'series': charm['series'],
-        }
-        # Before processing the request, the charm is featured.
-        featured_source = FeaturedSource.from_db(self.db)
-        featured_source.set_featured(charm, 'charm')
-        self.assertTrue(featured_source.is_featured(charm, 'charm'))
-        response = featured_edit(request)
-        self.assertEqual(302, response.status_code)
-        self.assertRegexpMatches(response.headers['Location'],
-                                 'http://[^/]*/charms/precise/name1')
-        for found in charm_source._get_all(charm['_id']):
-            self.assertFalse(featured_source.is_featured(found, 'charm'))
-
-
-class TestFeaturedFormFunc(WebTestBase):
-
-    def test_form_403s_for_non_charmers(self):
-        """The form is not permitted if you're not a charmer."""
-        with login_request(self.app, groups=[]) as resp:
-            cid, charm = factory.makeCharm(self.db)
-            # The status force the check against the status code.
-            resp = resp.goto(
-                'charms/%s/%s/featured/edit' %
-                (charm['series'], charm['name']), status=403)
-            self.assertEqual(403, resp.status_code)
-
-    def test_form_secured_from_users(self):
-        """The form is only allowed to be edited/submitted by charmers."""
-        with login_request(self.app, groups=['charmers']) as resp:
-            cid, charm = factory.makeCharm(self.db, promulgated=True)
-            resp = resp.goto(
-                'charms/%s/%s/featured/edit' %
-                (charm['series'], charm['name']),
-                status=200)
-            self.assertEqual(resp.status_code, 200)

=== added file 'charmworld/views/tests/test_featured.py'
--- charmworld/views/tests/test_featured.py	1970-01-01 00:00:00 +0000
+++ charmworld/views/tests/test_featured.py	2013-09-04 16:51:29 +0000
@@ -0,0 +1,223 @@
+# Copyright 2012, 2013 Canonical Ltd.  This software is licensed under the
+# GNU Affero General Public License version 3 (see the file LICENSE).
+
+from charmworld.models import (
+    CharmSource,
+    FeaturedSource,
+)
+from charmworld.testing import (
+    factory,
+    login_request,
+    ViewTestBase,
+    WebTestBase,
+)
+from charmworld.views.featured import (
+    bundle_featured_edit,
+    charm_featured_edit,
+    featured_edit,
+)
+
+
+class TestFeaturedForm(ViewTestBase):
+
+    def test_form_renders(self):
+        """Sanity check that the form renders without errors."""
+        cid, charm = factory.makeCharm(self.db, promulgated=True, owner='foo')
+        request = self.getRequest()
+        request.matchdict = {
+            'charm': charm['name'],
+            'series': charm['series'],
+        }
+        response = featured_edit(request, charm, 'charm', '')
+
+        self.assertIn('form', response)
+        self.assertIn('<label', response['form'])
+
+    def test_form_includes_current_featured_value(self):
+        """GET requests result in the current featured value being returned."""
+        cid, charm = factory.makeCharm(self.db, promulgated=True, owner='foo')
+        request = self.getRequest()
+        request.matchdict = {
+            'charm': charm['name'],
+            'series': charm['series'],
+        }
+        response = featured_edit(request, charm, 'charm', '')
+        self.assertFalse(response['values']['is_featured'])
+
+    def test_checking_checkbox_sets_featured_status(self):
+        """Verify checking the checkbox causes the charm to be featured."""
+        charm = factory.get_charm_json(name='name1', promulgated=True)
+        self.use_index_client()
+        self.enable_routes()
+        charm_source = CharmSource.from_request(self)
+        charm_source.save(charm)
+        # Add the submit button to trigger the right path through the view.
+        post_data = {
+            '_charset_': 'UTF-8',
+            '__formid__': 'deform',
+            'submit': 'submit',
+            'is_featured': 'true',
+        }
+        request = self.getRequest(post=post_data)
+        request.matchdict = {
+            'charm': charm['name'],
+            'series': charm['series'],
+        }
+        # Before processing the request, the charm is not featured.
+        featured_source = FeaturedSource.from_db(self.db)
+        self.assertFalse(featured_source.is_featured(charm, 'charm'))
+        featured_edit(request, charm, 'charm', '')
+        for found in charm_source._get_all(charm['_id']):
+            self.assertTrue(featured_source.is_featured(found, 'charm'))
+
+    def test_unchecking_checkbox_clears_featured_status(self):
+        """Verify unchecking the checkbox causes the charm to be unfeatured."""
+        charm = factory.get_charm_json(name='name1', promulgated=True)
+        self.use_index_client()
+        self.enable_routes()
+        charm_source = CharmSource.from_request(self)
+        charm_source.save(charm)
+        # Add the submit button to trigger the right path through the view.
+        post_data = {
+            '_charset_': 'UTF-8',
+            '__formid__': 'deform',
+            'submit': 'submit',
+        }
+        request = self.getRequest(post=post_data)
+        request.matchdict = {
+            'charm': charm['name'],
+            'series': charm['series'],
+        }
+        # Before processing the request, the charm is featured.
+        featured_source = FeaturedSource.from_db(self.db)
+        featured_source.set_featured(charm, 'charm')
+        self.assertTrue(featured_source.is_featured(charm, 'charm'))
+        featured_edit(request, charm, 'charm', '')
+        for found in charm_source._get_all(charm['_id']):
+            self.assertFalse(featured_source.is_featured(found, 'charm'))
+
+    def test_redirect_on_submit(self):
+        """After a submit, an HTTP redirect is raised with the given URL."""
+        charm = factory.get_charm_json(name='name1', promulgated=True)
+        self.use_index_client()
+        self.enable_routes()
+        charm_source = CharmSource.from_request(self)
+        charm_source.save(charm)
+        # Add the submit button to trigger the right path through the view.
+        post_data = {
+            '_charset_': 'UTF-8',
+            '__formid__': 'deform',
+            'submit': 'submit',
+            'is_featured': 'true',
+        }
+        request = self.getRequest(post=post_data)
+        request.matchdict = {
+            'charm': charm['name'],
+            'series': charm['series'],
+        }
+        # Before processing the request, the charm is not featured.
+        featured_source = FeaturedSource.from_db(self.db)
+        self.assertFalse(featured_source.is_featured(charm, 'charm'))
+        response = featured_edit(request, charm, 'charm', 'URL')
+        self.assertEqual(302, response.status_code)
+        self.assertEqual(response.headers['Location'], 'URL')
+
+
+class TestFeaturedCharmForm(ViewTestBase, WebTestBase):
+
+    def setUp(self):
+        super(TestFeaturedCharmForm, self).setUp()
+        # Register the routes so URL construction will work in the tests.
+        self.enable_routes()
+
+    def test_form_renders(self):
+        """Sanity check that the form renders without errors."""
+        cid, charm = factory.makeCharm(self.db, promulgated=True, owner='foo')
+        request = self.getRequest()
+        request.matchdict = {
+            'charm': charm['name'],
+            'series': charm['series'],
+        }
+        response = charm_featured_edit(request)
+
+        self.assertIn('form', response)
+        self.assertIn('<label', response['form'])
+
+    def test_charm_feature_form_route(self):
+        """The charm feature form is wired up to a route."""
+        charm = factory.makeCharm(self.db, promulgated=True, owner='foo')[1]
+        url = '/charms/{series}/{name}/featured/edit'.format(**charm)
+        with login_request(self.app, groups=['charmers']):
+            # Get the URL and assert the given status code.
+            self.app.get(url, status=200)
+
+    def test_404_if_charm_is_not_promulgated(self):
+        # If the charm indicated by the URL does not exist, a 404 is generated.
+        charm = factory.makeCharm(self.db, promulgated=False, owner='foo')[1]
+        url = '/charms/{series}/{name}/featured/edit'.format(**charm)
+        with login_request(self.app, groups=['charmers']):
+            # Get the URL and assert the given status code.
+            self.app.get(url, status=404)
+
+
+class TestFeaturedBundleForm(ViewTestBase, WebTestBase):
+
+    def setUp(self):
+        super(TestFeaturedBundleForm, self).setUp()
+        # Register the routes so URL construction will work in the tests.
+        self.enable_routes()
+
+    def test_form_renders(self):
+        """Sanity check that the form renders without errors."""
+        bundle, bundle_data = factory.makeBundle(self.db, promulgated=True)
+        request = self.getRequest()
+        request.matchdict = {
+            'bundle': bundle_data['name'],
+            'basket': bundle_data['basket_name'],
+        }
+        response = bundle_featured_edit(request)
+
+        self.assertIn('form', response)
+        self.assertIn('<label', response['form'])
+
+    def test_bundle_feature_form_route(self):
+        """The bundle feature form is wired up to a route."""
+        bundle, bundle_data = factory.makeBundle(self.db, promulgated=True)
+        url = '/bundles/{basket_name}/{name}/featured/edit'.format(
+            **bundle_data)
+        with login_request(self.app, groups=['charmers']):
+            # Get the URL and assert the given status code.
+            self.app.get(url, status=200)
+
+    def test_404_generated_when_bundle_is_not_promulgated(self):
+        # If the bundle indicated by the URL does not exist, a 404 is
+        # generated.
+        bundle, bundle_data = factory.makeBundle(self.db, promulgated=False)
+        url = '/bundles/{basket_name}/{name}/featured/edit'.format(
+            **bundle_data)
+        with login_request(self.app, groups=['charmers']):
+            # Get the URL and assert the given status code.
+            self.app.get(url, status=404)
+
+
+class TestFeaturedFormAuthorization(WebTestBase):
+
+    def test_form_403s_for_non_charmers(self):
+        """The form is not permitted if you're not a charmer."""
+        with login_request(self.app, groups=[]) as resp:
+            cid, charm = factory.makeCharm(self.db)
+            # The status force the check against the status code.
+            resp = resp.goto(
+                'charms/%s/%s/featured/edit' %
+                (charm['series'], charm['name']), status=403)
+            self.assertEqual(403, resp.status_code)
+
+    def test_form_secured_from_users(self):
+        """The form is only allowed to be edited/submitted by charmers."""
+        with login_request(self.app, groups=['charmers']) as resp:
+            cid, charm = factory.makeCharm(self.db, promulgated=True)
+            resp = resp.goto(
+                'charms/%s/%s/featured/edit' %
+                (charm['series'], charm['name']),
+                status=200)
+            self.assertEqual(resp.status_code, 200)