lp:~benji/charmworld/bug-1229179

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:~juju-jitsu/charmworld/trunk at revision 432

Juju-Jitsu Hackers: Pending requested 2013-10-29

Diff: 108 lines (+47/-4)

3 files modified

charmworld/routes.py (+4/-2)
charmworld/views/bundles.py (+3/-1)
charmworld/views/tests/test_bundles.py (+40/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

432. By Benji York on 2013-10-29

make routing a bundle ID without a revision actually work (bug 1229179)

431. By Aaron Bentley on 2013-10-25

Remove 018 migration; before an exodus and already deployed to production.

Approved by Juju Gui Bot, Brad Crittenden.

430. By Benji York on 2013-10-25

Add handling for "-HEAD" revisions to API2

R=bac
CC=
https://codereview.appspot.com/16950043

429. By Brad Crittenden on 2013-10-24

Add changelog to bundle page.

R=benji
CC=
https://codereview.appspot.com/16690043

428. By Brad Crittenden on 2013-10-23

Fix ingest KeyError for 'branch_deleted'.

R=
CC=
https://codereview.appspot.com/16240044

427. By Benji York on 2013-10-23

Add recent bzr changes to bundles.

R=bac
CC=
https://codereview.appspot.com/15100046

426. By Richard Harding on 2013-10-22

Refactory the proof api to be it's own module.

- Break out the proof api bits into a new api module vs the same api file.
- Move tests and fix to match
- Remove the model in the lib bits and try to keep things in views/models.

Approved by Juju Gui Bot.

425. By Brad Crittenden on 2013-10-22

Parse charms with hyphens properly.

R=benji
CC=
https://codereview.appspot.com/15580047

424. By Richard Harding on 2013-10-18

Add charm config proofing and update api response

- Move proof logic into a new lib/proof.py module
- Update the proof api call to look through the bundles and proof them
- Change errors to be catchable exceptions, the exception contains both a msg
and debug_info we expose via the api call
- Update the api call to provide a summary error_messages (for Marco's needs)
but keep the details in the actual list of errors with the messages and the
debug info we have that went into those errors.

Sample proof api call and response:
http://paste.mitechie.com/show/1049/

Note: this is only adding the new proof checks of validating the
config/options from the charm found in the database to the options defined in
the bundle.

- Validate the option exists in the charm we found in the db
- Validate that the type is of the correct type.
- Validate that the charm we found has options at all.

QA
---
You have to ingest the charms so that we can validate them. You can then toss
the yaml file (as a single string) to the proof api endpoint as a POST'd key
deployer_file. Right now it only handles yaml.

R=
CC=
https://codereview.appspot.com/14789043

423. By Brad Crittenden on 2013-10-18

Make queue and ingest handle prior charm revs.

In order to support multiple charm revisions, the queueing and ingest
processes must support older revisions of charms.

Up to 10 old revisions of a charm are queued up for ingesting. A charm that
is not the latest revision is not updated in the database if it already
exists. A current revision of the charm is updated even if it exists. This
updating may not be required as a charm cannot change without updating the
revision.

Approved by Juju Gui Bot, Richard Harding.