Merge lp:~benji/charms/precise/juju-gui/remove-default-view-mode-config into lp:~juju-gui/charms/precise/juju-gui/trunk
Proposed by
Benji York
Status: | Merged |
---|---|
Merged at revision: | 147 |
Proposed branch: | lp:~benji/charms/precise/juju-gui/remove-default-view-mode-config |
Merge into: | lp:~juju-gui/charms/precise/juju-gui/trunk |
Diff against target: |
104 lines (+2/-24) 6 files modified
config.yaml (+0/-10) config/config.js.template (+0/-1) hooks/backend.py (+0/-1) hooks/utils.py (+2/-3) tests/test_backends.py (+0/-2) tests/test_utils.py (+0/-7) |
To merge this branch: | bzr merge lp:~benji/charms/precise/juju-gui/remove-default-view-mode-config |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
charmers | Pending | ||
Review via email: mp+201111@code.launchpad.net |
Description of the change
remove defaultViewMode config variable
To post a comment you must log in.
Reviewers: mp+201111_ code.launchpad. net,
Message:
Please take a look.
Description:
remove defaultViewMode config variable
https:/ /code.launchpad .net/~benji/ charms/ precise/ juju-gui/ remove- default- view-mode- config/ +merge/ 201111
(do not edit description out of merge proposal)
Please review this at https:/ /codereview. appspot. com/50180043/
Affected files (+4, -24 lines): config. js.template backends. py
A [revision details]
M config.yaml
M config/
M hooks/backend.py
M hooks/utils.py
M tests/test_
M tests/test_utils.py
Index: [revision details]
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision: <email address hidden>
+New revision: <email address hidden>
Index: config.yaml get-juju- button:
=== modified file 'config.yaml'
--- config.yaml 2013-10-09 08:56:20 +0000
+++ config.yaml 2014-01-09 21:48:27 +0000
@@ -168,16 +168,6 @@
allow us to improve our tool based on your experience.
type: string
default: UA-41463568-2
- default-viewmode:
- description: |
- What the default viewmode for the charmbrowser should be. Possible
options are:
- - 'sidebar' (default): the charmwbrowser will appear as a sidebar.
This
- is also known as build mode.
- - 'fullscreen': the charmbrowser will appear in full screen, hiding
the
- canvas. This is also known as browse mode.
- - 'minimized': the charmbrowser will be minimized by default, and
hidden.
- type: string
- default: sidebar
show-
description: |
There are deployment modes for Juju GUI which are not intended as
regular
Index: config/ config. js.template config. js.template' config. js.template 2013-09-12 18:15:19 +0000 config. js.template 2014-01-09 21:48:27 +0000 viewmode} }, Button: {{show_ get_juju_ button} }
=== modified file 'config/
--- config/
+++ config/
@@ -24,6 +24,5 @@
sandbox: {{sandbox}},
GA_key: {{ga_key}},
login_help: {{login_help}},
- defaultViewmode: {{default_
showGetJuju
};
Index: hooks/backend.py
config[ 'read-only' ], config['staging'], 'charmworld- url'],
build_dir, secure= config[ 'secure' ], sandbox= config[ 'sandbox' ],
ga_key= config[ 'ga-key' ], viewmode= config[ 'default- viewmode' ],
show_get_ juju_button= config[ 'show-get- juju-button' ],
password= config. get('password' ))
=== modified file 'hooks/backend.py'
--- hooks/backend.py 2013-11-15 14:56:04 +0000
+++ hooks/backend.py 2014-01-09 21:48:27 +0000
@@ -152,7 +152,6 @@
config[
- default_
# Expose the service.
Index: hooks/utils.py
console_ enabled, login_help, readonly, in_staging, charmworld_url,
build_ dir, secure=True, sandbox=False, viewmode= 'sidebar' , show_get_ juju_button= False, js_path= None, ga_key='', password=None): juju_button= ...
=== modified file 'hooks/utils.py'
--- hooks/utils.py 2013-11-15 14:56:04 +0000
+++ hooks/utils.py 2014-01-09 21:48:27 +0000
@@ -410,8 +410,8 @@
def write_gui_config(
- default_
- config_
+ show_get_