Thanks for this branch Benji: LGTM with minors.
https://codereview.appspot.com/76860047/diff/1/scripts/charmsupport/nrpe.py File scripts/charmsupport/nrpe.py (right):
https://codereview.appspot.com/76860047/diff/1/scripts/charmsupport/nrpe.py#newcode113 scripts/charmsupport/nrpe.py:113: def service_file_name(self, nagios_context, hostname): nagios_context seems unused in this method.
https://codereview.appspot.com/76860047/diff/1/scripts/charmsupport/nrpe.py#newcode130 scripts/charmsupport/nrpe.py:130: nrpe_service_file = '{}/service__{}_check_{}.cfg'.format( The nrpe_service_file is retrieved using the external method in the next line, so I think we can safely remove this one.
https://codereview.appspot.com/76860047/diff/1/scripts/update-nrpe.py File scripts/update-nrpe.py (right):
https://codereview.appspot.com/76860047/diff/1/scripts/update-nrpe.py#newcode25 scripts/update-nrpe.py:25: remove_nrpe_check() So we always remove checks and then add them (or remove them again) based on the hook name. Is the second removal needed?
https://codereview.appspot.com/76860047/
« Back to merge proposal
Thanks for this branch Benji: LGTM with minors.
https:/ /codereview. appspot. com/76860047/ diff/1/ scripts/ charmsupport/ nrpe.py charmsupport/ nrpe.py (right):
File scripts/
https:/ /codereview. appspot. com/76860047/ diff/1/ scripts/ charmsupport/ nrpe.py# newcode113 charmsupport/ nrpe.py: 113: def service_ file_name( self,
scripts/
nagios_context, hostname):
nagios_context seems unused in this method.
https:/ /codereview. appspot. com/76860047/ diff/1/ scripts/ charmsupport/ nrpe.py# newcode130 charmsupport/ nrpe.py: 130: nrpe_service_file = _{}_check_ {}.cfg' .format(
scripts/
'{}/service_
The nrpe_service_file is retrieved using the external method in the next
line, so I think we can safely remove this one.
https:/ /codereview. appspot. com/76860047/ diff/1/ scripts/ update- nrpe.py update- nrpe.py (right):
File scripts/
https:/ /codereview. appspot. com/76860047/ diff/1/ scripts/ update- nrpe.py# newcode25 update- nrpe.py: 25: remove_nrpe_check()
scripts/
So we always remove checks and then add them (or remove them again)
based on the hook name. Is the second removal needed?
https:/ /codereview. appspot. com/76860047/