Code review comment for lp:~benji/charms/precise/juju-gui/bug-1284088

Revision history for this message
Francesco Banconi (frankban) wrote :

Thanks for this branch Benji: LGTM with minors.
File scripts/charmsupport/ (right):
scripts/charmsupport/ def service_file_name(self,
nagios_context, hostname):
nagios_context seems unused in this method.
scripts/charmsupport/ nrpe_service_file =
The nrpe_service_file is retrieved using the external method in the next
line, so I think we can safely remove this one.
File scripts/ (right):
scripts/ remove_nrpe_check()
So we always remove checks and then add them (or remove them again)
based on the hook name. Is the second removal needed?

« Back to merge proposal