Merge lp:~benji/charms/oneiric/buildbot-slave/integration into lp:~yellow/charms/oneiric/buildbot-slave/trunk

Proposed by Benji York
Status: Merged
Approved by: Gary Poster
Approved revision: 15
Merged at revision: 19
Proposed branch: lp:~benji/charms/oneiric/buildbot-slave/integration
Merge into: lp:~yellow/charms/oneiric/buildbot-slave/trunk
Diff against target: 11 lines (+3/-0)
1 file modified
hooks/install (+3/-0)
To merge this branch: bzr merge lp:~benji/charms/oneiric/buildbot-slave/integration
Reviewer Review Type Date Requested Status
Gary Poster (community) Approve
Review via email: mp+95381@code.launchpad.net

Description of the change

Add the buildbot user to a group as a work-around to an LXC bug in lxc-start-ephemeral.

To post a comment you must log in.
Revision history for this message
Gary Poster (gary) wrote :

As we discussed, please add the bug number.

Thank you

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hooks/install'
2--- hooks/install 2012-02-29 22:45:07 +0000
3+++ hooks/install 2012-03-01 15:18:19 +0000
4@@ -170,6 +170,9 @@
5 # need (e.g. those that create lxc containers). We choose sh as
6 # a standard and basic "system" shell.
7 run('usermod', '-s', '/bin/sh', 'buildbot')
8+ # Some versions of LXC require the user to have a group.
9+ run('addgroup', 'buildbot')
10+ run('usermod', '--gid', 'buildbot', 'buildbot')
11 sys.exit(handle_script(retrieve, url, path, args))
12
13

Subscribers

People subscribed via source and target branches

to all changes: