Merge lp:~ben-kietzman/ubuntu/quantal/yasm/fix-for-1064341 into lp:ubuntu/quantal/yasm

Proposed by Ben Kietzman
Status: Rejected
Rejected by: Stéphane Graber
Proposed branch: lp:~ben-kietzman/ubuntu/quantal/yasm/fix-for-1064341
Merge into: lp:ubuntu/quantal/yasm
Diff against target: 26 lines (+7/-1)
2 files modified
debian/changelog (+6/-0)
modules/preprocs/gas/gas-preproc.c (+1/-1)
To merge this branch: bzr merge lp:~ben-kietzman/ubuntu/quantal/yasm/fix-for-1064341
Reviewer Review Type Date Requested Status
Jamie Strandboge Disapprove
Ubuntu branches Pending
Review via email: mp+140267@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Jamie Strandboge (jdstrand) wrote :

Thanks for your patch! Unfortunately this patch does not qualify for a stable release update as per https://wiki.ubuntu.com/StableReleaseUpdates#When. I checked Ubuntu 13.04 and it no longer has the error string. Thanks again for your patch.

review: Disapprove

Unmerged revisions

17. By Ben Kietzman

Fixed typo. Changed "implimented" to "implemented". (Closes: #1064341)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2012-10-08 23:34:17 +0000
3+++ debian/changelog 2012-12-17 18:01:24 +0000
4@@ -1,3 +1,9 @@
5+yasm (1.1.0-1ubuntu2) quantal; urgency=low
6+
7+ * Fixed typo. Changed "implimented" to "implemented". (Closes: #1064341)
8+
9+ -- Ben Kietzman <ben@office> Mon, 17 Dec 2012 11:51:50 -0600
10+
11 yasm (1.1.0-1build1) quantal; urgency=low
12
13 * Rebuild for new armel compiler default of ARMv5t.
14
15=== modified file 'modules/preprocs/gas/gas-preproc.c'
16--- modules/preprocs/gas/gas-preproc.c 2011-06-10 01:05:23 +0000
17+++ modules/preprocs/gas/gas-preproc.c 2012-12-17 18:01:24 +0000
18@@ -636,7 +636,7 @@
19 return 0;
20 }
21 /* TODO */
22- yasm_error_set(YASM_ERROR_SYNTAX, N_("redefining symbols not yet implimented"), name);
23+ yasm_error_set(YASM_ERROR_SYNTAX, N_("redefining symbols not yet implemented"), name);
24 yasm_errwarn_propagate(pp->errwarns, pp->current_line_number);
25 return 0;
26 } else {

Subscribers

People subscribed via source and target branches

to all changes: