Merge lp:~bellini666/stoq/pyflakes_improvements into lp:~stoq-dev/stoq/master

[Thiago Bellini]

Correções do Pyflakes e adição de testes.

* Corrigi vários erros e warnings de pyflakes pelo código (stoq, stoqlib e plugins).
* Alguns lugares a correção é estranha, como a remoção de um método inteiro. Esses casos era porque esse método estava sendo redefinido em baixo, logo não estava sendo usado. Até mesmo alguns erros de variáveis não definidas foram resolvidos. (o caso do charts, onde adicionei um XXX, aquela classe pelo log tem apenas a implementação inicial e lá mesmo diz que ela não funciona).
* Adicionei testes para testar pyflakes em stoq, stoqlib e plugins. Vai ser EXTREMAMENTE ÚTIL para encontrar erros de syntax que cometemos as vezes, e podem acabar despercebidos até um usuário chamar aquela função.

Não fiz nenhuma mudança funcional no código, apenas correções de pyflakes mesmo! Rodei os testes sem STOQLIB_TEST_QUICK e testei a gui em várias partes para ter certeza de que tudo ainda estava dentro dos conformes.

[lp:~bellini666/stoq/pyflakes_improvements]

4389. By Launchpad Translations on behalf of stoq-dev on 2011-11-02

Launchpad automatic translations update.

4390. By Launchpad Translations on behalf of stoq-dev on 2011-11-03

Launchpad automatic translations update.

4391. By Johan Dahlin on 2011-11-04

Pass in self.wizard to all dialogs created in wizard steps

[Johan Dahlin (jdahlin-deactivatedaccount)]

muito legal,era isso faz tempo. nem olhei direito ms acredito que vale pena
comitar como esta. proximo passo seria pep8.py, mas isso vai ser bem mais
trabalhoso.

bom trabalho thiago

On Tuesday, November 1, 2011, Thiago Bellini <email address hidden>
wrote:
> Thiago Bellini has proposed merging
lp:~hackedbellini/stoq/pyflakes_improvements into lp:stoq.
>
> Requested reviews:
> Ronaldo Maia (romaia)
>
> For more details, see:
>
https://code.launchpad.net/~hackedbellini/stoq/pyflakes_improvements/+merge/80917
>
> Correções do Pyflakes e adição de testes.
>
> * Corrigi vários erros e warnings de pyflakes pelo código (stoq, stoqlib
e plugins).
> * Alguns lugares a correção é estranha, como a remoção de um método
inteiro. Esses casos era porque esse método estava sendo redefinido em
baixo, logo não estava sendo usado. Até mesmo alguns erros de variáveis não
definidas foram resolvidos. (o caso do charts, onde adicionei um XXX,
aquela classe pelo log tem apenas a implementação inicial e lá mesmo diz
que ela não funciona).
> * Adicionei testes para testar pyflakes em stoq, stoqlib e plugins. Vai
ser EXTREMAMENTE ÚTIL para encontrar erros de syntax que cometemos as
vezes, e podem acabar despercebidos até um usuário chamar aquela função.
>
> Não fiz nenhuma mudança funcional no código, apenas correções de pyflakes
mesmo! Rodei os testes sem STOQLIB_TEST_QUICK e testei a gui em várias
partes para ter certeza de que tudo ainda estava dentro dos conformes.
> --
>
https://code.launchpad.net/~hackedbellini/stoq/pyflakes_improvements/+merge/80917
> You are subscribed to branch lp:stoq.
>

--
Johan Dahlin

[lp:~bellini666/stoq/pyflakes_improvements]

4392. By Thiago Bellini on 2011-11-05

Correct 2 test methods names.

* test_runtime had a 'setDown' method. It wasn't really necessary as 'setUp'
  has it's logic in it. That's why it didn't interfered in nothing on test,
  since the right name for it would be 'tearDown'. Just removing it.
* TestReport's 'setUp' logic was written on 'tearUp'. For that reason, it
  wasn't being called and the workaround it tried to apply wasn't working (I
  didn't noticed it when I wrote the patch because I had no cache at the
  moment, and jenkins never fail on that test). Rename it and everything should
  be fine!

Maybe we should try to create a pattern on tests. Use 'setUp/setDown' or
'tearUp/tearDown' (I think the second makes more sense) to avoid problems like
that, that happened for distraction and the assumption of a pattern.

[Thiago Bellini (bellini666)]

Johan: Valeu :) Vou comitar então

=== modified file 'Makefile'
--- Makefile	2011-07-11 03:30:12 +0000
+++ Makefile	2011-11-05 17:07:26 +0000
@@ -29,7 +29,7 @@
 	pep8 stoq stoqlib
 
 pyflakes:
-	pyflakes stoq stoqlib
+	pyflakes stoq stoqlib plugins
 
 check:
 	LC_ALL=C trial stoq stoqlib

=== modified file 'plugins/books/bookssearch.py'
--- plugins/books/bookssearch.py	2011-05-19 17:52:30 +0000
+++ plugins/books/bookssearch.py	2011-11-05 17:07:26 +0000
@@ -32,7 +32,6 @@
 
 from stoqlib.domain.sellable import Sellable
 from stoqlib.gui.search.productsearch import ProductSearch
-from stoqlib.lib.defaults import sort_sellable_code
 from stoqlib.lib.translation import stoqlib_gettext as _
 from stoqlib.lib.formatters import format_quantity, get_formatted_cost
 

=== modified file 'plugins/books/booksslave.py'
--- plugins/books/booksslave.py	2011-02-08 14:06:58 +0000
+++ plugins/books/booksslave.py	2011-11-05 17:07:26 +0000
@@ -30,10 +30,7 @@
 from kiwi.datatypes import ValidationError
 
 from stoqlib.gui.editors.baseeditor import BaseEditorSlave
-from stoqlib.gui.slaves.sellableslave import SellableDetailsSlave
-from stoqlib.domain.interfaces import IStorable
 from stoqlib.domain.person import Person
-from stoqlib.domain.product import Product
 from stoqlib.lib.countries import get_countries
 from stoqlib.lib.translation import stoqlib_gettext
 

=== modified file 'plugins/books/booksui.py'
--- plugins/books/booksui.py	2011-02-08 14:06:58 +0000
+++ plugins/books/booksui.py	2011-11-05 17:07:26 +0000
@@ -22,8 +22,6 @@
 ## Author(s): Stoq Team <[e-mail]>
 ##
 
-import os
-
 import gtk
 
 from kiwi.log import Logger
@@ -31,7 +29,6 @@
 from stoqlib.database.runtime import get_connection
 from stoqlib.gui.base.dialogs import run_dialog
 from stoqlib.gui.events import StartApplicationEvent
-from stoqlib.lib.message import info
 from stoqlib.lib.translation import stoqlib_gettext
 
 from bookssearch import ProductBookSearch

=== modified file 'plugins/books/publishersearch.py'
--- plugins/books/publishersearch.py	2011-05-19 17:52:30 +0000
+++ plugins/books/publishersearch.py	2011-11-05 17:07:26 +0000
@@ -24,17 +24,10 @@
 
 """ Search dialog/Editor for publishers """
 
-from kiwi.argcheck import argcheck
-from kiwi.enums import SearchFilterPosition
-from kiwi.ui.search import ComboSearchFilter
-from kiwi.ui.objectlist import Column, SearchColumn
+from kiwi.ui.objectlist import SearchColumn
 
-from stoqlib.database.runtime import new_transaction
 from stoqlib.lib.translation import stoqlib_gettext
-from stoqlib.lib.formatters import format_phone_number
 
-from stoqlib.gui.base.search import SearchEditor, SearchDialog
-from stoqlib.gui.base.dialogs import run_dialog
 from stoqlib.gui.search.personsearch import BasePersonSearch
 from stoqlib.gui.templates.persontemplate import BasePersonRoleEditor
 

=== modified file 'plugins/ecf/ecfui.py'
--- plugins/ecf/ecfui.py	2011-10-05 19:46:41 +0000
+++ plugins/ecf/ecfui.py	2011-11-05 17:07:26 +0000
@@ -55,7 +55,6 @@
 from couponprinter import CouponPrinter
 from ecfdomain import ECFPrinter, FiscalSaleHistory
 from ecfprinterdialog import ECFListDialog
-from ecfprinterstatus import ECFAsyncPrinterStatus
 from ecfmemorydialog import FiscalMemoryDialog
 from paulistainvoicedialog import PaulistaInvoiceDialog
 
@@ -104,9 +103,6 @@
                 _("This operation requires a connected fiscal printer"))
 
         if not self._printer_verified:
-            domain = self._printer.get_printer()
-            driver = self._printer.get_driver()
-
             if not self._printer.check_serial():
                 raise DeviceError(
                     _("Fiscalprinters serial number is different!"))
@@ -198,7 +194,7 @@
         log.info('ecfui._check_printer')
         try:
             self._validate_printer()
-        except (DriverError, DeviceError), details:
+        except (DriverError, DeviceError):
             warning('Não foi possível comunicar com a impressora.')
             raise SystemExit
 

=== modified file 'plugins/ecf/tests/test_device.py'
--- plugins/ecf/tests/test_device.py	2011-06-21 13:31:33 +0000
+++ plugins/ecf/tests/test_device.py	2011-11-05 17:07:26 +0000
@@ -85,7 +85,6 @@
         settings = self.create_ecf_printer()
         settings.create_fiscal_printer_constants()
 
-        constants = list(settings.constants)
         for constant_type in [DeviceConstant.TYPE_UNIT,
                               DeviceConstant.TYPE_TAX,
                               DeviceConstant.TYPE_PAYMENT]:

=== modified file 'plugins/nfe/nfegenerator.py'
--- plugins/nfe/nfegenerator.py	2011-10-27 16:07:50 +0000
+++ plugins/nfe/nfegenerator.py	2011-11-05 17:07:26 +0000
@@ -30,9 +30,6 @@
 from xml.etree.ElementTree import Element
 from xml.sax.saxutils import escape
 
-from stoqdrivers.enum import TaxType
-
-import stoqlib
 from stoqlib.domain.interfaces import ICompany, IIndividual
 from stoqlib.exceptions import ModelDataError
 from stoqlib.lib.parameters import sysparam
@@ -449,7 +446,6 @@
     def as_txt(self):
         txt = u'%s|%s|%s|\n' % (self.txttag, self.element.get('versao'),
                                 self.get_id_value())
-        children = self.get_children()
         for child in self.get_children():
             txt += child.as_txt()
 
@@ -1599,7 +1595,6 @@
 
         address = person.get_main_address()
         if address:
-            postal_code = ''.join([i for i in address.postal_code if i in '1234567890'])
             self.set_attr('xEnder', address.get_address_string()[:60])
             self.set_attr('xMun', address.city_location.city[:60])
             self.set_attr('UF', address.city_location.state)

=== modified file 'plugins/nfe/nfeui.py'
--- plugins/nfe/nfeui.py	2011-10-19 19:44:32 +0000
+++ plugins/nfe/nfeui.py	2011-11-05 17:07:26 +0000
@@ -31,7 +31,6 @@
 from stoqlib.domain.sale import Sale
 from stoqlib.gui.events import StartApplicationEvent
 from stoqlib.lib.osutils import get_application_dir
-from stoqlib.lib.message import info
 from stoqlib.lib.translation import stoqlib_gettext
 
 from nfegenerator import NFeGenerator

=== modified file 'stoq/dbadmin.py'
--- stoq/dbadmin.py	2011-11-01 01:13:11 +0000
+++ stoq/dbadmin.py	2011-11-05 17:07:26 +0000
@@ -192,10 +192,10 @@
             branch = None
 
         try:
-            station = BranchStation(connection=trans,
-                                    is_active=True,
-                                    branch=branch,
-                                    name=socket.gethostname())
+            BranchStation(connection=trans,
+                          is_active=True,
+                          branch=branch,
+                          name=socket.gethostname())
         except StoqlibError, e:
             raise SystemExit("ERROR: %s" % e)
 

=== modified file 'stoq/gui/pos.py'
--- stoq/gui/pos.py	2011-11-01 01:13:11 +0000
+++ stoq/gui/pos.py	2011-11-05 17:07:26 +0000
@@ -511,7 +511,6 @@
         self.set_sensitive([self.advanced_search], has_quantity)
 
     def _read_quantity(self):
-        quantity_text = self.quantity.get_text()
         try:
             quantity = self.quantity.read()
         except ValidationError:

=== modified file 'stoq/gui/receivable.py'
--- stoq/gui/receivable.py	2011-10-24 13:53:17 +0000
+++ stoq/gui/receivable.py	2011-11-05 17:07:26 +0000
@@ -35,7 +35,7 @@
 from kiwi.datatypes import currency
 from kiwi.enums import SearchFilterPosition
 from kiwi.python import all
-from kiwi.ui.search import ComboSearchFilter, DateSearchOption
+from kiwi.ui.search import ComboSearchFilter
 from kiwi.ui.objectlist import SearchColumn, Column
 from stoqlib.database.runtime import new_transaction, finish_transaction
 from stoqlib.domain.payment.operation import register_payment_operations
@@ -64,24 +64,6 @@
 
 _ = gettext.gettext
 
-class NextMonthOption(DateSearchOption):
-    name = _('Next month')
-    def get_interval(self):
-        today = datetime.date.today()
-        year = today.year
-        month = today.month + 1
-        if month > 12:
-            month = 1
-            year += 1
-        # Try 31 first then add one until date() does not complain.
-        day = today.day
-        while True:
-            try:
-                end_date = datetime.date(year, month, day)
-                break
-            except ValueError:
-                day += 1
-        return datetime.date.today(), end_date
 
 class ReceivableApp(SearchableAppWindow):
 

=== modified file 'stoq/gui/stock.py'
--- stoq/gui/stock.py	2011-10-04 16:01:38 +0000
+++ stoq/gui/stock.py	2011-11-05 17:07:26 +0000
@@ -41,7 +41,6 @@
 from stoqlib.domain.sellable import Sellable
 from stoqlib.domain.views import ProductFullStockView
 from stoqlib.lib.defaults import sort_sellable_code
-from stoqlib.lib.message import warning
 from stoqlib.gui.editors.producteditor import ProductStockEditor
 from stoqlib.gui.wizards.loanwizard import NewLoanWizard, CloseLoanWizard
 from stoqlib.gui.wizards.receivingwizard import ReceivingOrderWizard

=== modified file 'stoqlib/chart/chart.py'
--- stoqlib/chart/chart.py	2011-07-01 18:41:05 +0000
+++ stoqlib/chart/chart.py	2011-11-05 17:07:26 +0000
@@ -23,13 +23,13 @@
 ##
 """ Charting """
 
-import datetime
-import gettext
-import string
-
-from kiwi.python import namedAny, Settable
-
-_ = gettext.gettext
+import pprint
+
+from kiwi.python import namedAny
+from stoqlib.lib.translation import stoqlib_gettext
+
+_ = stoqlib_gettext
+
 
 class DateArgument(object):
     pass

=== modified file 'stoqlib/chart/chartserver.py'
--- stoqlib/chart/chartserver.py	2011-07-01 18:41:05 +0000
+++ stoqlib/chart/chartserver.py	2011-11-05 17:07:26 +0000
@@ -26,15 +26,14 @@
 import cgi
 import json
 
-from kiwi.environ import environ
 from twisted.internet import reactor
 from twisted.web.resource import Resource
 from twisted.web.server import Site
 from twisted.web.static import File
 
 from stoqlib.chart.chart import get_chart_class
+from stoqlib.database.runtime import get_connection
 from stoqlib.lib.template import render_template
-
 from stoqlib.lib.translation import stoqlib_gettext
 
 _ = stoqlib_gettext
@@ -53,6 +52,8 @@
 class ChartChartResource(Resource):
 
     def _get_chart(self, request):
+        conn = get_connection()
+
         if not '?' in request.uri:
             raise TypeError("Missing arguments")
         args = cgi.parse_qs(request.uri.split('?', 1)[1])
@@ -70,7 +71,8 @@
         opt['data'] = chart.run()
         opt['options'] = {
             "xaxis": { "mode": "time" },
-            "bars": { "show": True, "barWidth": 20 * _JS_DAY },
+            # XXX: _JS_DAY is not defined
+            #"bars": { "show": True, "barWidth": 20 * _JS_DAY },
             "points": { "show": False },
             "lines": { "show": False },
             "grid": { "hoverable": True,

=== modified file 'stoqlib/chart/paymentcharts.py'
--- stoqlib/chart/paymentcharts.py	2011-07-01 19:35:48 +0000
+++ stoqlib/chart/paymentcharts.py	2011-11-05 17:07:26 +0000
@@ -23,9 +23,11 @@
 ##
 """ Payment charts """
 
+import datetime
 import string
 
 from stoqlib.chart.chart import Chart
+from stoqlib.database.runtime import get_connection
 from stoqlib.lib.translation import stoqlib_gettext
 
 _ = stoqlib_gettext
@@ -164,6 +166,7 @@
     @month: month to show payments for
     @returns: (month, total in payments, total out payments, profit)
     """
+    conn = get_connection()
 
     if 2100 > year < 1900:
         raise ValueError(year)

=== modified file 'stoqlib/database/admin.py'
--- stoqlib/database/admin.py	2011-07-27 15:43:30 +0000
+++ stoqlib/database/admin.py	2011-11-05 17:07:26 +0000
@@ -236,10 +236,10 @@
                  TaxType.NONE,
                  TaxType.SERVICE]:
         desc = describe_constant(enum)
-        constant = SellableTaxConstant(description=desc,
-                                       tax_type=int(enum),
-                                       tax_value=None,
-                                       connection=trans)
+        SellableTaxConstant(description=desc,
+                            tax_type=int(enum),
+                            tax_value=None,
+                            connection=trans)
 
     trans.commit(close=True)
 

=== modified file 'stoqlib/database/database.py'
--- stoqlib/database/database.py	2011-10-26 17:46:38 +0000
+++ stoqlib/database/database.py	2011-11-05 17:07:26 +0000
@@ -38,7 +38,7 @@
 from stoqlib.database.exceptions import SQLError
 from stoqlib.database.interfaces import IDatabaseSettings
 
-from stoqlib.lib.message import error, warning
+from stoqlib.lib.message import warning
 from stoqlib.lib.translation import stoqlib_gettext
 
 _ = stoqlib_gettext
@@ -308,7 +308,7 @@
         log.debug('executing %s' % (' '.join(args), ))
 
         proc = subprocess.Popen(args, stderr=subprocess.PIPE)
-        retcode = proc.wait()
+        proc.wait()
         return newname
     else:
         raise NotImplementedError(settings.rdbms)

=== modified file 'stoqlib/database/migration.py'
--- stoqlib/database/migration.py	2011-11-01 01:13:11 +0000
+++ stoqlib/database/migration.py	2011-11-05 17:07:26 +0000
@@ -38,7 +38,6 @@
 
 from stoqlib.database.database import (execute_sql, dump_database,
                                        restore_database, test_connection)
-from stoqlib.database.exceptions import SQLError
 from stoqlib.database.runtime import new_transaction, get_connection
 from stoqlib.domain.plugin import InstalledPlugin
 from stoqlib.domain.profile import update_profile_applications
@@ -327,7 +326,7 @@
                 super(StoqlibSchemaMigration, self).update()
                 if plugins:
                     self.update_plugins()
-            except Exception, e:
+            except Exception:
                 exc = sys.exc_info()
                 tb_str = ''.join(traceback.format_exception(*exc))
                 collect_traceback(exc, submit=True)

=== modified file 'stoqlib/database/runtime.py'
--- stoqlib/database/runtime.py	2011-10-28 15:04:24 +0000
+++ stoqlib/database/runtime.py	2011-11-05 17:07:26 +0000
@@ -32,7 +32,7 @@
     IDatabaseSettings, IConnection, ITransaction, ICurrentBranch,
     ICurrentBranchStation, ICurrentUser)
 from stoqlib.database.orm import ORMObject, Transaction
-from stoqlib.database.orm import sqlIdentifier, const, Update, IN
+from stoqlib.database.orm import sqlIdentifier, const
 from stoqlib.exceptions import LoginError, StoqlibError
 from stoqlib.lib.message import error, yesno
 from stoqlib.lib.translation import stoqlib_gettext

=== modified file 'stoqlib/database/testsuite.py'
--- stoqlib/database/testsuite.py	2011-07-20 20:33:08 +0000
+++ stoqlib/database/testsuite.py	2011-11-05 17:07:26 +0000
@@ -216,7 +216,7 @@
             initialize_system()
             ensure_admin_user("")
             create(utilities=True)
-    except Exception, e:
+    except Exception:
         # Work around trial
         import traceback
         traceback.print_exc()

=== modified file 'stoqlib/domain/address.py'
--- stoqlib/domain/address.py	2011-09-28 19:55:17 +0000
+++ stoqlib/domain/address.py	2011-11-05 17:07:26 +0000
@@ -25,7 +25,7 @@
 from kiwi.argcheck import argcheck
 from zope.interface import implements
 
-from stoqlib.database.orm import (AND, const, UnicodeCol, IntCol, ForeignKey,
+from stoqlib.database.orm import (AND, UnicodeCol, IntCol, ForeignKey,
                                   BoolCol, ILIKE)
 from stoqlib.database.runtime import StoqlibTransaction
 from stoqlib.domain.base import Domain

=== modified file 'stoqlib/domain/base.py'
--- stoqlib/domain/base.py	2011-10-13 17:51:40 +0000
+++ stoqlib/domain/base.py	2011-11-05 17:07:26 +0000
@@ -26,7 +26,7 @@
 from zope.interface.interface import adapter_hooks
 
 from stoqlib.database.orm import orm_name, ForeignKey, IntCol
-from stoqlib.database.orm import ORMObject, const, AND, const, ILIKE
+from stoqlib.database.orm import ORMObject, const, AND, ILIKE
 from stoqlib.database.runtime import (StoqlibTransaction,
                                       get_current_user, get_current_station)
 from stoqlib.domain.system import TransactionEntry

=== modified file 'stoqlib/domain/devices.py'
--- stoqlib/domain/devices.py	2011-07-15 18:01:20 +0000
+++ stoqlib/domain/devices.py	2011-11-05 17:07:26 +0000
@@ -25,8 +25,6 @@
 Domain classes related to stoqdrivers package.
 """
 
-import platform
-
 from zope.interface import implements
 from stoqdrivers.printers.cheque import ChequePrinter
 from stoqdrivers.scales.scales import Scale

=== modified file 'stoqlib/domain/event.py'
--- stoqlib/domain/event.py	2011-10-29 20:25:07 +0000
+++ stoqlib/domain/event.py	2011-11-05 17:07:26 +0000
@@ -64,9 +64,9 @@
     @classmethod
     def log(cls, event_type, description):
         trans = new_transaction()
-        event = cls(event_type=event_type,
-                    description=description,
-                    connection=trans)
+        cls(event_type=event_type,
+            description=description,
+            connection=trans)
         trans.commit()
 
 

=== modified file 'stoqlib/domain/product.py'
--- stoqlib/domain/product.py	2011-10-27 19:50:12 +0000
+++ stoqlib/domain/product.py	2011-11-05 17:07:26 +0000
@@ -38,8 +38,7 @@
 from stoqlib.domain.events import (ProductCreateEvent, ProductEditEvent,
                                    ProductRemoveEvent, ProductStockUpdateEvent)
 from stoqlib.domain.person import Person
-from stoqlib.domain.interfaces import (IStorable, IContainer,
-                                       IBranch)
+from stoqlib.domain.interfaces import IStorable, IBranch
 from stoqlib.exceptions import StockError, DatabaseInconsistency
 from stoqlib.lib.translation import stoqlib_gettext
 from stoqlib.lib.parameters import sysparam

=== modified file 'stoqlib/domain/test/test_nfe.py'
--- stoqlib/domain/test/test_nfe.py	2011-11-01 01:13:11 +0000
+++ stoqlib/domain/test/test_nfe.py	2011-11-05 17:07:26 +0000
@@ -41,8 +41,7 @@
 
 # This test should be inside plugins/nfe, but it's not reachable there
 sys.path.append('plugins/nfe')
-from nfegenerator import (NFeGenerator, remove_accentuation, nfe_tostring,
-                          NFeIdentification)
+from nfegenerator import NFeGenerator, remove_accentuation, NFeIdentification
 
 
 class TestNfeGenerator(DomainTest):

=== modified file 'stoqlib/domain/test/test_person.py'
--- stoqlib/domain/test/test_person.py	2011-10-28 18:01:18 +0000
+++ stoqlib/domain/test/test_person.py	2011-11-05 17:07:26 +0000
@@ -27,8 +27,6 @@
 
 from kiwi.datatypes import currency
 
-from twisted.trial.unittest import SkipTest
-
 from stoqlib.database.orm import ORMObjectMoreThanOneResultError, AND
 from stoqlib.domain.account import BankAccount
 from stoqlib.domain.person import Calls, Liaison

=== modified file 'stoqlib/domain/test/test_sellable.py'
--- stoqlib/domain/test/test_sellable.py	2011-10-03 16:59:34 +0000
+++ stoqlib/domain/test/test_sellable.py	2011-11-05 17:07:26 +0000
@@ -369,7 +369,7 @@
     def testRemove(self):
         # Remove category price and sellable
         sellable = self.create_sellable()
-        storable = sellable.product.addFacet(IStorable, connection=self.trans)
+        sellable.product.addFacet(IStorable, connection=self.trans)
 
         ClientCategoryPrice(sellable=sellable,
                             category=self.create_client_category(),

=== modified file 'stoqlib/gui/accounttree.py'
--- stoqlib/gui/accounttree.py	2011-08-08 19:18:15 +0000
+++ stoqlib/gui/accounttree.py	2011-11-05 17:07:26 +0000
@@ -22,7 +22,6 @@
 import gtk
 
 from kiwi.currency import currency
-from kiwi.datatypes import converter
 from kiwi.python import Settable
 from kiwi.ui.objectlist import ColoredColumn, Column, ObjectTree
 from stoqlib.database.runtime import get_connection

=== modified file 'stoqlib/gui/base/lists.py'
--- stoqlib/gui/base/lists.py	2011-08-01 13:47:11 +0000
+++ stoqlib/gui/base/lists.py	2011-11-05 17:07:26 +0000
@@ -24,7 +24,6 @@
 """ List management for common dialogs.  """
 
 import gtk
-from kiwi.ui.delegates import GladeSlaveDelegate
 from kiwi.ui.objectlist import ObjectList
 from kiwi.ui.listdialog import ListSlave
 from kiwi.utils import gsignal

=== modified file 'stoqlib/gui/dialogs/branchdialog.py'
--- stoqlib/gui/dialogs/branchdialog.py	2011-07-11 19:31:50 +0000
+++ stoqlib/gui/dialogs/branchdialog.py	2011-11-05 17:07:26 +0000
@@ -65,10 +65,6 @@
         BaseEditor.__init__(self, trans, model, visual_mode=False)
         self._setup_widgets()
 
-    def _setup_widgets(self):
-        self.title_label.set_size('large')
-        self.title_label.set_bold(True)
-
     def _update_system_parameters(self, person):
         icms = self.tax_proxy.model.icms
         self.param.update_parameter('ICMS_TAX', unicode(icms))

=== modified file 'stoqlib/gui/dialogs/chartdialog.py'
--- stoqlib/gui/dialogs/chartdialog.py	2011-07-01 18:41:05 +0000
+++ stoqlib/gui/dialogs/chartdialog.py	2011-11-05 17:07:26 +0000
@@ -26,6 +26,8 @@
 import gtk
 import webkit
 
+from twisted.internet import reactor
+
 class ChartDialog(gtk.Window):
     def __init__(self):
         gtk.Window.__init__(self)

=== modified file 'stoqlib/gui/dialogs/productiondialog.py'
--- stoqlib/gui/dialogs/productiondialog.py	2011-10-28 17:21:28 +0000
+++ stoqlib/gui/dialogs/productiondialog.py	2011-11-05 17:07:26 +0000
@@ -24,7 +24,6 @@
 ##
 
 from decimal import Decimal
-from sys import maxint as MAXINT
 
 import gtk
 from gtk import gdk
@@ -232,7 +231,6 @@
         self.remove_product_button.set_sensitive(can_remove)
 
     def _get_columns(self):
-        adj = gtk.Adjustment(upper=MAXINT, step_incr=1)
         return [Column('code', title=_(u'Code'), data_type=int),
                 Column('category', title=_(u'Category'), data_type=str,
                         expand=True, sorted=True),
@@ -312,7 +310,6 @@
         self.export_csv_button.set_sensitive(self.has_rows)
 
     def _get_columns(self):
-        adj = gtk.Adjustment(upper=MAXINT, step_incr=1)
         return [Column('industrialized_str', title=_(u'Ind.'), data_type=str),
                 Column('code', title=_(u'code'), data_type=str),
                 Column('category', title=_(u'Category'), data_type=str,

=== modified file 'stoqlib/gui/dialogs/productionquotedialog.py'
--- stoqlib/gui/dialogs/productionquotedialog.py	2011-02-08 14:21:07 +0000
+++ stoqlib/gui/dialogs/productionquotedialog.py	2011-11-05 17:07:26 +0000
@@ -57,7 +57,6 @@
         order = self._create_purchase_order(trans)
         to_quote_items = {}
         for production in productions:
-            materials = production.get_material_items()
             for material in production.get_material_items():
                 if material.to_purchase <= 0:
                     continue

=== modified file 'stoqlib/gui/dialogs/purchasedetails.py'
--- stoqlib/gui/dialogs/purchasedetails.py	2011-07-12 19:35:02 +0000
+++ stoqlib/gui/dialogs/purchasedetails.py	2011-11-05 17:07:26 +0000
@@ -76,7 +76,6 @@
 
         if orders.count():
             discount = surcharge = freight = subtotal = total = 0
-            freight_type = None
             for order in orders:
                 discount += order._get_total_discounts()
                 surcharge += order._get_total_surcharges()

=== modified file 'stoqlib/gui/editors/accounttransactioneditor.py'
--- stoqlib/gui/editors/accounttransactioneditor.py	2011-08-10 18:24:18 +0000
+++ stoqlib/gui/editors/accounttransactioneditor.py	2011-11-05 17:07:26 +0000
@@ -24,7 +24,6 @@
 
 import datetime
 
-import gobject
 import gtk
 from kiwi.currency import currency
 from kiwi.datatypes import ValidationError

=== modified file 'stoqlib/gui/editors/personeditor.py'
--- stoqlib/gui/editors/personeditor.py	2011-08-04 19:49:44 +0000
+++ stoqlib/gui/editors/personeditor.py	2011-11-05 17:07:26 +0000
@@ -44,7 +44,7 @@
 from stoqlib.domain.person import EmployeeRole, PersonAdaptToCreditProvider
 from stoqlib.domain.interfaces import (IClient, ICreditProvider, IEmployee,
                                        ISupplier, ITransporter, IUser,
-                                       ICompany, IIndividual, IBranch)
+                                       IIndividual, IBranch)
 
 _ = stoqlib_gettext
 

=== modified file 'stoqlib/gui/editors/profileeditor.py'
--- stoqlib/gui/editors/profileeditor.py	2011-09-28 19:55:17 +0000
+++ stoqlib/gui/editors/profileeditor.py	2011-11-05 17:07:26 +0000
@@ -28,8 +28,6 @@
 from kiwi.datatypes import ValidationError
 from kiwi.ui.widgets.checkbutton import ProxyCheckButton
 
-from stoqlib.database.orm import const, AND
-from stoqlib.database.runtime import get_connection
 from stoqlib.domain.profile import UserProfile, ProfileSettings
 from stoqlib.gui.editors.baseeditor import BaseEditor
 from stoqlib.lib.interfaces import IApplicationDescriptions

=== modified file 'stoqlib/gui/editors/sellableeditor.py'
--- stoqlib/gui/editors/sellableeditor.py	2011-10-03 16:59:34 +0000
+++ stoqlib/gui/editors/sellableeditor.py	2011-11-05 17:07:26 +0000
@@ -410,7 +410,6 @@
     def _update_tax_value(self):
         if not hasattr(self, 'tax_proxy'):
             return
-        constant = self.tax_constant.get_selected_data()
         self.tax_proxy.update('tax_constant.tax_value')
 
     def get_taxes(self):

=== modified file 'stoqlib/gui/editors/tilleditor.py'
--- stoqlib/gui/editors/tilleditor.py	2011-10-05 17:33:34 +0000
+++ stoqlib/gui/editors/tilleditor.py	2011-11-05 17:07:26 +0000
@@ -29,12 +29,12 @@
 from kiwi.python import Settable
 from kiwi.ui.objectlist import Column, ColoredColumn, SummaryLabel
 
-from stoqdrivers.exceptions import CouponOpenError, DriverError
+from stoqdrivers.exceptions import DriverError
 
 from stoqlib.database.orm import const
 from stoqlib.database.runtime import (get_current_station, new_transaction,
                                       finish_transaction)
-from stoqlib.domain.account import Account, AccountTransaction
+from stoqlib.domain.account import AccountTransaction
 from stoqlib.domain.events import (TillOpenEvent, TillCloseEvent,
                                    TillAddTillEntryEvent,
                                    TillAddCashEvent, TillRemoveCashEvent)
@@ -50,7 +50,6 @@
 _ = stoqlib_gettext
 
 def _create_transaction(conn, till_entry):
-    till = till_entry.till
     AccountTransaction(description=till_entry.description,
                        source_account=sysparam(conn).IMBALANCE_ACCOUNT,
                        account=sysparam(conn).TILLS_ACCOUNT,

=== modified file 'stoqlib/gui/fiscalprinter.py'
--- stoqlib/gui/fiscalprinter.py	2011-11-01 01:13:11 +0000
+++ stoqlib/gui/fiscalprinter.py	2011-11-05 17:07:26 +0000
@@ -54,8 +54,6 @@
 from stoqlib.lib.translation import stoqlib_gettext
 from stoqlib.gui.wizards.salewizard import ConfirmSaleWizard
 
-from stoqlib.domain.devices import FiscalDayHistory, FiscalDayTax
-
 
 _ = stoqlib_gettext
 
@@ -212,7 +210,7 @@
 
         try:
             CouponCreatedEvent.emit(coupon)
-        except (DriverError, DeviceError), e:
+        except (DriverError, DeviceError):
             warning('Não foi possível abrir o cupom')
             coupon = None
 

=== modified file 'stoqlib/gui/printing.py'
--- stoqlib/gui/printing.py	2011-10-03 14:12:38 +0000
+++ stoqlib/gui/printing.py	2011-11-05 17:07:26 +0000
@@ -207,30 +207,6 @@
     kwargs['filter_strings'] = filter_strings
     return kwargs
 
-
-def print_report(report_class, *args, **kwargs):
-    if kwargs.has_key('filters') and kwargs['filters']:
-        kwargs = describe_search_filters_for_reports(**kwargs)
-
-    tmp = tempfile.mktemp(suffix='.pdf', prefix='stoqlib-reporting')
-    report = report_class(tmp, *args, **kwargs)
-    report.filename = tmp
-    report.save()
-    op = PrintOperation()
-    op.print_pdf(report)
-
-def describe_search_filters_for_reports(**kwargs):
-    filters = kwargs.pop('filters')
-    filter_strings = []
-    for filter in filters:
-        description = filter.get_description()
-        if description:
-            filter_strings.append(description)
-
-    kwargs['filter_strings'] = filter_strings
-    return kwargs
-
-
 def print_report(report_class, *args, **kwargs):
     if kwargs.has_key('filters') and kwargs['filters']:
         kwargs = describe_search_filters_for_reports(**kwargs)

=== modified file 'stoqlib/gui/search/eventsearch.py'
--- stoqlib/gui/search/eventsearch.py	2011-10-29 20:25:07 +0000
+++ stoqlib/gui/search/eventsearch.py	2011-11-05 17:07:26 +0000
@@ -24,8 +24,6 @@
 ##
 """ Implementation of event search """
 
-import datetime
-
 from kiwi.ui.objectlist import Column
 
 from stoqlib.gui.base.search import SearchEditor

=== modified file 'stoqlib/gui/search/fiscalsearch.py'
--- stoqlib/gui/search/fiscalsearch.py	2011-07-14 17:15:00 +0000
+++ stoqlib/gui/search/fiscalsearch.py	2011-11-05 17:07:26 +0000
@@ -83,11 +83,9 @@
     searchbar_result_strings = _("fiscal entry"), _("fiscal entries")
 
     def _setup_columns(self, column, table, col_name, summary_label_text):
-        label_text = '<b>%s</b>' % summary_label_text
         columns = self.get_columns() + [column]
         self.results.set_columns(columns)
         self.set_table(table)
-        #self.setup_summary_label(col_name, label_text)
 
     def _setup_icms_columns(self):
         col = SearchColumn('icms_value',

=== modified file 'stoqlib/gui/slaves/employeeslave.py'
--- stoqlib/gui/slaves/employeeslave.py	2011-02-08 14:06:58 +0000
+++ stoqlib/gui/slaves/employeeslave.py	2011-11-05 17:07:26 +0000
@@ -207,11 +207,8 @@
 
     def _update_sensitivity(self):
         editor = True
-        settings = False
         if self.role.get_text():
             editor = self.role.is_valid()
-            if editor:
-                settings = self._is_default_salesperson_role()
         else:
             self.model.role = None
         self.role_editor_button.set_sensitive(editor)

=== modified file 'stoqlib/gui/slaves/paymentmethodslave.py'
--- stoqlib/gui/slaves/paymentmethodslave.py	2011-08-05 16:54:09 +0000
+++ stoqlib/gui/slaves/paymentmethodslave.py	2011-11-05 17:07:26 +0000
@@ -28,10 +28,8 @@
 from kiwi.ui.delegates import GladeSlaveDelegate
 from kiwi.utils import gsignal
 
-from stoqlib.database.runtime import get_connection
 from stoqlib.domain.payment.views import PaymentMethodView
 from stoqlib.exceptions import StoqlibError
-from stoqlib.lib.message import marker
 from stoqlib.lib.translation import stoqlib_gettext
 
 N_ = _ = stoqlib_gettext

=== modified file 'stoqlib/gui/slaves/userslave.py'
--- stoqlib/gui/slaves/userslave.py	2011-09-28 19:55:17 +0000
+++ stoqlib/gui/slaves/userslave.py	2011-11-05 17:07:26 +0000
@@ -29,10 +29,9 @@
 import gtk
 from kiwi.datatypes import ValidationError
 
-from stoqlib.database.orm import const
 from stoqlib.database.runtime import get_current_user
 from stoqlib.domain.profile import UserProfile
-from stoqlib.domain.person import EmployeeRole, Person
+from stoqlib.domain.person import EmployeeRole
 from stoqlib.domain.interfaces import IEmployee, ISalesPerson, IUser
 from stoqlib.gui.editors.baseeditor import BaseEditor, BaseEditorSlave
 from stoqlib.gui.base.dialogs import run_dialog

=== modified file 'stoqlib/gui/splash.py'
--- stoqlib/gui/splash.py	2011-06-29 20:21:26 +0000
+++ stoqlib/gui/splash.py	2011-11-05 17:07:26 +0000
@@ -27,7 +27,6 @@
 import time
 
 import gobject
-import cairo
 import gtk
 import pango
 import pangocairo

=== modified file 'stoqlib/gui/templates/individualtemplate.py'
--- stoqlib/gui/templates/individualtemplate.py	2011-06-21 13:31:33 +0000
+++ stoqlib/gui/templates/individualtemplate.py	2011-11-05 17:07:26 +0000
@@ -140,7 +140,6 @@
         self.birth_state.prefill(get_country_states())
 
     def _update_marital_status(self):
-        marital_status = self.marital_status.get_selected_data()
         if self.model.is_married():
             self.spouse_lbl.show()
             self.spouse_name.show()

=== modified file 'stoqlib/gui/wizards/purchasewizard.py'
--- stoqlib/gui/wizards/purchasewizard.py	2011-11-04 12:06:43 +0000
+++ stoqlib/gui/wizards/purchasewizard.py	2011-11-05 17:07:26 +0000
@@ -25,7 +25,6 @@
 """ Purchase wizard definition """
 
 import datetime
-from decimal import Decimal
 import sys
 
 import gtk
@@ -38,7 +37,7 @@
 from stoqlib.domain.interfaces import IBranch, ITransporter, ISupplier
 from stoqlib.domain.payment.group import PaymentGroup
 from stoqlib.domain.payment.operation import register_payment_operations
-from stoqlib.domain.person import Person, PersonAdaptToTransporter
+from stoqlib.domain.person import Person
 from stoqlib.domain.product import ProductSupplierInfo
 from stoqlib.domain.purchase import PurchaseOrder, PurchaseItem
 from stoqlib.domain.receiving import (ReceivingOrder, ReceivingOrderItem,

=== modified file 'stoqlib/importers/branchimporter.py'
--- stoqlib/importers/branchimporter.py	2011-02-08 14:06:58 +0000
+++ stoqlib/importers/branchimporter.py	2011-11-05 17:07:26 +0000
@@ -62,13 +62,16 @@
                                            state=data.state,
                                            country=data.country)
         streetnumber = data.streetnumber and int(data.streetnumber) or None
-        address = Address(is_main_address=True,
-                          person=person, city_location=ctloc,
-                          connection=trans,
-                          street=data.street,
-                          streetnumber=streetnumber,
-                          district=data.district,
-                          postal_code=data.postal_code)
+        Address(
+            is_main_address=True,
+            person=person,
+            city_location=ctloc,
+            connection=trans,
+            street=data.street,
+            streetnumber=streetnumber,
+            district=data.district,
+            postal_code=data.postal_code
+            )
 
         person.addFacet(IBranch, connection=trans)
 

=== modified file 'stoqlib/importers/clientimporter.py'
--- stoqlib/importers/clientimporter.py	2011-02-08 14:06:58 +0000
+++ stoqlib/importers/clientimporter.py	2011-11-05 17:07:26 +0000
@@ -59,11 +59,14 @@
                                            state=data.state,
                                            country=data.country)
         streetnumber = data.streetnumber and int(data.streetnumber) or None
-        address = Address(is_main_address=True,
-                          person=person, city_location=ctloc,
-                          connection=trans,
-                          street=data.street,
-                          streetnumber=streetnumber,
-                          district=data.district)
+        Address(
+            is_main_address=True,
+            person=person,
+            city_location=ctloc,
+            connection=trans,
+            street=data.street,
+            streetnumber=streetnumber,
+            district=data.district
+            )
 
         person.addFacet(IClient, connection=trans)

=== modified file 'stoqlib/importers/creditproviderimporter.py'
--- stoqlib/importers/creditproviderimporter.py	2011-02-08 14:06:58 +0000
+++ stoqlib/importers/creditproviderimporter.py	2011-11-05 17:07:26 +0000
@@ -64,12 +64,13 @@
                                            state=data.state,
                                            country=data.country)
         streetnumber = data.streetnumber and int(data.streetnumber) or None
-        address = Address(is_main_address=True,
-                          person=person, city_location=ctloc,
-                          connection=trans,
-                          street=data.street,
-                          streetnumber=streetnumber,
-                          district=data.district)
+        Address(is_main_address=True,
+                person=person,
+                city_location=ctloc,
+                connection=trans,
+                street=data.street,
+                streetnumber=streetnumber,
+                district=data.district)
 
         person.addFacet(ICreditProvider, connection=trans,
                         open_contract_date=const.NOW(),

=== modified file 'stoqlib/importers/csvimporter.py'
--- stoqlib/importers/csvimporter.py	2011-07-15 19:57:51 +0000
+++ stoqlib/importers/csvimporter.py	2011-11-05 17:07:26 +0000
@@ -73,9 +73,6 @@
     #
 
     def feed(self, fp, filename='<stdin>'):
-        field_names = self.fields + self.optional_fields
-
-        t = time.time()
         trans = new_transaction()
         self.before_start(trans)
         trans.commit(close=True)
@@ -86,6 +83,7 @@
         return len(self.rows)
 
     def process_item(self, trans, item_no):
+        t = time.time()
         item = self.rows[item_no]
         if not item or item[0].startswith('%'):
             self.lineno += 1
@@ -106,7 +104,7 @@
         row = CSVRow(item, field_names)
         try:
             self.process_one(row, row.fields, trans)
-        except Exception, e:
+        except Exception:
             print
             print 'Error while processing row %d %r' % (self.lineno, row,)
             print

=== modified file 'stoqlib/importers/employeeimporter.py'
--- stoqlib/importers/employeeimporter.py	2011-02-08 14:06:58 +0000
+++ stoqlib/importers/employeeimporter.py	2011-11-05 17:07:26 +0000
@@ -72,7 +72,7 @@
                                    registry_number=data.employee_number)
 
         start = self.parse_date(data.start)
-        role_history = EmployeeRoleHistory(
+        EmployeeRoleHistory(
             connection=trans, role=role,
             employee=employee,
             is_active=True,
@@ -84,12 +84,13 @@
                                            state=data.state,
                                            country=data.country)
         streetnumber = data.streetnumber and int(data.streetnumber) or None
-        address = Address(is_main_address=True,
-                          person=person, city_location=ctloc,
-                          connection=trans,
-                          street=data.street,
-                          streetnumber=streetnumber,
-                          district=data.district)
+        Address(is_main_address=True,
+                person=person,
+                city_location=ctloc,
+                connection=trans,
+                street=data.street,
+                streetnumber=streetnumber,
+                district=data.district)
 
         profile = UserProfile.selectOneBy(name=data.profile, connection=trans)
 

=== modified file 'stoqlib/importers/ofximporter.py'
--- stoqlib/importers/ofximporter.py	2011-07-19 19:18:46 +0000
+++ stoqlib/importers/ofximporter.py	2011-11-05 17:07:26 +0000
@@ -201,7 +201,6 @@
                                value=value,
                                date=date,
                                connection=trans)
-        last_date = date
         t.sync()
         return True
 

=== modified file 'stoqlib/importers/purchaseimporter.py'
--- stoqlib/importers/purchaseimporter.py	2011-02-08 14:21:07 +0000
+++ stoqlib/importers/purchaseimporter.py	2011-11-05 17:07:26 +0000
@@ -102,10 +102,12 @@
                                          connection=trans)
 
         for purchase_item in purchase.get_items():
-            receicing_item = ReceivingOrderItem(connection=trans,
-                                                cost=purchase_item.sellable.cost,
-                                                sellable=purchase_item.sellable,
-                                                quantity=int(data.quantity),
-                                                purchase_item=purchase_item,
-                                                receiving_order=receiving_order)
+            ReceivingOrderItem(
+                connection=trans,
+                cost=purchase_item.sellable.cost,
+                sellable=purchase_item.sellable,
+                quantity=int(data.quantity),
+                purchase_item=purchase_item,
+                receiving_order=receiving_order
+                )
         receiving_order.confirm()

=== modified file 'stoqlib/importers/serviceimporter.py'
--- stoqlib/importers/serviceimporter.py	2011-06-21 13:31:33 +0000
+++ stoqlib/importers/serviceimporter.py	2011-11-05 17:07:26 +0000
@@ -57,5 +57,5 @@
                             cost=int(data.cost),
                             code=data.barcode,
                             barcode=data.barcode)
-        service = Service(sellable=sellable,
-                          connection=trans)
+        Service(sellable=sellable,
+                connection=trans)

=== modified file 'stoqlib/importers/supplierimporter.py'
--- stoqlib/importers/supplierimporter.py	2011-02-08 14:06:58 +0000
+++ stoqlib/importers/supplierimporter.py	2011-11-05 17:07:26 +0000
@@ -61,12 +61,15 @@
                                            state=data.state,
                                            country=data.country)
         streetnumber = data.streetnumber and int(data.streetnumber) or None
-        address = Address(is_main_address=True,
-                          person=person, city_location=ctloc,
-                          connection=trans,
-                          street=data.street,
-                          streetnumber=streetnumber,
-                          district=data.district)
+        Address(
+            is_main_address=True,
+            person=person,
+            city_location=ctloc,
+            connection=trans,
+            street=data.street,
+            streetnumber=streetnumber,
+            district=data.district
+            )
 
         person.addFacet(ISupplier, connection=trans)
 

=== modified file 'stoqlib/importers/transporterimporter.py'
--- stoqlib/importers/transporterimporter.py	2011-06-21 13:31:33 +0000
+++ stoqlib/importers/transporterimporter.py	2011-11-05 17:07:26 +0000
@@ -62,12 +62,15 @@
                                            state=data.state,
                                            country=data.country)
         streetnumber = data.streetnumber and int(data.streetnumber) or None
-        address = Address(is_main_address=True,
-                          person=person, city_location=ctloc,
-                          connection=trans,
-                          street=data.street,
-                          streetnumber=streetnumber,
-                          district=data.district)
+        Address(
+            is_main_address=True,
+            person=person,
+            city_location=ctloc,
+            connection=trans,
+            street=data.street,
+            streetnumber=streetnumber,
+            district=data.district
+            )
 
         dict(open_contract_date=self.parse_date(data.open_contract),
              freight_percentage=data.freight_percentage),

=== modified file 'stoqlib/lib/devicemanager.py'
--- stoqlib/lib/devicemanager.py	2011-04-18 21:23:31 +0000
+++ stoqlib/lib/devicemanager.py	2011-11-05 17:07:26 +0000
@@ -30,6 +30,7 @@
 
 try:
     import gudev
+    gudev # pyflakes
 except ImportError:
     gudev = None
 

=== modified file 'stoqlib/lib/imageutils.py'
--- stoqlib/lib/imageutils.py	2011-09-12 20:14:28 +0000
+++ stoqlib/lib/imageutils.py	2011-11-05 17:07:26 +0000
@@ -31,8 +31,6 @@
 import gtk
 import gobject
 
-from kiwi.environ import environ
-
 
 class ImageHelper(object):
 

=== modified file 'stoqlib/lib/test/test_ofximporter.py'
--- stoqlib/lib/test/test_ofximporter.py	2011-06-17 17:11:48 +0000
+++ stoqlib/lib/test/test_ofximporter.py	2011-11-05 17:07:26 +0000
@@ -24,11 +24,9 @@
 from decimal import Decimal
 import operator
 
-from stoqlib.database.runtime import new_transaction
 from stoqlib.domain.account import Account
 from stoqlib.domain.test.domaintest import DomainTest
 from stoqlib.importers.ofximporter import OFXImporter
-from stoqlib.lib.parameters import sysparam
 
 
 OFX_DATA = """OFXHEADER:100
@@ -218,7 +216,6 @@
         ofx.feed(StringIO(OFX_DATA))
         ofx.set_dry(True)
         ofx.process(self.trans)
-        imbalance_account = sysparam(self.trans).IMBALANCE_ACCOUNT
         account = Account.select(connection=self.trans).orderBy('id')[-1]
         self.failUnless(account)
         self.assertEquals(account.description, "Bank - CHECKING")
@@ -236,7 +233,6 @@
         ofx.feed(StringIO(OFX_DATA2))
         ofx.set_dry(True)
         ofx.process(self.trans)
-        imbalance_account = sysparam(self.trans).IMBALANCE_ACCOUNT
         account = Account.select(connection=self.trans).orderBy('id')[-1]
         self.failUnless(account)
         self.assertEquals(account.description, "Banco do Brasil - CHECKING")
@@ -254,8 +250,6 @@
         ofx.feed(StringIO(OFX_DATA3))
         ofx.set_dry(True)
         ofx.process(self.trans)
-        imbalance_account = sysparam(self.trans).IMBALANCE_ACCOUNT
-        trans = new_transaction()
         account = Account.select(connection=self.trans).orderBy('id')[-1]
         self.failUnless(account)
         self.assertEquals(account.description, "SANTANDER - CHECKING")

=== modified file 'stoqlib/lib/test/test_parameters.py'
--- stoqlib/lib/test/test_parameters.py	2011-06-17 20:40:14 +0000
+++ stoqlib/lib/test/test_parameters.py	2011-11-05 17:07:26 +0000
@@ -46,11 +46,11 @@
         person = Person(name='Jonas', connection=self.trans)
         person.addFacet(IIndividual, connection=self.trans)
         role = EmployeeRole(connection=self.trans, name='desenvolvedor')
-        employee = person.addFacet(IEmployee, connection=self.trans,
-                                   role=role)
+        person.addFacet(IEmployee, connection=self.trans,
+                        role=role)
         self.salesperson = person.addFacet(ISalesPerson,
                                            connection=self.trans)
-        company = person.addFacet(ICompany, connection=self.trans)
+        person.addFacet(ICompany, connection=self.trans)
         client = person.addFacet(IClient, connection=self.trans)
         self.branch = person.addFacet(IBranch, connection=self.trans)
 
@@ -100,7 +100,6 @@
 
     def testUseLogicQuantity(self):
         storable = self.create_storable()
-        param = self.sparam.USE_LOGIC_QUANTITY
         self.assertEqual(storable._check_logic_quantity(), None)
         self.sparam.update_parameter(parameter_name='USE_LOGIC_QUANTITY',
                                      value=u'0')

=== modified file 'stoqlib/lib/test/test_sintegra.py'
--- stoqlib/lib/test/test_sintegra.py	2008-10-01 16:11:05 +0000
+++ stoqlib/lib/test/test_sintegra.py	2011-11-05 17:07:26 +0000
@@ -20,7 +20,6 @@
 ## Foundation, Inc., or visit: http://www.gnu.org/.
 ##
 
-from cStringIO import StringIO
 import datetime
 from decimal import Decimal
 import os
@@ -40,7 +39,6 @@
     expected = basename + '-expected.txt'
     output = basename + '-output.txt'
 
-    fp = StringIO()
     sfile.write(output)
     expected = os.path.join(test.__path__[0], expected)
     retval = diff_files(expected, output)

=== modified file 'stoqlib/lib/test/test_sintegragenerator.py'
--- stoqlib/lib/test/test_sintegragenerator.py	2011-02-08 14:21:07 +0000
+++ stoqlib/lib/test/test_sintegragenerator.py	2011-11-05 17:07:26 +0000
@@ -77,8 +77,8 @@
         sale.order()
 
         method = PaymentMethod.get_by_name(self.trans, 'money')
-        payment = method.create_inpayment(sale.group,
-                                          sale.get_sale_subtotal())
+        method.create_inpayment(sale.group,
+                                sale.get_sale_subtotal())
 
         sale.confirm()
         sale.set_paid()

=== modified file 'stoqlib/lib/xmlrpc.py'
--- stoqlib/lib/xmlrpc.py	2011-09-12 18:10:48 +0000
+++ stoqlib/lib/xmlrpc.py	2011-11-05 17:07:26 +0000
@@ -62,7 +62,7 @@
             try:
                 exc = namedAny(exc_name)
                 raise exc(msg)
-            except Exception, unused:
+            except Exception:
                 # In case server/client side is out of sync
                 raise Exception(msg)
 

=== modified file 'stoqlib/reporting/product.py'
--- stoqlib/reporting/product.py	2011-07-11 17:33:47 +0000
+++ stoqlib/reporting/product.py	2011-11-05 17:07:26 +0000
@@ -26,7 +26,6 @@
 
 from decimal import Decimal
 
-from stoqlib.database.runtime import get_connection, get_current_branch
 from stoqlib.reporting.template import (SearchResultsReport, PriceReport,
                                         ObjectListReport)
 from stoqlib.reporting.base.tables import ObjectTableColumn as OTC

=== modified file 'stoqlib/reporting/purchase.py'
--- stoqlib/reporting/purchase.py	2011-10-17 19:36:32 +0000
+++ stoqlib/reporting/purchase.py	2011-11-05 17:07:26 +0000
@@ -277,7 +277,6 @@
                               table_line=TABLE_LINE_BLANK, width=730)
 
     def _setup_items_table(self):
-        items = self._order.get_items()
         # XXX: Stoqlib Reporting try to apply len() on the table data, but
         # Purchase's get_items returns a SelectResult instance (ORMObject)
         # that not supports the len operator.

=== modified file 'stoqlib/reporting/sale.py'
--- stoqlib/reporting/sale.py	2011-07-26 13:53:02 +0000
+++ stoqlib/reporting/sale.py	2011-11-05 17:07:26 +0000
@@ -324,8 +324,6 @@
             if total_amount:
                 va = total_amount/sales_qty
             text = _("Sold value per sales %s") % (get_formatted_price(va,))
-            total_sellables = sum([item.sale.get_items_total_quantity()
-                for item in self.salesperson_list])
 
         self.add_object_table(self.salesperson_list, self._get_columns(),
                               summary_row=summary_row)

=== modified file 'stoqlib/reporting/template.py'
--- stoqlib/reporting/template.py	2011-07-11 17:33:47 +0000
+++ stoqlib/reporting/template.py	2011-11-05 17:07:26 +0000
@@ -379,7 +379,6 @@
         """
         conn = get_connection()
         branch = get_current_branch(conn)
-        branch_address = branch.person.address
         logo = _get_logotype_path(conn)
 
         ns['title'] = self.title

=== modified file 'stoqlib/reporting/tests/test_reporting.py'
--- stoqlib/reporting/tests/test_reporting.py	2011-11-05 16:46:12 +0000
+++ stoqlib/reporting/tests/test_reporting.py	2011-11-05 17:07:26 +0000
@@ -271,18 +271,18 @@
         storable = product.addFacet(IStorable, connection=self.trans)
         storable.increase_stock(100, get_current_branch(self.trans))
 
-        source = CommissionSource(sellable=sellable,
-                                  direct_value=Decimal(10),
-                                  installments_value=1,
-                                  connection=self.trans)
+        CommissionSource(sellable=sellable,
+                         direct_value=Decimal(10),
+                         installments_value=1,
+                         connection=self.trans)
 
         sale.order()
 
         method = PaymentMethod.get_by_name(self.trans, 'money')
         till = Till.get_last_opened(self.trans)
-        payment = method.create_inpayment(sale.group,
-                                          sale.get_sale_subtotal(),
-                                          till=till)
+        method.create_inpayment(sale.group,
+                                sale.get_sale_subtotal(),
+                                till=till)
         sale.confirm()
         sale.set_paid()
 

=== added file 'stoqlib/test/test_pyflakes.py'
--- stoqlib/test/test_pyflakes.py	1970-01-01 00:00:00 +0000
+++ stoqlib/test/test_pyflakes.py	2011-11-05 17:07:26 +0000
@@ -0,0 +1,68 @@
+# -*- coding: utf-8 -*-
+# vi:si:et:sw=4:sts=4:ts=4
+
+##
+## Copyright (C) 2011 Async Open Source <http://www.async.com.br>
+## All rights reserved
+##
+## This program is free software; you can redistribute it and/or modify
+## it under the terms of the GNU General Public License as published by
+## the Free Software Foundation; either version 2 of the License, or
+## (at your option) any later version.
+##
+## This program is distributed in the hope that it will be useful,
+## but WITHOUT ANY WARRANTY; without even the implied warranty of
+## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+## GNU General Public License for more details.
+##
+## You should have received a copy of the GNU General Public License
+## along with this program; if not, write to the Free Software
+## Foundation, Inc., or visit: http://www.gnu.org/.
+##
+## Author(s): Stoq Team <[e-mail]>
+##
+"""Test pyflakes on stoq, stoqlib and plugins directories
+
+Useful to early find syntax errors and other common problems.
+"""
+
+import sys
+import os.path
+
+from twisted.trial import unittest
+try:
+    from pyflakes.scripts import pyflakes
+    pyflakes # pyflakes (ironique ah?)
+except ImportError:
+    pyflakes = None
+
+
+class TestPyflakes(unittest.TestCase):
+
+    def __init__(self, *args, **kwargs):
+        super(TestPyflakes, self).__init__(*args, **kwargs)
+
+    def _test_path(self, path_name):
+        # Skip test if user doesn't have pyflakes installed.
+        if not pyflakes:
+            raise unittest.SkipTest("Pyflakes not installed")
+
+        test_path = None
+        for path in sys.path:
+            if path.endswith('stoq'):
+                test_path = path
+                break
+        self.assertTrue(test_path)
+
+        path = os.path.join(test_path, path_name)
+        retval = pyflakes.main([path])
+        self.assertEqual(retval, 0)
+
+
+for subpath in ('stoq', 'stoqlib', 'plugins'):
+    # subpath has to be passed as a kw, or it will always be plugins (the
+    # last subpath variable on for).
+    func = lambda self, subpath=subpath: self._test_path(subpath)
+    name = 'test_%s_pyflakes' % (subpath,)
+    func.__name__ = name
+    setattr(TestPyflakes, name, func)