Merge lp:~bellini666/charms/trusty/wordpress/mod_rewrite into lp:charms/trusty/wordpress

[Thiago Bellini]

[Review Queue (review-queue)]

This items has failed automated testing! Results available here http://reports.vapour.ws/charm-tests/charm-bundle-test-10705-results

review: Needs Fixing (automated testing)

[Thiago Bellini (bellini666)]

I didn't understand the test results... they passed on some providers but not on some others... The reason they didn't pass, was that my fault?

[José Antonio Rey (jose)]

Hey Thiago,

That's why we manually run these tests ourselves. Expect a review soon, since this is already in the queue.

[Tim Van Steenburgh (tvansteenburgh)]

Thiago,

Can you please explain how to test this change? Thanks!

review: Needs Information

[Review Queue (review-queue)]

This items has failed automated testing! Results available here http://reports.vapour.ws/charm-tests/charm-bundle-test-10929-results

review: Needs Fixing (automated testing)

[Thiago Bellini (bellini666)]

@tvansteenburgh: Set your wordpress permalinks to post name for example, and where you would access it by www.wordpress_example.com/index.php/post-name, you should be able to access it with www.wordpress_example.com/post-name directly (without the index.php)

[Adam Israel (aisrael)]

Hi Thiago,

I had the opportunity to review this merge proposal today, using the description of the problem you provided above. I was able to recreate the error in trunk, and verify that this merge successfully fixes the problem.

Thanks for your work on this!

LGTM. +1

review: Approve

[Charles Butler (lazypower)]

I've promoted this branch after validating aisrael's findings. +1 LGTM - pushed to the store.

review: Approve

=== modified file 'files/charm/nginx/etc_nginx_sites-enabled_wordpress'
--- files/charm/nginx/etc_nginx_sites-enabled_wordpress	2012-08-24 20:59:04 +0000
+++ files/charm/nginx/etc_nginx_sites-enabled_wordpress	2014-12-12 14:46:52 +0000
@@ -30,7 +30,8 @@
   }
 
   location / {
-    try_files $uri $uri/ @memcache;
+    index index.php index.html index.htm;
+    try_files $uri $uri/ @memcache /index.php?$args;
   }
 
   location ~ /\. {