Code review comment for lp:~bcsaller/pyjuju/lxc-repairs

Revision history for this message
Benjamin Saller (bcsaller) wrote :

Changes made, test add, merging.

https://codereview.appspot.com/6404052/diff/2001/juju/lib/tests/test_service.py
File juju/lib/tests/test_service.py (right):

https://codereview.appspot.com/6404052/diff/2001/juju/lib/tests/test_service.py#newcode45
juju/lib/tests/test_service.py:45:
On 2012/07/26 13:03:13, hazmat wrote:
> there should also be a real tests here, twistd has several builtin
services.
Added test using twistd to spawn a webserver, some of the arg handling
of twistd is more specific than the manager expected, this was corrected
in the code, the result is more flexible.

https://codereview.appspot.com/6404052/

« Back to merge proposal