> as discussed in irc, this branch has three other features in addition to the
> bug fix which should be in another branch. The tmp folder guards are
> irrelevant given the branches focus. The ephemeral stuff needs more vetting
> with actual charms/usage. The desktop notification is cool, but again none of
> those is relevant to landing the core and important of the linked bug. pls
> yank those out and resubmit.
>
> Besides that the actual bug fix uses /tmp paths for pid and logfiles which
> feels questionable. Also the generic service name unless its truly generic
> rather than a twisted daemon process launcher.
Thanks for the review, I'll separate out the branch as we spoke about. I couldn't parse the last line of the review though, any help?
> as discussed in irc, this branch has three other features in addition to the
> bug fix which should be in another branch. The tmp folder guards are
> irrelevant given the branches focus. The ephemeral stuff needs more vetting
> with actual charms/usage. The desktop notification is cool, but again none of
> those is relevant to landing the core and important of the linked bug. pls
> yank those out and resubmit.
>
> Besides that the actual bug fix uses /tmp paths for pid and logfiles which
> feels questionable. Also the generic service name unless its truly generic
> rather than a twisted daemon process launcher.
Thanks for the review, I'll separate out the branch as we spoke about. I couldn't parse the last line of the review though, any help?