Code review comment for lp:~bcsaller/pyjuju/lxc-repairs

Revision history for this message
Benjamin Saller (bcsaller) wrote :

Reviewers: mp+115206_code.launchpad.net,

Message:
Please take a look.

Description:
Remove LXC restart partial support

Local lxc containers were initially intended to be ephemeral. This patch
makes that official
removing the partial restart of services via upstart from local
containers. It includes
a number of other minor tweaks including warning when a /tmp dir is used
for keeping
container state (as a developer could still manually restart containers
if state was stable).

With the change to ephemeral containers the /tmp change might not make
sense but the warning
shouldn't prove an issue and can easily prove useful in the future if we
choose to fully support
restarts.

https://code.launchpad.net/~bcsaller/juju/lxc-repairs/+merge/115206

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/6404052/

Affected files:
   A [revision details]
   M juju/agents/machine.py
   M juju/control/destroy_environment.py
   A juju/lib/juju.png
   M juju/lib/lxc/__init__.py
   M juju/lib/lxc/data/juju-create
   M juju/lib/lxc/tests/test_lxc.py
   A juju/lib/notifier.py
   A juju/lib/service.py
   A juju/lib/tests/test_notifier.py
   A juju/lib/tests/test_service.py
   M juju/lib/upstart.py
   M juju/machine/tests/test_unit_deployment.py
   M juju/machine/unit.py
   M juju/providers/local/__init__.py
   M juju/providers/local/agent.py
   M juju/providers/local/tests/test_agent.py
   M juju/providers/local/tests/test_provider.py
   M setup.py

« Back to merge proposal