lp:~bcsaller/juju-gui/routing-hash-query
- Get this branch:
- bzr branch lp:~bcsaller/juju-gui/routing-hash-query
Branch merges
- Juju GUI Hackers: Pending requested
-
Diff: 185 lines (+89/-16)2 files modifiedapp/assets/javascripts/ns-routing-app-extension.js (+71/-16)
test/test_routing.js (+18/-0)
Related source package recipes
Related bugs
| Bug #1188784: nsRouter methods are not querystring or hash aware | Undecided | Fix Released |
|
Related blueprints
Branch information
Recent revisions
- 712. By Richard Harding
-
Prevent a case of charm details double dispatch.
- This double dispatch caused the charm details to be rendered multiple times
causing issues with the tabview.
- We match multiple routes in the browser subapp. We always match on * for
instance. In the case of the * route, a url path /charm/id will match, but
not have a req.params.id set, this causes the _viewState to think there is
no charm id in the request. Because of this, it clears any current _details
View object. However, a later matched route *id will find the id and cause
it to render again. This could happen a couple of times.
- We create custom callables for the * and *id routes.
- These callables only kick in and do any work at all if they're the perfect
match for that path.
- If they do not apply, then they ignore and carry on allowing later matching
routes (more specific ones) to do their work correctly.R=j.c.sackett, benjamin.saller
CC=
https://codereview. appspot. com/10086045 - 711. By Richard Harding
-
Provide fallback messaging when QA data missing
- There are two cases of missing QA data
- No qa data currently available for a reviewed charm.
- The charm is not reviewed and will not have QA data.
- Provide a unique message for both cases and do not display the charm as
having poor/no quality to it.
- Add tests that we flip the right messages in each case.
- Add the charm data to the qa information so we can toggle on is_approved.R=curtis, gary.poster
CC=
https://codereview. appspot. com/10049044 - 710. By Benjamin Saller
-
Databinding Library
Support for 1-way bindings from model to forms. Favors minimal updates
where possible.Supports:
Models
ModelList (limited to updating all children on change notification)Still Needs:
LazyModelList of Plain JS object support
will be done with the included Object.observe polyfill
Collision Indication/handlingR=rharding, gary.poster, benjamin.saller
CC=
https://codereview. appspot. com/9860052 - 709. By Jeff Pihach
-
Implements the view-container module
The view-container module is responsible for rendering viewlets
into the dom and then sending their configuration to the
bindengine.The bindengine and view-container were developed separately
but in parallel so there may be some issues wrt integration
at this time.R=rharding, benjamin.saller
CC=
https://codereview. appspot. com/10090045 - 708. By Benji York
-
Apply yuidoc's internal linting to our docs.
- turn on yuidoc's linting
- rename the 'yuidoc-lint' target to 'lint-yuidoc' to follow recent pattern
- fix all the lint errors it foundR=jeff.pihach, rharding
CC=
https://codereview. appspot. com/10045046 - 707. By j.c.sackett
-
Fixes black bar on fullscreen charmdetails
The error was happening b/c charmdetails was reloading multiple times, which
broke its render state. The multiple reloads were from _stripViewMode
returning "/series/charmname- revno" or "series/ charmname- revno", depending on
inputs.
-_stripViewMode now always removes the preceding slash on the charmID
-_stripViewMode is now tested for all paths it can receiveR=rharding, jeff.pihach
CC=
https://codereview. appspot. com/9964044 - 706. By Benji York
-
Add a linter that checks for copyright headers.
R=gary.poster, frankban
CC=
https://codereview. appspot. com/9981044
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:juju-gui/experimental
