lp:~bcsaller/juju-gui/phantom-testing

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:juju-gui/experimental at revision 341

Juju GUI Hackers: Pending requested 2013-01-24

Diff: 472 lines (+60/-73)

14 files modified

.lbox.check (+1/-1)
Makefile (+1/-1)
app/app.js (+11/-23)
app/assets/javascripts/d3-components.js (+2/-3)
app/models/models.js (+2/-5)
app/store/env.js (+12/-12)
app/views/charm.js (+3/-3)
app/views/environment.js (+0/-1)
app/views/unit.js (+2/-2)
app/views/utils.js (+7/-7)
test-server.sh (+4/-2)
test/index.html (+11/-9)
test/test_env.js (+2/-2)
test/utils.js (+2/-2)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

341. By Benjamin Saller on 2013-01-24

initial pass at phantomjs, removes alot (too much?) troublesome logging

340. By Francesco Banconi on 2013-01-23

Fix error while removing relations.

When removing a relation sometimes an exception
is raised: "Uncaught TypeError: Cannot call method
'one' of null".
I was able to reproduce the bug following these steps:
1) click on a relation, the remove relation modal
   dialog appears;
2) open the GUI in another tab, and force a delta stream
   event (e.g. add/remove another relation,
   destroy a service...);
3) on delta, the relation nodes are redrawn on both tabs,
   so the element stored in the dialog no longer exists
   in the DOM;
4) on the first tab, click to confirm the relation removal,
   you'll see the error.
In this branch, the relation node is retrieved again in
removeRelation using its relation id. This way we ensure
the element actually exists in the DOM.

R=bac, benji
CC=
https://codereview.appspot.com/7199043

339. By Brad Crittenden on 2013-01-22

When adding a relation, the service menu is shown.

If adding a relation using the 'Build Relation' action from the service menu
on the originating service, the click on the target service produces two
events. The dragend event is handled properly and sets up the relation. Then
the click event calls serviceClick.

Attempts to use the stopPropagation, stopEvent, and preventDefault methods on
the d3.event did not produce the desired results.

This work-around is pretty hacky but it does work. A more general solution
should be found.

Also, attempts to change the test 'must be able to add a relation from the
service menu' to simulate the click events and ensure the service menu was not
left displayed did not work.

This branch is submitted as is in an attempt to finish the last card blocking
the charm announcement.

R=bcsaller
CC=
https://codereview.appspot.com/7179049

338. By Gary Poster on 2013-01-22

Switch to newer, clearer favicon

favicon provided by Huw. Originals available in shared Google juju-gui/graphic resources folder, https://drive.google.com/a/canonical.com/?tab=co#folders/0B9C9etoysSQla1dWRFNWeWlBWHc

R=
CC=
https://codereview.appspot.com/7184045

337. By Francesco Banconi on 2013-01-22

Fix ambiguous relation selector

When there are ambiguous relations clicking
to select one or the other does nothing.
This bug affected only our production server,
devel and debug worked well. This is weird,
and I think we are encountering the strange
behavior described in
http://yuilibrary.com/projects/yui3/ticket/2532993
or similar: in some situation (e.g. our production
server, where js files are minified/compressed)
using the "on" method on NodeList does not work.
I am confused about the real reason for this bug.
However, the documentation says that we should
avoid using NodeList.on, in favor of using event
delegation, that is exactly what I did in this
branch. Tests are not included: we have a specific
card for adding tests for the relation module.

R=benji, gary.poster
CC=
https://codereview.appspot.com/7177050

336. By Benjamin Saller on 2013-01-22

Fix various breakage around menu handling

Fixed issues from merge around method name change and fixed strange
interaction issues with click and dragstart both interacting with the menu on
non-drag events (dragstart it seems is called on any bound targets click).

R=frankban, teknico
CC=
https://codereview.appspot.com/7174045

335. By Francesco Banconi on 2013-01-22

Allow creating non-FINAL release tarballs.

In the charm, when juju-gui-source is a branch,
a release tarball is created from the checkout
running "NO_BZR=1 make distfile".
The "distfile" target was included in the
released/unreleased check by our Makefile.
This means that trying to deploy the charm
from a branch whose CHANGES.yaml does not
include "unreleased:" always fails with
the error reported by therve:
"non-FINAL releases must have a most-recent
version number of unreleased in CHANGES.yaml".
This branch removes that check from the distfile
target: I think we should protect "dist", but
I don't see, given the problems described above,
a valid reason to continue preventing users
to create non-FINAL tarballs, even if the
branch is a final release.

R=teknico, bac
CC=
https://codereview.appspot.com/7189043

334. By Brad Crittenden on 2013-01-21

Set version back to unreleased.

333. By Brad Crittenden on 2013-01-21

Set version for release.

332. By Benjamin Saller on 2013-01-21

Support for service positions from server

Provides support for loading initial and updated position
from annotations stored on the server. Updates occur
via a shared codepath with the drag event handler
to ensure proper updates are applied over time.

There is still an issue with deltas interrupting the drag.

R=gary.poster, frankban
CC=
https://codereview.appspot.com/7132061