lp:~bcsaller/juju-gui/deployer-export
- Get this branch:
- bzr branch lp:~bcsaller/juju-gui/deployer-export
Branch merges
- Juju GUI Hackers: Pending requested
-
Diff: 237 lines (+131/-10)6 files modifiedapp/app.js (+21/-6)
app/models/models.js (+69/-3)
app/store/env/fakebackend.js (+1/-1)
app/views/topology/importexport.js (+1/-0)
test/test_fakebackend.js (+1/-0)
test/test_model.js (+38/-0)
Branch information
Recent revisions
- 756. By Madison Scott-Clary
-
Add QA checklist to release process
Quick checklist of simple interaction to complete prior to release comprising actions that a new user might take with the UI. Also includes note to look at releasable cards and check those as well. QA with `make view-docs`
R=jeff.pihach, gary.poster
CC=
https://codereview. appspot. com/10407046 - 755. By Richard Harding
-
Add support for related charm loading and display
- Adds a new store endpoint for the related charm api call
- Adds the idea of relatedCharms for model ATTRS
- Adds two helpers to take the api response data into something we can use in
the app
- Renders out the related charms in the template in fullscreen as an ajax
request
- Updates the charm details to handle click events on charm tokens
- Adds tests for the model helpers and the details view
- Updates a bunch of tests. There were left over testing Nodes that caused
stray tests to fail. I fixed those and also went back and cleaned up the stray
test mess.
- Updates the css to work out so that the tokens can fit. There's a
redesign-a-coming so the work was to fit in currently and the redesign will
move the layout at a later date.Notes:
- This does not currently add the related charm display to the interfaces tab.
It's a slightly different UX and this branch was taking too long as is.- I'm not happy with the relatedCharms ATTR. It's not really an ATTR but I
wanted this cached into the model because we'll use that when we add related
charms to the interfaces tab. We don't want to re-request the data. However,
in sidebar move it will not have been requested yet. My plan is to re-evaluate
and possibly refactor when doing the interfaces tab display.
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:juju-gui/experimental