lp:~bcsaller/juju-gui/databinding-safeupdate

Created by Benjamin Saller on 2013-08-15 and last modified on 2013-08-15
Get this branch:
bzr branch lp:~bcsaller/juju-gui/databinding-safeupdate
Only Benjamin Saller can upload to this branch. If you are Benjamin Saller please log in for upload directions.

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Benjamin Saller
Project:
juju-gui
Status:
Development

Recent revisions

958. By Benjamin Saller on 2013-08-15

support for key combinging with the side effect that multiple binding updates should work

957. By Madison Scott-Clary on 2013-08-15

Update SVGs with viewbox

Trivial update of category icons with viewbox.

R=
CC=
https://codereview.appspot.com/12828045

956. By Jeff Pihach on 2013-08-15

Adding test for destroy ghost service

A fix was landed for https://bugs.launchpad.net/juju-gui/+bug/1212466
but a test for this codepath wasn't included. This simply adds
that missing test increasing the code coverage.

R=rharding, benjamin.saller
CC=
https://codereview.appspot.com/12998043

955. By Richard Harding on 2013-08-15

Fixes #1207045 extra whitespace in charm details

- When going from fullscreen editorial or search results to a charm details
the height was always matched to the editorial/results height. This causes
extra whitespace in the charm details layout.
- This was due to the indidicator spinner used for activity. It's using a
yui-hidden class when not showing to hide, but that causes it to still force
height.
- In the end, we can destroy the outdated content when we navigate to the
details. In fact, we should clean it up regardless. This adds code and a test
to verify that the .fullscreen() browser subapp function will clean older
editorial/search results views.

QA:

Go to /fullscreen, click on a charm. The height should be tighter to the end
of the charm details content. Compare against
comingsoon.jujucharms.com/fullscreen (and the same charm)

R=matthew.scott, j.c.sackett
CC=
https://codereview.appspot.com/12997043

954. By j.c.sackett on 2013-08-15

Fixes expected models in destroy

As part of the fallout from the great model unification of '13, destroying ghost
services in the service inspector stopped working. This was because it was
expecting `charm` when `browser-charm` is actually passed.

R=rharding, jeff.pihach
CC=
https://codereview.appspot.com/12795046

953. By Richard Harding on 2013-08-15

Fixes #1207041 environment view shifts in IE

Two changes, these are QA only.

- Drive by, the feedback tab should overlay the zoom slider when you hover
over it. Upped its z-index so it's over the zoom slider when hovered.
- IE would shift the whole environment when the charm details did the
scrollIntoView call. This is done so that if you scroll down on one charm, and
then click a second charm in the results list on the left, you want to reset
the scroll position. It turns out IE hates scrollIntoView and ran into some
hints in the question:
http://stackoverflow.com/questions/11039885/scrollintoview-causing-the-whole-page-to-move

This changes the scrollIntoView into a hard coded scrollTop which works to
reset the position and works in all browsers in QA.

R=benji, j.c.sackett
CC=
https://codereview.appspot.com/12871046

952. By Richard Harding on 2013-08-15

Fixes support for loading config from file.

The config file handling code was copied to the inspector, but the tests
weren't. Most of this branch is adding the tests from the old to the new.

- The two main bugs were that the variable name was called fileContent vs
configFileContent.
- The other was the deploy call looking on this.configFileContent vs on the
viewletManager where the content is kept.
- Small change to the onFileLoad to make testing easier. The UI is updated now
without having to fake it or to mock up handleFileChange in odd ways.
- Also did some small tweaks to alphabetize the var names and such in the
tests to make it easier to see what vars there are and find out if something
is global (in the test scope) or not.

R=jeff.pihach, matthew.scott
CC=
https://codereview.appspot.com/12797046

951. By j.c.sackett on 2013-08-14

Minor clean ups from model unification.

* XXX notes have been consolidated to indicate what should actually be done once
possible.
* The checks in BrowserCharm.parse have been updated based on investigation into
the PyJuju and GoJuju environments. As the data passed is consistently in one
form or another, we now just check if "config" exists and parse
the data as needed in that case.

R=matthew.scott, rharding
CC=
https://codereview.appspot.com/12897043

950. By Benjamin Saller on 2013-08-14

Import support for deployer format

Databases can import deployer format dumps with some options around
handling items as ghosts or not.

R=benjamin.saller, matthew.scott, rharding
CC=
https://codereview.appspot.com/12866043

949. By Madison Scott-Clary on 2013-08-14

Finish go-sandbox implementation

This should be the rest of the methods needed to complete the Go sandbox implementation. QA requested from both reviewers - I've been QAing through the day, but am proposing at EoD.

R=benjamin.saller, rharding
CC=
https://codereview.appspot.com/12900043

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
Stacked on:
lp:juju-gui/experimental
This branch contains Public information 
Everyone can see this information.

Subscribers