lp:~bcsaller/juju-gui/charmFind

Branch merges

Propose for merging

1 branch proposed for merging into this one.

No branches dependent on this one.

Merged into lp:juju-gui/experimental at revision 972

Juju GUI Hackers: Pending requested 2013-08-21

Diff: 468 lines (+264/-40)

11 files modified

app/models/charm.js (+34/-1)
app/models/models.js (+9/-4)
app/store/charm.js (+41/-5)
app/views/environment.js (+0/-3)
app/views/topology/service.js (+53/-21)
test/data/blog.yaml (+52/-0)
test/test_charm_store.js (+13/-0)
test/test_databinding.js (+24/-0)
test/test_inspector_charm.js (+1/-3)
test/test_model.js (+36/-3)
test/utils.js (+1/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

971. By Benjamin Saller on 2013-08-21

missing test data, deployer format

970. By Benjamin Saller on 2013-08-21

lint

969. By Benjamin Saller on 2013-08-21

extracting diff

968. By Huw Wilkins on 2013-08-21

Fixes bug #1213264: IE10 inspector scrollbar

Fixed bug #1213264: Overview Inspector has horizontal scroll bar in IE10
Also did a drive-by to fix a breakage in Firefox and some general spacing issues for the constraints confirmation.

R=jeff.pihach
CC=
https://codereview.appspot.com/13145043

967. By Jeff Pihach on 2013-08-20

Fixing IE UI Bugs

IE10 puts a 'clear input' X when inputs are focused. This conflicts
with our conflict ux story so this branch adds the CSS to hide those
X's in the inspector. (1213270)

Stops scale up dialogue from wrapping when the constraints are too
wide (1213267)

R=rharding, matthew.scott
CC=
https://codereview.appspot.com/12987045

966. By Jeff Pihach on 2013-08-19

Normalizing the getConstraints code

In order to allow us to share constraints code across
the three locations it needs to be used it needed to
be normalized. This is the first step towards the following
ghost constraints and upgrade ux constraints branches.

R=bac, benji
CC=
https://codereview.appspot.com/12956045

965. By Jeff Pihach on 2013-08-19

Fixes ghost name input bug in IE10

The height of the service name input box in
the ghost inspector was causing the name to be cut
off in IE10.

R=j.c.sackett, benji
CC=
https://codereview.appspot.com/13094044

964. By j.c.sackett on 2013-08-19

Removes the bws-icon from fullscreen

The bws-icon handles minimizing the sidebar view; we don't need it in
fullscreen, it shouldn't render, and when it does it causes errors and renders
oddly.

R=matthew.scott, jeff.pihach
CC=
https://codereview.appspot.com/12852045

963. By Jeff Pihach on 2013-08-19

Update jshint to 2.1.9

This branch updates jshint to the most recent version.
Because of the new version some of the configuration
options have changed so it needed to be modified.
This branch also fixes the issues reported by the update
and converted old inline jshint flags to the new format.

R=j.c.sackett, bac
CC=
https://codereview.appspot.com/13072043

962. By Madison Scott-Clary on 2013-08-19

Trivial: icons stretched in inspector in IE10

Simple CSS fix to prevent icons from being stretched in the inspector - IE10 was doing weird things with the cascading part of CSS. Being more specific fixed it.

R=jeff.pihach
CC=
https://codereview.appspot.com/13069043