Merge lp:~bbqsrc/egtk/fix-1070902 into lp:egtk/1.0

Proposed by Brendan Molloy
Status: Work in progress
Proposed branch: lp:~bbqsrc/egtk/fix-1070902
Merge into: lp:egtk/1.0
Diff against target: 18 lines (+3/-3)
1 file modified
metacity-1/metacity-theme-3.xml (+3/-3)
To merge this branch: bzr merge lp:~bbqsrc/egtk/fix-1070902
Reviewer Review Type Date Requested Status
Cassidy James Blaede Needs Fixing
Review via email: mp+134309@code.launchpad.net

Description of the change

This fixes the height of the title bar globally so that application-specific hacks are no necessary to have a nice looking title bar.

This makes windows such as gvim windows, Firefox's about dialog, and any other window whose title bar is not followed by a menu look nice.

To post a comment you must log in.
Revision history for this message
David Gomes (davidgomes) wrote :

This fixes so many problems I had with Pantheon's appearance. No, it really does.

Revision history for this message
Cassidy James Blaede (cassidyjames) wrote :

The only way I see this going through is if we somehow remove some of the space from the top of toolbars so that the text stays centered on all of our apps. Otherwise, as-is, the text looks oddly close to the top of the titlebar and too far away from the toolbar.

review: Needs Fixing
Revision history for this message
Brendan Molloy (bbqsrc) wrote :

I had said this on IRC, but didn't add a comment.

I'm looking into a method of fixing the issue once and for all by modifying the GTK theme and seeing if that's suitable for solving this problem. Should take me a week or so, pending work not getting in the way. :)

Unmerged revisions

549. By Brendan Molloy

fix height of title bar

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'metacity-1/metacity-theme-3.xml'
2--- metacity-1/metacity-theme-3.xml 2012-07-31 01:04:56 +0000
3+++ metacity-1/metacity-theme-3.xml 2012-11-14 14:52:26 +0000
4@@ -22,11 +22,11 @@
5 <distance name="right_titlebar_edge" value="4"/>
6 <distance name="title_vertical_pad" value="0"/>
7 <aspect_ratio name="button" value="1.0"/>
8- <border name="title_border" left="10" right="10" top="7" bottom="0"/>
9- <border name="button_border" left="2" right="2" top="5" bottom="0"/>
10+ <border name="title_border" left="10" right="10" top="5" bottom="4"/>
11+ <border name="button_border" left="2" right="2" top="5" bottom="3"/>
12 </frame_geometry>
13
14-<frame_geometry name="max"parent="normal" rounded_top_left="false" rounded_top_right="false">
15+<frame_geometry name="max" parent="normal" rounded_top_left="false" rounded_top_right="false">
16 <distance name="left_width" value="0"/>
17 <distance name="right_width" value="0"/>
18 <distance name="bottom_height" value="0"/>

Subscribers

People subscribed via source and target branches

to all changes: