Merge lp:~bbaqar/charms/trusty/plumgrid-director/conflicts into lp:~plumgrid-team/charms/trusty/plumgrid-director/trunk

Proposed by Bilal Baqar
Status: Merged
Merged at revision: 26
Proposed branch: lp:~bbaqar/charms/trusty/plumgrid-director/conflicts
Merge into: lp:~plumgrid-team/charms/trusty/plumgrid-director/trunk
Diff against target: 46 lines (+5/-3)
3 files modified
Makefile (+1/-1)
hooks/pg_dir_utils.py (+1/-2)
unit_tests/test_pg_dir_hooks.py (+3/-0)
To merge this branch: bzr merge lp:~bbaqar/charms/trusty/plumgrid-director/conflicts
Reviewer Review Type Date Requested Status
Hassaan Pasha Approve
Review via email: mp+288020@code.launchpad.net

Description of the change

WIP

To post a comment you must log in.
Revision history for this message
Hassaan Pasha (hassaanp) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Makefile'
2--- Makefile 2015-08-24 16:18:48 +0000
3+++ Makefile 2016-03-03 21:06:17 +0000
4@@ -7,7 +7,7 @@
5 netaddr jinja2
6
7 lint: virtualenv
8- .venv/bin/flake8 --exclude hooks/charmhelpers hooks unit_tests tests
9+ .venv/bin/flake8 --exclude hooks/charmhelpers hooks unit_tests tests --ignore E402
10 @charm proof
11
12 unit_test: virtualenv
13
14=== modified file 'hooks/pg_dir_utils.py'
15--- hooks/pg_dir_utils.py 2015-11-21 22:07:15 +0000
16+++ hooks/pg_dir_utils.py 2016-03-03 21:06:17 +0000
17@@ -327,8 +327,7 @@
18 'plumgrid:plumgrid',
19 LICENSE_POST_PATH,
20 '-d',
21- json.dumps(license)
22- ]
23+ json.dumps(license)]
24 licence_get_cmd = [PG_CURL, '-u', 'plumgrid:plumgrid', LICENSE_GET_PATH]
25 try:
26 old_license = subprocess.check_output(licence_get_cmd)
27
28=== modified file 'unit_tests/test_pg_dir_hooks.py'
29--- unit_tests/test_pg_dir_hooks.py 2016-01-14 12:39:52 +0000
30+++ unit_tests/test_pg_dir_hooks.py 2016-03-03 21:06:17 +0000
31@@ -1,5 +1,7 @@
32 from mock import MagicMock, patch, call
33+
34 from test_utils import CharmTestCase
35+
36 with patch('charmhelpers.core.hookenv.config') as config:
37 config.return_value = 'neutron'
38 import pg_dir_utils as utils
39@@ -9,6 +11,7 @@
40
41 utils.register_configs = MagicMock()
42 utils.restart_map = MagicMock()
43+
44 import pg_dir_hooks as hooks
45
46 utils.register_configs = _reg

Subscribers

People subscribed via source and target branches