Merge lp:~bartoszopka/snapweb/vanilla-framework into lp:~snappy-dev/snapweb/trunk

Proposed by Bartek Szopka
Status: Superseded
Proposed branch: lp:~bartoszopka/snapweb/vanilla-framework
Merge into: lp:~snappy-dev/snapweb/trunk
Diff against target: 88 lines (+40/-0)
4 files modified
gulpfile.js (+4/-0)
package.json (+2/-0)
www/src/css/lib/vanilla-includes.scss (+26/-0)
www/src/css/lib/vanilla-overrides.scss (+8/-0)
To merge this branch: bzr merge lp:~bartoszopka/snapweb/vanilla-framework
Reviewer Review Type Date Requested Status
Steven Wilkin (community) Approve
Review via email: mp+296094@code.launchpad.net

This proposal has been superseded by a proposal from 2016-06-08.

Description of the change

Example of how Vanilla framework can be included in webdm project to allow loading only chosen modules from vanilla and keep vanilla overrides separate from rest of styles.

To post a comment you must log in.
Revision history for this message
Steven Wilkin (stevenwilkin) wrote :

+1

review: Approve
Revision history for this message
Steven Wilkin (stevenwilkin) wrote :

+1

review: Approve

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'gulpfile.js'
2--- gulpfile.js 2015-05-26 19:08:26 +0000
3+++ gulpfile.js 2016-06-07 13:29:23 +0000
4@@ -13,6 +13,7 @@
5 var imagemin = require('gulp-imagemin');
6 var jscs = require('gulp-jscs');
7 var jshint = require('gulp-jshint');
8+var sass = require('gulp-sass');
9 var sourcemaps = require('gulp-sourcemaps');
10 var source = require('vinyl-source-stream');
11 var uglify = require('gulp-uglify');
12@@ -102,8 +103,11 @@
13
14 return gulp.src([
15 'node_modules/normalize.css/normalize.css',
16+ 'www/src/css/lib/vanilla-includes.scss',
17+ 'www/src/css/lib/vanilla-overrides.scss',
18 'www/src/css/**/*.css'
19 ])
20+ .pipe(sass())
21 .pipe(sourcemaps.init())
22 .pipe(postcss(processors))
23 .pipe(csso())
24
25=== modified file 'package.json'
26--- package.json 2015-09-25 19:27:33 +0000
27+++ package.json 2016-06-07 13:29:23 +0000
28@@ -20,6 +20,7 @@
29 "gulp-jscs": "~1.4.0",
30 "gulp-jshint": "~1.9.4",
31 "gulp-postcss": "^5.1.6",
32+ "gulp-sass": "^2.3.1",
33 "gulp-sourcemaps": "~1.5.0",
34 "gulp-uglify": "~1.1.0",
35 "gulp-util": "~3.0.4",
36@@ -40,6 +41,7 @@
37 "postcss-bem-linter": "^0.6.0",
38 "postcss-custom-media": "^3.0.0",
39 "pretty-bytes": "^2.0.1",
40+ "vanilla-framework": "0.0.78",
41 "vinyl-buffer": "~1.0.0",
42 "vinyl-source-stream": "~1.1.0",
43 "watchify": "~3.1.2"
44
45=== added directory 'www/src/css/lib'
46=== added file 'www/src/css/lib/vanilla-includes.scss'
47--- www/src/css/lib/vanilla-includes.scss 1970-01-01 00:00:00 +0000
48+++ www/src/css/lib/vanilla-includes.scss 2016-06-07 13:29:23 +0000
49@@ -0,0 +1,26 @@
50+/*
51+ * Vanilla Framework Includes
52+ * ============================
53+ */
54+
55+
56+// OVERRIDE VANILLA SETTINGS
57+//
58+// before including any vanilla styles, override variables from _global_settings.scss
59+$brand_color: #fff;
60+
61+// IMPORT VANILLA
62+@import "../../../../node_modules/vanilla-framework/scss/vanilla";
63+
64+// INCLUDE VANILLA MODULES
65+//
66+// Only include modules that are used in the app.
67+// For a list of available modules see Vanilla source code:
68+// https://github.com/ubuntudesign/vanilla-framework/blob/master/scss/_vanilla.scss
69+
70+@include vf-reset;
71+// TODO: add other modules when necessary
72+//
73+// @include vf-boxes;
74+// @include vf-grid;
75+
76
77=== added file 'www/src/css/lib/vanilla-overrides.scss'
78--- www/src/css/lib/vanilla-overrides.scss 1970-01-01 00:00:00 +0000
79+++ www/src/css/lib/vanilla-overrides.scss 2016-06-07 13:29:23 +0000
80@@ -0,0 +1,8 @@
81+/*
82+ * Vanilla Framework Overrides
83+ */
84+
85+// If any styles from vanilla framework need to be overridden, corresponding
86+// SCSS rules should be put in this file (not mixed with other styles).
87+
88+

Subscribers

People subscribed via source and target branches