~barryprice/ubuntu-mirror-charm/+git/ubuntu-mirror-charm:master

Branch merges

Propose for merging

Merged into ubuntu-mirror-charm:master at revision 4cb13e3cd856cb2897a270c21ea06a10e7d55dad

Paul Collins: Approve (lgtm) on 2020-09-17

Canonical IS Reviewers: Pending requested 2020-09-16

Diff: 56 lines (+6/-6)

2 files modified

hooks/hooks.py (+1/-1)
tests/unit/test_charm.py (+5/-5)

api

Merged into ubuntu-mirror-charm:master at revision 70d7abcd0bae4f2c2d8603576e0d6cfcb045b5e0

Haw Loeung: Approve on 2020-09-15

Paul Collins: Approve (lgtm) on 2020-09-15

Barry Price: Needs Resubmitting on 2020-09-14

Canonical IS Reviewers: Pending requested 2020-09-09

Diff: 253 lines (+176/-1)

3 files modified

hooks/hooks.py (+108/-0)
tests/unit/requirements.txt (+1/-0)
tests/unit/test_charm.py (+67/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

eda7335... by Barry Price on 2020-09-16

Use nofail for all new bind mount entries

4959511... by Paul Collins on 2020-09-16

now that rsync is managed via socket activation, there can be 0 processes

Reviewed-on: https://code.launchpad.net/~pjdc/ubuntu-mirror-charm/+git/ubuntu-mirror-charm/+merge/390780
Reviewed-by: Haw Loeung <email address hidden>

153bec4... by Paul Collins on 2020-09-16

now that rsync is managed via socket activation, there can be 0 processes

70d7abc... by Barry Price on 2020-09-15

Handle LP:1891566 by bind-mounting any paths outside /srv/ftp.root back into it, so that our chrooted vsftp can serve all the same files as apache2/rsync.

Reviewed-on: https://code.launchpad.net/~barryprice/ubuntu-mirror-charm/+git/ubuntu-mirror-charm/+merge/390394
Reviewed-by: Paul Collins <email address hidden>
Reviewed-by: Haw Loeung <email address hidden>

54910da... by Barry Price on 2020-09-10

Use freezegun for tests instead of passing datetime suffices around

d95c85e... by Barry Price on 2020-09-10

Clean up remove_bind_mount() logic

d7b933b... by Barry Price on 2020-09-10

Address review, update tests to match

95fd3a0... by Barry Price on 2020-09-09

Test add/remove bind mount logic

1c873b7... by Barry Price on 2020-09-09

Use stringio to read /etc/fstab to make tests simpler, add initial tests

e7f72c6... by Barry Price on 2020-09-08

Add comments, reduce complexity so that 'make lint' passes