Merge ~barryprice/charm-test/+git/charm-test:master into charm-test:master

Proposed by Barry Price
Status: Merged
Approved by: Tom Haddon
Approved revision: 209419d814bc9352603ff0b1f8cabc8a8f64b212
Merged at revision: dd376f443f8411cd5e1bfec7551427f64b898c6b
Proposed branch: ~barryprice/charm-test/+git/charm-test:master
Merge into: charm-test:master
Diff against target: 13 lines (+1/-1)
1 file modified
charm_test.py (+1/-1)
Reviewer Review Type Date Requested Status
Tom Haddon Approve
Review via email: mp+356907@code.launchpad.net

Commit message

Let's use a Bionic LXC instead of Xenial

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Tom Haddon (mthaddon) wrote :

LGTM. I'd like to be able to have the charm specify this, but since it doesn't currently, and isn't widely used, I don't see any harm in updating this now.

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision dd376f443f8411cd5e1bfec7551427f64b898c6b

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/charm_test.py b/charm_test.py
2index 06ef103..ee81008 100755
3--- a/charm_test.py
4+++ b/charm_test.py
5@@ -65,7 +65,7 @@ def recreate_lxc(args):
6 deleted = subprocess.check_output(['lxc', 'delete', '--force', args.container_name], universal_newlines=True)
7 if deleted:
8 print_log("Output from deletion: {}".format(deleted))
9- lxc_launch = subprocess.check_output(['lxc', 'launch', 'ubuntu:16.04', args.container_name],
10+ lxc_launch = subprocess.check_output(['lxc', 'launch', 'ubuntu:18.04', args.container_name],
11 universal_newlines=True)
12 if lxc_launch:
13 print_log("Output from LXC creation: {}".format(lxc_launch))

Subscribers

People subscribed via source and target branches