Merge ~barryprice/charm-test/+git/charm-test:master into charm-test:master

Proposed by Barry Price
Status: Merged
Approved by: Stuart Bishop
Approved revision: 4499e8430206a0487aec24c64e9d027fc21458e3
Merged at revision: 018076655f08381fa2051c7caaf939f8937a74ec
Proposed branch: ~barryprice/charm-test/+git/charm-test:master
Merge into: charm-test:master
Diff against target: 13 lines (+1/-1)
1 file modified
charm_test.py (+1/-1)
Reviewer Review Type Date Requested Status
Stuart Bishop (community) Approve
Review via email: mp+347596@code.launchpad.net

Commit message

Separate juju's -y flag from the controller:model we want to destroy. Otherwise:

INFO 2018-06-07 19:59:28.760091 Running command "juju destroy-model -ylxd:charm-test" in container "charm-test" as ubuntu
ERROR no model specified

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Stuart Bishop (stub) wrote :

Whoops. Yeah, that.

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 018076655f08381fa2051c7caaf939f8937a74ec

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/charm_test.py b/charm_test.py
2index 97be0ca..06ef103 100755
3--- a/charm_test.py
4+++ b/charm_test.py
5@@ -117,7 +117,7 @@ def run_tests(args):
6
7 def clean_up(args):
8 print_log("Cleaning up")
9- lxc_run_as_ubuntu(["juju", "destroy-model", "-y" "{}:{}".format(args.controller_name, args.juju_model_name)],
10+ lxc_run_as_ubuntu(["juju", "destroy-model", "-y", "{}:{}".format(args.controller_name, args.juju_model_name)],
11 args)
12 lxc_delete = subprocess.check_output(['lxc', 'delete', '--force', args.container_name], universal_newlines=True)
13 if lxc_delete:

Subscribers

People subscribed via source and target branches