charm-postfix-relay

Merge ~barryprice/charm-postfix-relay/+git/charm-postfix-relay:master into charm-postfix-relay:master

  1. Git
  2. lp:~barryprice/charm-postfix-relay/+git/charm-postfix-relay
  3. master
  4. Merge into master
Proposed by Barry Price
Status: Rejected
Rejected by: Barry Price
Proposed branch: ~barryprice/charm-postfix-relay/+git/charm-postfix-relay:master
Merge into: charm-postfix-relay:master
Diff against target: 9 lines (+0/-1)
1 file modified
Makefile (+0/-1)
Reviewer Review Type Date Requested Status
Gabriel Cocenza Disapprove
Tianqi Xiao (community) Disapprove
BootStack Reviewers Pending
Review via email: mp+430423@code.launchpad.net

Commit message

Test MP to confirm mergebot integration

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Tianqi Xiao (txiao) :
review: Approve
Revision history for this message
Tianqi Xiao (txiao) wrote :

Since this MP is solely for testing purposes, I think we should close it without merging. Changing my vote to "Disapprove"

review: Disapprove
Revision history for this message
Gabriel Cocenza (gabrielcocenza) wrote :

Disapproving for the same reasons as Tianqi said.

review: Disapprove

Unmerged commits

a62ed60... by Barry Price

Remove trailing whitespace (test MP)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/Makefile b/Makefile
2index 2a8ebca..ad08dcc 100644
3--- a/Makefile
4+++ b/Makefile
5@@ -90,4 +90,3 @@ test: lint proof unittests functional
6
7 # The targets below don't depend on a file
8 .PHONY: help dev-environment pre-commit submodules submodules-update clean build lint reformat proof unittests functional
9-

Subscribers

People subscribed via source and target branches

to all changes: