Merge ~barryprice/charm-nrpe/+git/nrpe-charm:master into ~nrpe-charmers/charm-nrpe:master

Proposed by Barry Price
Status: Merged
Approved by: Junien F
Approved revision: 08bc236479ce4d6478314d42f6af6257dd713f6f
Merged at revision: b5c790489d212f4154d37898a05ab495bd53d6af
Proposed branch: ~barryprice/charm-nrpe/+git/nrpe-charm:master
Merge into: ~nrpe-charmers/charm-nrpe:master
Diff against target: 29 lines (+4/-0)
1 file modified
hooks/services.py (+4/-0)
Reviewer Review Type Date Requested Status
Junien F Approve
Review via email: mp+337040@code.launchpad.net

Commit message

Add empty start/stop sections for those services missing them

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Junien F (axino) wrote :

+1

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision b5c790489d212f4154d37898a05ab495bd53d6af

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/hooks/services.py b/hooks/services.py
2index 2958462..b8afe75 100644
3--- a/hooks/services.py
4+++ b/hooks/services.py
5@@ -18,6 +18,8 @@ def manage():
6 nrpe_utils.install_packages,
7 nrpe_utils.install_charm_files,
8 ],
9+ 'start': [],
10+ 'stop': [],
11 },
12 {
13 'service': 'nrpe-config',
14@@ -40,6 +42,7 @@ def manage():
15 'provided_data': [nrpe_helpers.PrincipalRelation()],
16 'ports': [hookenv.config('server_port'), 'ICMP'],
17 'start': [open_ports, nrpe_utils.restart_nrpe],
18+ 'stop': [],
19 },
20 {
21 'service': 'nrpe-rsync',
22@@ -58,6 +61,7 @@ def manage():
23 nrpe_utils.create_host_export_fragment,
24 ],
25 'start': [nrpe_utils.restart_rsync],
26+ 'stop': [],
27 },
28 ])
29 manager.manage()

Subscribers

People subscribed via source and target branches