Merge ~barryprice/charm-nrpe/+git/charm-nrpe:master into charm-nrpe:master

[Barry Price]

plugins/check_netns.sh: Address LP:2003402, s/CRIT/CRITICAL/g

[🤖 Canonical IS Merge Bot (canonical-is-mergebot)]

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

[🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack)]

FAILED: Continuous integration, rev:80d5b065af201fc2f58f3beb622b56ff0e5f816c
https://jenkins.canonical.com/bootstack/job/lp-charm-nrpe-ci/168/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/bootstack/job/lp-charm-test-functest/2058/
    None: https://jenkins.canonical.com/bootstack/job/lp-update-mp/1933/

Click here to trigger a rebuild:
https://jenkins.canonical.com/bootstack/job/lp-charm-nrpe-ci/168//rebuild

review: Needs Fixing (continuous-integration)

[Barry Price (barryprice)]

Actually less sure this is a good idea now, I came across it on a cloud with networking issues and assumed it was the root cause, but have double checked a couple of other similarly-deployed clouds and found the same CRIT output there while things appear to be working.

I think we may just be shipping a broken check here, and not alerting by happy accident, which may not be a bad thing. Marking this WIP while I dig in further.

Unmerged commits

80d5b06... by Barry Price on 2023-01-20

plugins/check_netns.sh: Address LP:2003402, s/CRIT/CRITICAL/g

diff --git a/files/plugins/check_netns.sh b/files/plugins/check_netns.sh
index 2477bb5..39aa450 100755
--- a/files/plugins/check_netns.sh
+++ b/files/plugins/check_netns.sh
@@ -10,7 +10,7 @@
 check_ret_value() {
     RET=$1
     if [[ $RET -ne 0 ]];then
-        echo "CRIT: $2"
+        echo "CRITICAL: $2"
         exit $STATE_CRIT
     fi
 }
@@ -46,7 +46,7 @@ if [ ${#netnscrit[@]} -eq 0 ]; then
         exit $STATE_OK
     fi
 else
-    echo "CRIT: ${netnscrit[@]} aren't responding"
+    echo "CRITICAL: ${netnscrit[@]} aren't responding"
     exit $STATE_CRIT
 fi