Merge ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master into ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master

Proposed by Barry Price
Status: Merged
Approved by: Tom Haddon
Approved revision: 316a1f21ee77deeca56f8d893432e23f92081115
Merged at revision: 27fa70ac52af813fc0bd35a68a8ea2d2e49ff9bf
Proposed branch: ~barryprice/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master
Merge into: ~wordpress-charmers/charm-k8s-wordpress/+git/wordpress-k8s-image-builder:master
Diff against target: 13 lines (+1/-1)
1 file modified
fetcher.py (+1/-1)
Reviewer Review Type Date Requested Status
Tom Haddon Approve
Canonical IS Reviewers Pending
Review via email: mp+377649@code.launchpad.net

Commit message

Print themes as they're being downloaded, as well as plugins

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Tom Haddon (mthaddon) wrote :

One comment inline

Revision history for this message
Tom Haddon (mthaddon) wrote :

LGTM, thx

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 27fa70ac52af813fc0bd35a68a8ea2d2e49ff9bf

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/fetcher.py b/fetcher.py
2index 9f93073..410748e 100755
3--- a/fetcher.py
4+++ b/fetcher.py
5@@ -110,7 +110,7 @@ def get_themes(branch_themes):
6 current_branch = 0
7 for branch_theme in branch_themes:
8 current_branch = current_branch + 1
9- print('Downloading branched theme {} of {}...'.format(current_branch, total_branches))
10+ print('Downloading {} of {} branched themes: {} ...'.format(current_branch, total_branches, branch_theme))
11 url = branch_themes[branch_theme].get('url')
12 basename = os.path.basename(url)
13 if basename.startswith('lp:'):

Subscribers

People subscribed via source and target branches