~barryprice/charm-k8s-bind/+git/charm-k8s-bind:charmcraft-review

Last commit made on 2020-10-01
Get this branch:
git clone -b charmcraft-review https://git.launchpad.net/~barryprice/charm-k8s-bind/+git/charm-k8s-bind
Only Barry Price can upload to this branch. If you are Barry Price please log in for upload directions.

Branch merges

Branch information

Name:
charmcraft-review
Repository:
lp:~barryprice/charm-k8s-bind/+git/charm-k8s-bind

Recent commits

b9911ff... by Barry Price

Address review comments, and drop the io import since we no longer use it

0b6f6c2... by Barry Price

Address charmcraft review

84be32b... by Barry Price

First draft of README.md

Reviewed-on: https://code.launchpad.net/~barryprice/charm-k8s-bind/+git/charm-k8s-bind/+merge/389321
Reviewed-by: Tom Haddon <email address hidden>

cc6ce12... by Barry Price

First draft of README.md

56b7767... by Barry Price

Add missing docstrings, remove a useless method that only ever called another one

Reviewed-on: https://code.launchpad.net/~barryprice/charm-k8s-bind/+git/charm-k8s-bind/+merge/388527
Reviewed-by: Tom Haddon <email address hidden>

0da9ca1... by Barry Price

Old docstring needed to be a comment, did that and added a new docstring

39438cb... by Barry Price

Add missing docstrings, remove a useless method that only ever called another one

9e15f5e... by Barry Price

Add more unit tests. This gets us to 90% coverage.

Reviewed-on: https://code.launchpad.net/~barryprice/charm-k8s-bind/+git/charm-k8s-bind/+merge/388452
Reviewed-by: Tom Haddon <email address hidden>

7745480... by Barry Price

PEP8 docstring fixes

60eeaa0... by Barry Price

Merge branch 'master' into unit-tests