Merge ~barryprice/charm-canonical-livepatch/+git/canonical-livepatch-charm:master into ~livepatch-charmers/charm-canonical-livepatch:master

Proposed by Barry Price
Status: Merged
Approved by: Gareth Woolridge
Approved revision: e0961692445687aec9d9f2e0417eff9c0cad05b3
Merged at revision: f6c73b0136d6b20eea9132a7d99a4d4f75232a71
Proposed branch: ~barryprice/charm-canonical-livepatch/+git/canonical-livepatch-charm:master
Merge into: ~livepatch-charmers/charm-canonical-livepatch:master
Diff against target: 20 lines (+5/-1)
1 file modified
README.md (+5/-1)
Reviewer Review Type Date Requested Status
Gareth Woolridge Approve
Review via email: mp+348746@code.launchpad.net

Commit message

Documentation update

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Gareth Woolridge (moon127) wrote :

LGTM

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision f6c73b0136d6b20eea9132a7d99a4d4f75232a71

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/README.md b/README.md
2index 6c8562e..a5c94e4 100644
3--- a/README.md
4+++ b/README.md
5@@ -28,10 +28,14 @@ Or via juju config (Juju 2.x)
6
7 The livepatch_key setting must be configured in order for the software to function correctly - see above.
8
9-By default, the livepatch software will attempt to retrieve its patch data directly over the network. If you'd like to use an HTTPS web proxy for this traffic instead, you can set the livepatch_proxy value to the address of your proxy server.
10+By default, the livepatch software will attempt to retrieve its patch data directly over the network. If you'd like to use a proxy for this traffic instead, you can set the livepatch_proxy value to the address of your proxy server.
11
12 Likewise, if you need to use a proxy server to access the Snap Store, snap_proxy can also be set to the address of your proxy server.
13
14+Alternatively, if you've configured a proxy for all applications in your environment via juju model-config, the charm will detect this and automatically do the right thing. It'll use http-proxy or https-proxy if either are set, with the latter being preferred.
15+
16+If two different proxies are set via model config and charm config, the latter will be preferred.
17+
18 # Contact Information
19
20 This charm is maintained here, by the livepatch-charmers team:

Subscribers

People subscribed via source and target branches