Merge ~barryprice/apache2-charm/+git/apache2-charm:master into apache2-charm:master

Proposed by Barry Price
Status: Merged
Approved by: Barry Price
Approved revision: cbd19762faf9a1205631bde2768ddbcf50ecccee
Merged at revision: 97f148566e6256bc72e12d4acacdc73360afe3bd
Proposed branch: ~barryprice/apache2-charm/+git/apache2-charm:master
Merge into: apache2-charm:master
Diff against target: 14 lines (+3/-0)
1 file modified
hooks/install (+3/-0)
Reviewer Review Type Date Requested Status
Barry Price Approve
Paul Collins Approve
Canonical IS Reviewers Pending
Review via email: mp+404738@code.launchpad.net

Commit message

hooks/install: Run apt-get update before attempting to install packages

To post a comment you must log in.
Revision history for this message
Paul Collins (pjdc) wrote :

suggestion inline, otherwise lgtm

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Haw Loeung (hloeung) :
Revision history for this message
Haw Loeung (hloeung) :
Revision history for this message
Barry Price (barryprice) wrote :

Thanks guys, pushed a fix.

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 97f148566e6256bc72e12d4acacdc73360afe3bd

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/hooks/install b/hooks/install
2index 77de042..5bd0001 100755
3--- a/hooks/install
4+++ b/hooks/install
5@@ -5,6 +5,9 @@ set -eu
6 juju-log 'Invoking charm-pre-install hooks'
7 [ -d exec.d ] && ( for f in exec.d/*/charm-pre-install; do [ -x $f ] && /bin/sh -c "$f"; done )
8
9+juju-log 'Refreshing package lists'
10+apt-get update -qq
11+
12 DISTRIB_CODENAME=$(grep DISTRIB_CODENAME /etc/lsb-release | cut -d= -f2)
13 if [ "${DISTRIB_CODENAME}" = "focal" ]; then
14 juju-log 'Ensuring python2, python-apt and python-yaml are installed'

Subscribers

People subscribed via source and target branches

to all changes: