Merge lp:~barry/ubuntu/natty/compizconfig-python/bug-687419-2 into lp:ubuntu/natty/compizconfig-python

Proposed by Barry Warsaw
Status: Merged
Merge reported by: Sebastien Bacher
Merged at revision: not available
Proposed branch: lp:~barry/ubuntu/natty/compizconfig-python/bug-687419-2
Merge into: lp:ubuntu/natty/compizconfig-python
Diff against target: 39 lines (+11/-13)
2 files modified
debian/changelog (+10/-0)
debian/rules (+1/-13)
To merge this branch: bzr merge lp:~barry/ubuntu/natty/compizconfig-python/bug-687419-2
Reviewer Review Type Date Requested Status
Ubuntu branches Pending
Review via email: mp+46091@code.launchpad.net

This proposal supersedes a proposal from 2011-01-12.

Description of the change

Fixes the ftbfs by forcing the buildsystem to python_distutils. This ignores the Makefile, which is incorrect (python setup.py build does not support the --prefix argument), and isn't necessary anyway.

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks Barry, I've merged that but to lp:~compiz/compizconfig-python/ubuntu which is the vcs indicated in the control file and by apt-get source, closing the merge request by hand then, next time please check if there is a vcs defined for the source ;-)

Revision history for this message
Barry Warsaw (barry) wrote :

On Jan 21, 2011, at 04:16 PM, Sebastien Bacher wrote:

>Thanks Barry, I've merged that but to lp:~compiz/compizconfig-python/ubuntu
>which is the vcs indicated in the control file and by apt-get source, closing
>the merge request by hand then, next time please check if there is a vcs
>defined for the source ;-)

Thanks. Yes, this is something we should teach the UDD toolset about.
Thanks, I'll file a bug.

Revision history for this message
Barry Warsaw (barry) wrote :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2010-11-09 18:10:48 +0000
3+++ debian/changelog 2011-01-13 05:27:58 +0000
4@@ -1,3 +1,13 @@
5+compizconfig-python (0.9.2.1-0ubuntu2) natty; urgency=low
6+
7+ * debian/rules: Simplify, and force the buildsystem to
8+ python_distutils so that the Makefile is ignored. It isn't
9+ correct because 'python setup.py build' does not accept the
10+ --prefix option, and it isn't needed anyway because dh_python2
11+ does the right thing. (LP: #687419)
12+
13+ -- Barry Warsaw <barry@ubuntu.com> Thu, 13 Jan 2011 00:19:16 -0500
14+
15 compizconfig-python (0.9.2.1-0ubuntu1) natty; urgency=low
16
17 * New upstream release
18
19=== modified file 'debian/rules'
20--- debian/rules 2010-11-09 18:10:48 +0000
21+++ debian/rules 2011-01-13 05:27:58 +0000
22@@ -3,16 +3,4 @@
23 DESTDIR=$(CURDIR)/debian/python-compizconfig
24
25 %:
26- dh $@ --with python2
27-
28-override_dh_clean:
29- dh_clean
30- rm -f installed_files src/compizconfig.c
31-
32-override_dh_auto_build:
33- echo "skip"
34-
35-override_dh_auto_install:
36- python setup.py install --root=$(DESTDIR) --prefix=/usr --install-lib=/usr/lib/python2.6/dist-packages
37- python setup.py install --root=$(DESTDIR) --prefix=/usr --install-lib=/usr/lib/python2.7/dist-packages
38-
39+ dh $@ --with python2 --buildsystem python_distutils

Subscribers

People subscribed via source and target branches

to all changes: