Merge lp:~barry/ubuntu/maverick/computer-janitor/bug-665740 into lp:ubuntu/maverick/computer-janitor

[Barry Warsaw]

Adds explicit dependency on dbus, since depending on python-dbus does not implicitly add the required dependency.

[Artur Rona (ari-tczew)]

Please remove ~ppa0 from debian/changelog.
I'd like to see rather added dbus under python-argparse (>= 1.1).

review: Needs Fixing

[lp:~barry/ubuntu/maverick/computer-janitor/bug-665740]

22. By Barry Warsaw on 2011-01-19

Remove ~ppa prefix for test build.

[Artur Rona (ari-tczew)]

Change target to maverick-proposed in debian/changelog. However, my 2nd suggestion from my 1st comment wasn't applied.

review: Needs Fixing

[Barry Warsaw (barry)]

Done, but, wouldn't it make more sense for the dbus requirement to appear next to the python-dbus requirement?

[lp:~barry/ubuntu/maverick/computer-janitor/bug-665740]

23. By Barry Warsaw on 2011-01-20

maverick-proposed

[Artur Rona (ari-tczew)]

It doesn't matter. For me looks fine. Now is core-dev turn.

review: Approve

[Barry Warsaw (barry)]

Thanks for the review Artur!

[Colin Watson (cjwatson)]

review: Approve

=== modified file 'debian/changelog'
--- debian/changelog	2010-09-20 08:32:14 +0000
+++ debian/changelog	2011-01-20 00:29:04 +0000
@@ -1,3 +1,10 @@
+computer-janitor (2.0.4-0ubuntu1.1) maverick-proposed; urgency=low
+
+  * debian/control: Add explicit dependency on dbus since depending on
+    python-dbus does not yield an implicit dependency on dbus.  (LP: #665740)
+
+ -- Barry Warsaw <[e-mail]>  Wed, 19 Jan 2011 19:25:57 -0500
+
 computer-janitor (2.0.4-0ubuntu1) maverick; urgency=low
 
   * Fix icon; given by Pavol Klačanský. (LP: #434431)

=== modified file 'debian/control'
--- debian/control	2010-09-20 08:32:14 +0000
+++ debian/control	2011-01-20 00:29:04 +0000
@@ -13,7 +13,7 @@
 Package: computer-janitor
 Architecture: all
 Depends: ${python:Depends}, python-apt (>= 0.7.9),
-    update-manager-core (>= 1:0.98.1), ${misc:Depends}, python-dbus, 
+    update-manager-core (>= 1:0.98.1), ${misc:Depends}, python-dbus, dbus,
     python-argparse (>= 1.1)
 Conflicts: system-cleaner
 Replaces: system-cleaner