Merge lp:~barry/ubuntu-archive-tools/exit-status into lp:ubuntu-archive-tools

[Barry Warsaw]

When the source can't be found, print the exception and continue unless the new option --fail-immediately is given, in which case False is returned to force a non-zero exit status.

[lp:~barry/ubuntu-archive-tools/exit-status]

970. By Barry Warsaw on 2015-08-07

Improve the error handling, and restore the sense that if the package is
missing, exit with status 1. Change --fail-immediately to --skip-missing
which ignores any missing packages and exits with status 0.

971. By Barry Warsaw on 2015-08-07

Always print the error.

[Adam Conrad (adconrad)]

LGTM:

(base)adconrad@nosferatu:~/build/ubuntu-archive-tools$ copy-package --from=ppa:adconrad/ubuntu/ppa --to=ppa:adconrad/ubuntu/ppa -s trusty gerbafl
Copy candidates:
Could not find source 'gerbafl/None' in trusty
(base)adconrad@nosferatu:~/build/ubuntu-archive-tools$ echo $?
1
(base)adconrad@nosferatu:~/build/ubuntu-archive-tools$ copy-package --from=ppa:adconrad/ubuntu/ppa --to=ppa:adconrad/ubuntu/ppa --skip-missing -s trusty gerbafl
Copy candidates:
Could not find source 'gerbafl/None' in trusty
Skipping
(base)adconrad@nosferatu:~/build/ubuntu-archive-tools$ echo $?
0

review: Approve

=== modified file 'copy-package'
--- copy-package	2014-11-12 14:37:16 +0000
+++ copy-package	2015-08-07 21:43:05 +0000
@@ -48,7 +48,16 @@
     for package in packages:
         print("Copy candidates:")
 
-        source = lputils.find_latest_published_source(options, package)
+        try:
+            source = lputils.find_latest_published_source(options, package)
+        except lputils.PackageMissing as error:
+            print(error)
+            if options.skip_missing:
+                print('Skipping')
+                continue
+            else:
+                # Bail with exit code non-zero.
+                return False
         print("\t%s" % source.display_name)
         num_copies = 1
 
@@ -154,6 +163,12 @@
         help=(
             "force copy when source == destination (e.g. when reverting to "
             "a previous version in the same suite)"))
+    parser.add_option(
+        "--skip-missing", default=False, action="store_true",
+        help=(
+            "When a package cannot be copied, normally this script exits "
+            "with a non-zero status.  With --skip-missing instead, the "
+            "error is printed and copying continues"))
     options, args = parser.parse_args()
 
     options.launchpad = Launchpad.login_with(