Merge lp:~barry/pyliblzma/594919-link into lp:pyliblzma

Proposed by Barry Warsaw
Status: Needs review
Proposed branch: lp:~barry/pyliblzma/594919-link
Merge into: lp:pyliblzma
Diff against target: 10 lines (+1/-0)
1 file modified
setup.py (+1/-0)
To merge this branch: bzr merge lp:~barry/pyliblzma/594919-link
Reviewer Review Type Date Requested Status
Stefano Rivera (community) Disapprove
Per Øyvind Karlsen Pending
Review via email: mp+43574@code.launchpad.net

Description of the change

Stefano Rivera's patch for fixing the linkage against Python 2.7.

To post a comment you must log in.
Revision history for this message
Stefano Rivera (stefanor) wrote :

This was a bug in the way Debian & Ubuntu were building python2.7: http://bugs.debian.org/614627

review: Disapprove

Unmerged revisions

498. By Barry Warsaw

Stefano Rivera's patch to link against libpythonX.Y. This is required
to have a successful build against Python 2.7, and doesn't hurt for
Python 2.6.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'setup.py'
2--- setup.py 2010-08-30 15:21:10 +0000
3+++ setup.py 2010-12-13 20:54:44 +0000
4@@ -67,6 +67,7 @@
5 pc_libs = str(pc_libs).split(' ')
6 pc_libs.remove(str('-llzma'))
7 link_args.extend(pc_libs)
8+link_args.append('-lpython%i.%i' % sys.version_info[:2])
9
10 extens=[Extension('lzma', c_files, extra_compile_args=compile_args, libraries=libraries, extra_link_args=link_args, define_macros=version_define)]
11

Subscribers

People subscribed via source and target branches