lp:~barry/mailman/subpolicy-2

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:mailman at revision 7317

Abhilash Raj: Pending requested 2015-04-15

Aurélien Bompard: Pending requested 2015-03-29

Diff: 3741 lines (+2130/-750)

46 files modified

TODO.rst (+10/-0)
src/mailman/app/docs/moderator.rst (+0/-1)
src/mailman/app/registrar.py (+33/-99)
src/mailman/app/subscriptions.py (+269/-7)
src/mailman/app/tests/test_registrar.py (+170/-91)
src/mailman/app/tests/test_subscriptions.py (+515/-2)
src/mailman/app/tests/test_workflow.py (+128/-0)
src/mailman/app/workflow.py (+156/-0)
src/mailman/commands/docs/membership.rst (+12/-38)
src/mailman/commands/eml_confirm.py (+5/-2)
src/mailman/commands/eml_membership.py (+36/-14)
src/mailman/commands/tests/test_confirm.py (+5/-6)
src/mailman/config/configure.zcml (+11/-5)
src/mailman/database/alembic/versions/16c2b25c7b_list_subscription_policy.py (+41/-0)
src/mailman/database/alembic/versions/2bb9b382198_workflow_state_table.py (+28/-0)
src/mailman/database/transaction.py (+17/-0)
src/mailman/interfaces/mailinglist.py (+16/-0)
src/mailman/interfaces/member.py (+9/-1)
src/mailman/interfaces/pending.py (+5/-2)
src/mailman/interfaces/registrar.py (+48/-52)
src/mailman/interfaces/roster.py (+18/-3)
src/mailman/interfaces/workflow.py (+80/-0)
src/mailman/model/docs/membership.rst (+36/-2)
src/mailman/model/docs/pending.rst (+10/-0)
src/mailman/model/docs/registration.rst (+80/-323)
src/mailman/model/mailinglist.py (+2/-1)
src/mailman/model/member.py (+4/-0)
src/mailman/model/pending.py (+5/-1)
src/mailman/model/roster.py (+50/-14)
src/mailman/model/tests/test_registrar.py (+0/-64)
src/mailman/model/tests/test_roster.py (+51/-1)
src/mailman/model/tests/test_usermanager.py (+5/-0)
src/mailman/model/tests/test_workflow.py (+148/-0)
src/mailman/model/usermanager.py (+0/-1)
src/mailman/model/workflow.py (+76/-0)
src/mailman/rest/docs/listconf.rst (+3/-0)
src/mailman/rest/listconf.py (+3/-1)
src/mailman/rest/tests/test_listconf.py (+1/-0)
src/mailman/runners/docs/command.rst (+3/-4)
src/mailman/runners/tests/test_confirm.py (+2/-2)
src/mailman/runners/tests/test_join.py (+6/-2)
src/mailman/styles/base.py (+3/-1)
src/mailman/templates/en/confirm.txt (+1/-3)
src/mailman/templates/en/subauth.txt (+0/-6)
src/mailman/utilities/importer.py (+3/-0)
src/mailman/utilities/tests/test_import.py (+26/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

7341. By Barry Warsaw on 2015-04-15

Prevent replay attacks with the confirmation token.

7340. By Barry Warsaw on 2015-04-14

Update TODO.

7339. By Barry Warsaw on 2015-04-14

Remove unused import.

7338. By Barry Warsaw on 2015-04-14

Full test suite passes.

* Make sure Registrar.discard() removces any workflow state manager state
  associated with the token, and that this is flushed to SA.

* Adjust the email commands to the new IRegistrar API.

* Update the IRegistrar interface.

* Add IWorkflowStateManager.discard() and make `count` an attribute/property.

* Mark two tests as expected failures due to LP: #1444184.

7337. By Barry Warsaw on 2015-04-14

Merge the member query fix branch.

7336. By Barry Warsaw on 2015-04-14

Checkpointing.

7335. By Barry Warsaw on 2015-04-13

The SubscriptionWorkflow class doesn't need to include the expiry date in its
pendable data since that gets added automatically by the IPendings utility.

After the user is subscribed, clean up the saved workflows and reset the token
to None.

Give the SubscriptionWorkflow a name property for convenience.

7334. By Barry Warsaw on 2015-04-13

* Give the workflow state manager a count method.
* The workflow state manager no longer allows updates via .save().
* Restoring a workflow state evicts the record from the database.

7333. By Barry Warsaw on 2015-04-13

Give IPendings a count of entries.

7332. By Barry Warsaw on 2015-04-13

SubscriptionPolicy is largely done, modulo bugs, and the unknown-unknown of
course. This commit contains test failures because the next step is to hook
everything up.

Changes here include:

 * confirm.txt removes the URL since we can't know that.
 * Changes to the ConfirmationNeededEvent
 * Create the Pendable early in the workflow.
 * Clean up test.
 * Update IRegistrar docstring.