-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Nov 30, 2008, at 01:22 AM, Mark Sapiro wrote: >Vote: Abstain code >So far, I've just eyeballed the diffs, but they look good with one exception. In configure.in, minimum Python version should be 2.4 as the sibling lists feature in CalcRecips.py uses sets. > >Also, paths.py.in suppressed the string exception warning for python 2.5 with > > # Supress Python 2.5 warning about string exceptions. > filterwarnings('ignore', '.* string exception', DeprecationWarning) > >which can now be removed. > >I still intend to do an actual build of the branch and test it. Cool, thanks for the comments. I've pushed an update to the branch, and here is the incremental diff. It includes some autoconf cleanups. - -Barry === modified file 'configure' - --- configure 2008-11-04 02:25:20 +0000 +++ configure 2008-11-30 17:07:11 +0000 @@ -1,10 +1,10 @@ #! /bin/sh # From configure.in Revision: 8122 . # Guess values for system-dependent variables and create Makefiles. - -# Generated by GNU Autoconf 2.62. +# Generated by GNU Autoconf 2.61. # # Copyright (C) 1992, 1993, 1994, 1995, 1996, 1998, 1999, 2000, 2001, - -# 2002, 2003, 2004, 2005, 2006, 2007, 2008 Free Software Foundation, Inc. +# 2002, 2003, 2004, 2005, 2006 Free Software Foundation, Inc. # This configure script is free software; the Free Software Foundation # gives unlimited permission to copy, distribute and modify it. ## --------------------- ## @@ -16,7 +16,7 @@ if test -n "${ZSH_VERSION+set}" && (emulate sh) >/dev/null 2>&1; then emulate sh NULLCMD=: - - # Pre-4.2 versions of Zsh do word splitting on ${1+"$@"}, which + # Zsh 3.x and 4.x performs word splitting on ${1+"$@"}, which # is contrary to our usage. Disable this feature. alias -g '${1+"$@"}'='"$@"' setopt NO_GLOB_SUBST @@ -38,45 +38,17 @@ as_cr_digits='0123456789' as_cr_alnum=$as_cr_Letters$as_cr_digits - -as_nl=' - -' - -export as_nl - -# Printing a long string crashes Solaris 7 /usr/bin/printf. - -as_echo='\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\' - -as_echo=$as_echo$as_echo$as_echo$as_echo$as_echo - -as_echo=$as_echo$as_echo$as_echo$as_echo$as_echo$as_echo - -if (test "X`printf %s $as_echo`" = "X$as_echo") 2>/dev/null; then - - as_echo='printf %s\n' - - as_echo_n='printf %s' - -else - - if test "X`(/usr/ucb/echo -n -n $as_echo) 2>/dev/null`" = "X-n $as_echo"; then - - as_echo_body='eval /usr/ucb/echo -n "$1$as_nl"' - - as_echo_n='/usr/ucb/echo -n' - - else - - as_echo_body='eval expr "X$1" : "X\\(.*\\)"' - - as_echo_n_body='eval - - arg=$1; - - case $arg in - - *"$as_nl"*) - - expr "X$arg" : "X\\(.*\\)$as_nl"; - - arg=`expr "X$arg" : ".*$as_nl\\(.*\\)"`;; - - esac; - - expr "X$arg" : "X\\(.*\\)" | tr -d "$as_nl" - - ' - - export as_echo_n_body - - as_echo_n='sh -c $as_echo_n_body as_echo' - - fi - - export as_echo_body - - as_echo='sh -c $as_echo_body as_echo' - -fi - - # The user is always right. if test "${PATH_SEPARATOR+set}" != set; then - - PATH_SEPARATOR=: - - (PATH='/bin;/bin'; FPATH=$PATH; sh -c :) >/dev/null 2>&1 && { - - (PATH='/bin:/bin'; FPATH=$PATH; sh -c :) >/dev/null 2>&1 || - - PATH_SEPARATOR=';' - - } + echo "#! /bin/sh" >conf$$.sh + echo "exit 0" >>conf$$.sh + chmod +x conf$$.sh + if (PATH="/nonexistent;."; conf$$.sh) >/dev/null 2>&1; then + PATH_SEPARATOR=';' + else + PATH_SEPARATOR=: + fi + rm -f conf$$.sh fi # Support unset when possible. @@ -92,6 +64,8 @@ # there to prevent editors from complaining about space-tab. # (If _AS_PATH_WALK were called with IFS unset, it would disable word # splitting by setting IFS to empty value.) +as_nl=' +' IFS=" "" $as_nl" # Find who we are. Look in the path if we contain no directory separator. @@ -114,7 +88,7 @@ as_myself=$0 fi if test ! -f "$as_myself"; then - - $as_echo "$as_myself: error: cannot find myself; rerun with an absolute file name" >&2 + echo "$as_myself: error: cannot find myself; rerun with an absolute file name" >&2 { (exit 1); exit 1; } fi @@ -127,10 +101,17 @@ PS4='+ ' # NLS nuisances. - -LC_ALL=C - -export LC_ALL - -LANGUAGE=C - -export LANGUAGE +for as_var in \ + LANG LANGUAGE LC_ADDRESS LC_ALL LC_COLLATE LC_CTYPE LC_IDENTIFICATION \ + LC_MEASUREMENT LC_MESSAGES LC_MONETARY LC_NAME LC_NUMERIC LC_PAPER \ + LC_TELEPHONE LC_TIME +do + if (set +x; test -z "`(eval $as_var=C; export $as_var) 2>&1`"); then + eval $as_var=C; export $as_var + else + ($as_unset $as_var) >/dev/null 2>&1 && $as_unset $as_var + fi +done # Required to use basename. if expr a : '\(a\)' >/dev/null 2>&1 && @@ -152,7 +133,7 @@ $as_expr X/"$0" : '.*/\([^/][^/]*\)/*$' \| \ X"$0" : 'X\(//\)$' \| \ X"$0" : 'X\(/\)' \| . 2>/dev/null || - -$as_echo X/"$0" | +echo X/"$0" | sed '/^.*\/\([^/][^/]*\)\/*$/{ s//\1/ q @@ -178,7 +159,7 @@ as_have_required=no fi - - if test $as_have_required = yes && (eval ": + if test $as_have_required = yes && (eval ": (as_func_return () { (exit \$1) } @@ -260,7 +241,7 @@ if test -n "${ZSH_VERSION+set}" && (emulate sh) >/dev/null 2>&1; then emulate sh NULLCMD=: - - # Pre-4.2 versions of Zsh do word splitting on ${1+"$@"}, which + # Zsh 3.x and 4.x performs word splitting on ${1+"$@"}, which # is contrary to our usage. Disable this feature. alias -g '${1+"$@"}'='"$@"' setopt NO_GLOB_SUBST @@ -281,7 +262,7 @@ if test -n "${ZSH_VERSION+set}" && (emulate sh) >/dev/null 2>&1; then emulate sh NULLCMD=: - - # Pre-4.2 versions of Zsh do word splitting on ${1+"$@"}, which + # Zsh 3.x and 4.x performs word splitting on ${1+"$@"}, which # is contrary to our usage. Disable this feature. alias -g '${1+"$@"}'='"$@"' setopt NO_GLOB_SUBST @@ -361,10 +342,10 @@ if test "x$CONFIG_SHELL" != x; then for as_var in BASH_ENV ENV - - do ($as_unset $as_var) >/dev/null 2>&1 && $as_unset $as_var - - done - - export CONFIG_SHELL - - exec "$CONFIG_SHELL" "$as_myself" ${1+"$@"} + do ($as_unset $as_var) >/dev/null 2>&1 && $as_unset $as_var + done + export CONFIG_SHELL + exec "$CONFIG_SHELL" "$as_myself" ${1+"$@"} fi @@ -433,10 +414,9 @@ test \$exitcode = 0") || { echo No shell found that supports shell functions. - - echo Please tell