Merge lp:~barry/launchpad/474269-actions into lp:launchpad

Proposed by Barry Warsaw
Status: Merged
Approved by: Barry Warsaw
Approved revision: no longer in the source branch.
Merged at revision: not available
Proposed branch: lp:~barry/launchpad/474269-actions
Merge into: lp:launchpad
Diff against target: 30 lines
1 file modified
lib/lp/registry/templates/person-edit.pt (+0/-20)
To merge this branch: bzr merge lp:~barry/launchpad/474269-actions
Reviewer Review Type Date Requested Status
Abel Deuring (community) code Approve
Review via email: mp+14440@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Barry Warsaw (barry) wrote :

= Summary =

Bug 474269 describes a ui clean up where the ~person/+edit page has an
extraneous menu at the bottom of the page. The menu contains

 * Set preferred languages
 * Update wiki names
 * Update IRC nicknames
 * Update Jabber IDs

As all are available for editing on the ~person's index page, this menu is no
longer needed.

== Proposed fix ==

Remove the template code that renders this menu.

== Pre-implementation notes ==

None.

== Implementation details ==

None.

== Tests ==

% bin/test -vv -t person

== Demo and Q/A ==

 * Login as admin
 * Visit http://launchpad.dev/~name12/+edit
 * Scroll to the bottom of the page; no menu

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/registry/templates/person-edit.pt

Revision history for this message
Abel Deuring (adeuring) :
review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/registry/templates/person-edit.pt'
2--- lib/lp/registry/templates/person-edit.pt 2009-09-17 18:48:15 +0000
3+++ lib/lp/registry/templates/person-edit.pt 2009-11-04 20:55:21 +0000
4@@ -17,26 +17,6 @@
5 replace="structure view/i_know_this_is_an_openid_security_issue_input|nothing" />
6 </metal:other_input>
7 </div>
8-
9- <h2 style="margin-top: 2em;">Other actions</h2>
10- <ul style="list-style-type:none; padding-left:1.5em;">
11- <li
12- tal:content="structure overview_menu/editlanguages/fmt:link-icon">
13- Set your preferred language
14- </li>
15- <li
16- tal:content="structure overview_menu/editwikinames/fmt:link-icon">
17- Edit your wiki names
18- </li>
19- <li
20- tal:content="structure overview_menu/editircnicknames/fmt:link-icon">
21- Edit your IRC contact names
22- </li>
23- <li
24- tal:content="structure overview_menu/editjabberids/fmt:link-icon">
25- Edit your Jabber contact names
26- </li>
27- </ul>
28 <p style="margin-top: 4em;">
29 Never going to use Launchpad again?
30 <a