Merge lp:~barry/launchpad/445713-cleanup into lp:launchpad

[Barry Warsaw]

[Barry Warsaw (barry)]

 reviewer rockstar code

= Summary =

This is a pure clean up branch as a follow on to
lp:~barry/launchpad/445713-menus. It cleans up some doctests.

== Proposed fix ==

Clean up doctests.

== Pre-implementation notes ==

None.

== Implementation details ==

These drive-by cleanups were developed in parallel with the above branch.

== Tests ==

None; tests will be described as part of the above branch.

== Demo and Q/A ==

None.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/registry/stories/product/xx-product-driver.txt
  lib/lp/registry/browser/tests/product-menus.txt
  lib/lp/registry/stories/product/xx-product-edit.txt

=== modified file 'lib/lp/registry/browser/tests/product-menus.txt'
--- lib/lp/registry/browser/tests/product-menus.txt	2009-08-12 04:27:34 +0000
+++ lib/lp/registry/browser/tests/product-menus.txt	2009-10-08 21:10:22 +0000
@@ -1,4 +1,6 @@
-= The product menu classes =
+========================
+The product menu classes
+========================
 
 Each link specified by menu classes for products should be accessible.
 In most cases, the context for links will be the product itself, which
@@ -7,11 +9,7 @@
 The check_menu_links() function is defined here to make it simple to
 test all the product menu classes below.
 
-    >>> import traceback
-    >>> import sys
-    >>> import os
     >>> from zope.component import getMultiAdapter
-    >>> from canonical.lazr.utils import safe_hasattr
     >>> from canonical.lazr.testing.menus import make_fake_request
     >>> from canonical.launchpad.webapp.publisher import canonical_url
     >>> from lp.registry.interfaces.product import IProductSet

=== modified file 'lib/lp/registry/stories/product/xx-product-driver.txt'
--- lib/lp/registry/stories/product/xx-product-driver.txt	2009-09-18 17:38:50 +0000
+++ lib/lp/registry/stories/product/xx-product-driver.txt	2009-10-08 21:10:22 +0000
@@ -1,3 +1,4 @@
+===========================
 Appointing a Product Driver
 ===========================
 

=== modified file 'lib/lp/registry/stories/product/xx-product-edit.txt'
--- lib/lp/registry/stories/product/xx-product-edit.txt	2009-09-23 10:17:34 +0000
+++ lib/lp/registry/stories/product/xx-product-edit.txt	2009-10-08 21:10:22 +0000
@@ -1,3 +1,4 @@
+===========================
 Product Edit and Administer
 ===========================
 
@@ -72,7 +73,7 @@
 
 
 Administering Products
-----------------------
+======================
 
 Regular users can't access the 'Administer' link.
 
@@ -175,7 +176,7 @@
 
 
 Changing Maintainer and Registrant
-----------------------------------
+==================================
 
 Administrators can change the owner of a project.
 
@@ -222,7 +223,7 @@
 
 
 Registry Experts
-----------------
+================
 
 Regular Joes can't edit any old project:
 
@@ -272,7 +273,7 @@
 
 
 Launchpad developers can use the reviewer whiteboard
-----------------------------------------------------
+====================================================
 
 A member of the Registry Experts team can use the reviewer whiteboard on
 the +review-license page for storing random notes about a project. At
@@ -379,7 +380,7 @@
 
 
 Setting the remote project
---------------------------
+==========================
 
 The remote_product field - which stores a Product's ID on the remote bug
 tracker - can be set from the +edit page, too.