Merge lp:~barry/launchpad/440220-slot into lp:launchpad

[Barry Warsaw]

[Barry Warsaw (barry)]

 reviewer adeuring code
 reviewer michael.nelson ui
 reviewer rockstar ui

= Summary =

Bug 440220 describes an annoying problem with the interaction between the
registering slot and the application tabs. The registering slot is where
information, such as who reported a bug and when, goes. The app tabs are the
"Overview, Branches..." facet links that appear at the top of the page.

If the registering slot contents are long, they'll overrun the tabs and cause
them to wrap.

== Proposed fix ==

Tweak the CSS to nowrap the app tabs, and bump the registering slot down a bit
so even long contents won't overrun the tabs.

== Pre-implementation notes ==

None too much, though I had several discussions with Michael and Paul tweaking
the specifics of the ui changes.

== Implementation details ==

The only implementation detail of note is that I had to add a CSS class called
'facetmenu' to the <ul> which contains the app tabs. Then I was able to apply
a white-space: nowrap to that class.

== Tests ==

None, this is only a visible change.

== Demo and Q/A ==

In various browsers with windows of various widths, visit these pages:

 * https://bugs.launchpad.dev/firefox/+bug/1
 * https://bugs.launchpad.dev/firefox

You can also try changing name12's display name to something insanely long and
visit the same pages to see that they still look good.

These are captured in screenshots on the bug report. The images in comments
13 through 16 are from the changes under review:

 * http://launchpadlibrarian.net/32863199/ff-2em.png
 * http://launchpadlibrarian.net/32863206/ff-bug-2em.png
 * http://launchpadlibrarian.net/32863216/opera-ff-2em.png
 * http://launchpadlibrarian.net/32863217/opera-ff-bug-2em.png

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/app/templates/base-layout-macros.pt
  lib/canonical/launchpad/icing/style-3-0.css

[Abel Deuring (adeuring)]

review: Approve (code)

[Michael Nelson (michael.nelson)]

See comment on the bug:
https://bugs.edge.launchpad.net/launchpad-registry/+bug/440220/comments/17

Thanks Barry!

review: Approve (ui)

[Paul Hummer (rockstar)]

review: Approve (ui)

=== modified file 'lib/canonical/launchpad/icing/style-3-0.css'
--- lib/canonical/launchpad/icing/style-3-0.css	2009-09-28 13:56:17 +0000
+++ lib/canonical/launchpad/icing/style-3-0.css	2009-10-02 14:20:28 +0000
@@ -543,12 +543,18 @@
     color: #747474;
 }
 
+/* Facet menu, a.k.a. application tabs */
+.facetmenu {
+    width: 100%;
+    white-space: nowrap;
+}
 /* Registering slot */
 .registering {
     float: right;
-    padding-top: 10px;
     font-size: 85%;
     color: #666;
+    position: relative;
+    top: 2em;
 }
 
 /* Side content exceptions */

=== modified file 'lib/lp/app/templates/base-layout-macros.pt'
--- lib/lp/app/templates/base-layout-macros.pt	2009-10-01 11:00:04 +0000
+++ lib/lp/app/templates/base-layout-macros.pt	2009-10-02 14:20:28 +0000
@@ -300,8 +300,8 @@
 
 <metal:application-buttons define-macro="application-buttons">
   <!-- Application Menu -->
-  <ul
-    tal:define="facetmenu view/menu:facet">
+  <ul class="facetmenu"
+      tal:define="facetmenu view/menu:facet">
     <tal:facet repeat="link facetmenu">
       <li
         tal:condition="python: link.enabled and link.selected"