Merge lp:~barry/launchpad/436261-style into lp:launchpad

Proposed by Barry Warsaw
Status: Merged
Merged at revision: not available
Proposed branch: lp:~barry/launchpad/436261-style
Merge into: lp:launchpad
Diff against target: 12 lines
1 file modified
lib/lp/registry/templates/teammembership-listing-simple.pt (+1/-1)
To merge this branch: bzr merge lp:~barry/launchpad/436261-style
Reviewer Review Type Date Requested Status
Aaron Bentley (community) Approve
Review via email: mp+13972@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Barry Warsaw (barry) wrote :

 reviewer abentley

= Summary =

Bug 436261 describes a minor ui glitch that's easily cleaned up. In a
person's "Latest memberships", the date joined should be rendered in a
"registered" class.

== Proposed fix ==

Change the class on the div as per bug report.

== Pre-implementation notes ==

None.

== Implementation details ==

None.

== Tests ==

None.

== Demo and Q/A ==

Visit http://launchpad.dev/~name12 and observe the style of the dates in the
Latest membership section.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/registry/templates/teammembership-listing-simple.pt

Revision history for this message
Aaron Bentley (abentley) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 review approve

Simple enough

Barry Warsaw wrote:
> Barry Warsaw has proposed merging lp:~barry/launchpad/436261-style into lp:launchpad/devel.
>
> Requested reviews:
> Aaron Bentley (abentley)
> Related bugs:
> #436261 The latest memberships portlet uses the wrong style
> https://bugs.launchpad.net/bugs/436261
>
>
> reviewer abentley
>
> = Summary =
>
> Bug 436261 describes a minor ui glitch that's easily cleaned up. In a
> person's "Latest memberships", the date joined should be rendered in a
> "registered" class.
>
>
> == Proposed fix ==
>
> Change the class on the div as per bug report.
>
>
> == Pre-implementation notes ==
>
> None.
>
>
> == Implementation details ==
>
> None.
>
>
> == Tests ==
>
> None.
>
>
> == Demo and Q/A ==
>
> Visit http://launchpad.dev/~name12 and observe the style of the dates in the
> Latest membership section.
>
>
> = Launchpad lint =
>
> Checking for conflicts. and issues in doctests and templates.
> Running jslint, xmllint, pyflakes, and pylint.
> Using normal rules.
>
> Linting changed files:
> lib/lp/registry/templates/teammembership-listing-simple.pt
>
>
>
>

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkrl5B4ACgkQ0F+nu1YWqI3r2wCeO7UikkV9S/n4uZqYKGomHwBo
/FsAn0AbBikrm1gmqxHDpdfRCq7o60TD
=X58N
-----END PGP SIGNATURE-----

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/registry/templates/teammembership-listing-simple.pt'
2--- lib/lp/registry/templates/teammembership-listing-simple.pt 2009-09-11 17:13:09 +0000
3+++ lib/lp/registry/templates/teammembership-listing-simple.pt 2009-10-26 17:45:23 +0000
4@@ -9,7 +9,7 @@
5 <div>
6 <a tal:replace="structure context/team/fmt:link">Team name</a>
7 </div>
8- <div class="extra-discreet">
9+ <div class="registered">
10 Joined
11 <span
12 tal:attributes="title context/datejoined/fmt:datetime"