Barry Warsaw wrote:
>> As long as you've tested it manually, looks good to me.
>
> Thanks! Aaron suggested in IRC that I pass the from address in the _get_compose_commandline() call instead of grabbing it from the user's config. He also suggested I override ExternalMailClient.compose to "inject the configured from address", and also add tests.
>
> I don't know, nor would be able to test, setting the From header in other clients.
Let's assume for the moment that no other client supports it. It's
certainly true that neither Thunderbird nor xdg-email supports it, and
initial tests with Evolution aren't promising.
I'm just sayin' _get_compose_commandline should stay true to its roots,
and just turn its input into a commandline. This also makes testing the
"from" formatting simpler.
> I know the code in the branch works for Claws though. What do you think of Aaron's suggestions?
Anyhow, "bzr selftest Claws" fails, so this branch Needs Fixing.
review needs-fixing
Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Barry Warsaw wrote: commandline( ) call instead of grabbing it from the user's config. He also suggested I override ExternalMailCli ent.compose to "inject the configured from address", and also add tests.
>> As long as you've tested it manually, looks good to me.
>
> Thanks! Aaron suggested in IRC that I pass the from address in the _get_compose_
>
> I don't know, nor would be able to test, setting the From header in other clients.
Let's assume for the moment that no other client supports it. It's
certainly true that neither Thunderbird nor xdg-email supports it, and
initial tests with Evolution aren't promising.
I'm just sayin' _get_compose_ commandline should stay true to its roots,
and just turn its input into a commandline. This also makes testing the
"from" formatting simpler.
> I know the code in the branch works for Claws though. What do you think of Aaron's suggestions?
Anyhow, "bzr selftest Claws" fails, so this branch Needs Fixing.
review needs-fixing
Aaron enigmail. mozdev. org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://
iEYEARECAAYFAko m5p0ACgkQ0F+ nu1YWqI03hACeJi E2na0t/ 3JEsfOInHwfRLJi n0uhOEcSxiE7L0Q IH
VI8An3VgTCyyTOO
=mb8c
-----END PGP SIGNATURE-----