> As long as you've tested it manually, looks good to me.
Thanks! Aaron suggested in IRC that I pass the from address in the _get_compose_commandline() call instead of grabbing it from the user's config. He also suggested I override ExternalMailClient.compose to "inject the configured from address", and also add tests.
I don't know, nor would be able to test, setting the From header in other clients. I know the code in the branch works for Claws though. What do you think of Aaron's suggestions?
> As long as you've tested it manually, looks good to me.
Thanks! Aaron suggested in IRC that I pass the from address in the _get_compose_ commandline( ) call instead of grabbing it from the user's config. He also suggested I override ExternalMailCli ent.compose to "inject the configured from address", and also add tests.
I don't know, nor would be able to test, setting the From header in other clients. I know the code in the branch works for Claws though. What do you think of Aaron's suggestions?