Merge lp:~barry/aptdaemon/pep8-fixes into lp:aptdaemon
Status: | Needs review |
---|---|
Proposed branch: | lp:~barry/aptdaemon/pep8-fixes |
Merge into: | lp:aptdaemon |
Diff against target: |
25 lines (+2/-4) 2 files modified
aptdaemon/__init__.py (+1/-1) aptdaemon/gtkwidgets.py (+1/-3) |
To merge this branch: | bzr merge lp:~barry/aptdaemon/pep8-fixes |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Sebastian Heinlein | Pending | ||
Review via email: mp+152743@code.launchpad.net |
Description of the change
PEP 8 fixes.
Before:
% pep8 --statistics --show-source --show-pep8 --exclude pkenums.py aptdaemon tests
aptdaemon/
__version__ = '1.0'
^
Avoid extraneous whitespace in the following situations:
- More than one space around an assignment (or other) operator to
align it with another.
Okay: a = 12 + 3
E221: a = 4 + 5
E222: a = 4 + 5
E223: a = 4\t+ 5
E224: a = 4 +\t5
aptdaemon/
Don't use spaces around the '=' sign when used to indicate a
keyword argument or a default parameter value.
Okay: def complex(real, imag=0.0):
Okay: return magic(r=real, i=imag)
Okay: boolean(a == b)
Okay: boolean(a != b)
Okay: boolean(a <= b)
Okay: boolean(a >= b)
E251: def complex(real, imag = 0.0):
E251: return magic(r = real, i = imag)
aptdaemon/
Don't use spaces around the '=' sign when used to indicate a
keyword argument or a default parameter value.
Okay: def complex(real, imag=0.0):
Okay: return magic(r=real, i=imag)
Okay: boolean(a == b)
Okay: boolean(a != b)
Okay: boolean(a <= b)
Okay: boolean(a >= b)
E251: def complex(real, imag = 0.0):
E251: return magic(r = real, i = imag)
aptdaemon/
^
JCR: Trailing blank lines are superfluous.
Okay: spam(1)
W391: spam(1)\n
1 E222 multiple spaces after operator
2 E251 no spaces around keyword / parameter equals
1 W391 blank line at end of file
After:
% pep8 --statistics --show-source --show-pep8 --exclude pkenums.py aptdaemon tests
%
Unmerged revisions
- 903. By Barry Warsaw
-
PEP 8 fixes.