Ubuntu Online Tour - OBSOLETE

Merge lp:~barry-mcgee/ubuntu-online-tour/download-link into lp:ubuntu-online-tour/14.04

  1. download-link
  2. Merge into 14.04
Proposed by Barry McGee
Status: Merged
Approved by: Anthony Dillon
Approved revision: 190
Merged at revision: 190
Proposed branch: lp:~barry-mcgee/ubuntu-online-tour/download-link
Merge into: lp:ubuntu-online-tour/14.04
Diff against target: 39 lines (+13/-1)
2 files modified
en/index.html (+9/-1)
js/lang.js (+4/-0)
To merge this branch: bzr merge lp:~barry-mcgee/ubuntu-online-tour/download-link
Reviewer Review Type Date Requested Status
Anthony Dillon Approve
Review via email: mp+281771@code.launchpad.net

Description of the change

Add mechanism to allow "Download Ubuntu" call-to-action translatable.

To post a comment you must log in.
Revision history for this message
Anthony Dillon (ya-bo-ng) wrote :

LGTM +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'en/index.html'
2--- en/index.html 2016-01-05 11:38:05 +0000
3+++ en/index.html 2016-01-06 17:08:01 +0000
4@@ -408,7 +408,9 @@
5 </div>
6 <div class="error-container">
7 <h1>Thanks for exploring Ubuntu!</h1>
8- <a class="download" href="http://www.ubuntu.com/download/ubuntu/download?utm_source=tour&utm_medium=online&utm_campaign=tour" target="_blank">Download Ubuntu</a>
9+ <a class="download" href="http://www.ubuntu.com/download/ubuntu/download?utm_source=tour&utm_medium=online&utm_campaign=tour" target="_blank">
10+ Download Ubuntu
11+ </a>
12 <h2>Remember, this is just a demo. You'll have to download it to enjoy the real thing!</h2>
13 </div>
14 </div>
15@@ -1485,6 +1487,12 @@
16 <p class="_music_date_">
17 Weds 14 October, 2010
18 </p>
19+ <!--
20+ Error Container
21+ -->
22+ <p class="_download_cta_">
23+ Download Ubuntu
24+ </p>
25 </div>
26 <script type="text/javascript" src="../js/jquery.min.js"></script>
27 <script type="text/javascript" src="../js/jquery-ui.min.js"></script>
28
29=== modified file 'js/lang.js'
30--- js/lang.js 2016-01-04 12:21:53 +0000
31+++ js/lang.js 2016-01-06 17:08:01 +0000
32@@ -147,4 +147,8 @@
33 var _Happiness_title_ = $.trim(hiddenTranslation.find('._Happiness_title_').text());
34 var _music_size_ = $.trim(hiddenTranslation.find('._music_size_').text());
35 var _music_date_ = $.trim(hiddenTranslation.find('._music_date_').text());
36+/*
37+ * Error Container
38+ */
39+ var _download_cta_ = $.trim(hiddenTranslation.find('._download_cta_').text());
40

Subscribers

People subscribed via source and target branches