Ubuntu Brand Guidelines website

Merge lp:~barry-mcgee/ubuntu-brand-guidelines/function-error into lp:ubuntu-brand-guidelines

  1. function-error
  2. Merge into trunk
Proposed by Barry McGee
Status: Merged
Approved by: Anthony Dillon
Approved revision: 48
Merged at revision: 49
Proposed branch: lp:~barry-mcgee/ubuntu-brand-guidelines/function-error
Merge into: lp:ubuntu-brand-guidelines
Diff against target: 22 lines (+3/-3)
1 file modified
functions.php (+3/-3)
To merge this branch: bzr merge lp:~barry-mcgee/ubuntu-brand-guidelines/function-error
Reviewer Review Type Date Requested Status
Anthony Dillon Approve
Review via email: mp+283792@code.launchpad.net

Description of the change

## Done

Replaced deprecated "split()" function with "explode()"

## QA

Navigate to `/downloads` and ensure that each file download has the correct filesize underneath it.

To post a comment you must log in.
Revision history for this message
Anthony Dillon (ya-bo-ng) wrote :

LGTM +1 no QA

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'functions.php'
2--- functions.php 2014-10-21 16:38:46 +0000
3+++ functions.php 2016-01-25 12:20:18 +0000
4@@ -107,9 +107,9 @@
5 }
6
7 function getPostAttachmentExtension($mime_type) {
8- $split = split('/', $mime_type);
9+ $explode = explode('/', $mime_type);
10
11- return '.' . $split[1];
12+ return '.' . $explode[1];
13 }
14
15 function getPostAttachmentFilesize($file, $digits = 1) {
16@@ -128,4 +128,4 @@
17 remove_filter('the_content', 'wpautop');
18 }
19
20-?>
21\ No newline at end of file
22+?>

Subscribers

People subscribed via source and target branches