Merge lp:~baltix/ubuntu/precise/app-install-data-partner/fix-for-missing-applications-flashplugin-skype into lp:ubuntu/precise/app-install-data-partner

Proposed by Mantas Kriaučiūnas
Status: Work in progress
Proposed branch: lp:~baltix/ubuntu/precise/app-install-data-partner/fix-for-missing-applications-flashplugin-skype
Merge into: lp:ubuntu/precise/app-install-data-partner
Diff against target: 123 lines (+59/-5)
6 files modified
debian/changelog (+25/-0)
debian/control (+2/-1)
debian/install (+2/-2)
desktop/acroread.desktop (+14/-0)
desktop/flash10.desktop (+3/-2)
desktop/skype.desktop (+13/-0)
To merge this branch: bzr merge lp:~baltix/ubuntu/precise/app-install-data-partner/fix-for-missing-applications-flashplugin-skype
Reviewer Review Type Date Requested Status
Mathieu Trudel-Lapierre Needs Fixing
Ubuntu branches Pending
Review via email: mp+134402@code.launchpad.net

Description of the change

Please merge my fixes and improvements to app-install-data-partner package for Ubuntu 12.04 LTS, which is completely broken (empty) in 12.04 LTS release. I've fixed several important bugs, including:
Bug #1005209 - Package empty (no desktop files) High Triaged
Bug #875683 - software center tries to install adobe-flashplugin:i386 even if amd64 environment

Also I've fixed desktop/skype.desktop - changed Exec line to "Exec=skype" instead "Exec=skype-wrapper", this problem exists even in Ubuntu 12.10 branch ( lp:ubuntu/quantal-proposed/app-install-data-partner )

To post a comment you must log in.
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

I have looked into this. There is one SRU pending in quantal-proposed. After that one is verified we can publish this one across all supported & affected releases as SRUs.

Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

So as to not lose time while the other SRU is being verified (and really, I think we should carry on the SRU to precise anyway), can you please follow http://wiki.ubuntu.com/StableReleaseUpdates#Procedure and update the bugs descriptions accordingly?

All the changes should map directly to bugs being fixed for a SRU, so you should also add the bug links for the addition of skype and acroread to the changelog.

review: Needs Fixing
Revision history for this message
Stéphane Graber (stgraber) wrote :

Removing from sponsoring report for now. Please switch status back to Needs Review once the bug has been updated and the package is ready for upload.

Unmerged revisions

17. By Mantas Kriaučiūnas

fixed skype.desktop - changed Exec line to 'Exec=skype'; added desktop/acroread.desktop and icons/acroread.png from lp:app-install-data-commercial rev.45 (12.11.04.2)

16. By Mantas Kriaučiūnas

Fixed desktop/flash10.desktop: changed 'Name=Adobe Flash Plugin 11', added 'Comment' line and ',amd64' to line 'X-AppInstall-Architectures=i386'; debian/install: Enabled installation of .desktop and icon files; Added skype.desktop

15. By Martin Pitt

releasing version 12.12.10

14. By Martin Pitt

debian/control: Drop Vcs-Bzr:, the branch doesn't exist, and we want to
move to the UDD branch.

13. By Martin Pitt

debian/control: added 'Depends: ${misc:Depends'}

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2012-03-14 20:33:26 +0000
3+++ debian/changelog 2012-11-15 06:07:23 +0000
4@@ -1,3 +1,28 @@
5+app-install-data-partner (12.12.04.2) precise; urgency=low
6+
7+ [ Mantas Kriaučiūnas ]
8+ * Fixed desktop/flash10.desktop: changed "Name=Adobe Flash Plugin 11", added
9+ "Comment" line and ",amd64" to line "X-AppInstall-Architectures=i386"
10+ (LP: #875683)
11+ * debian/install: Enabled installation of .desktop and icon files (LP: #1005209)
12+ * Added desktop/skype.desktop from lp:ubuntu/quantal-proposed/app-install-data-partner
13+ and fixed "Exec=skype-wrapper" line
14+ * Added desktop/acroread.desktop and icons/acroread.png from
15+ app-install-data-partner 12.11.04.2 (lp:app-install-data-commercial rev. 45)
16+
17+ -- Mantas Kriaučiūnas <mantas@akl.lt> Wed, 14 Nov 2012 15:16:00 +0200
18+
19+app-install-data-partner (12.12.10) quantal; urgency=low
20+
21+ [ Verica Lazova ]
22+ * debian/control: added 'Depends: ${misc:Depends'}
23+
24+ [ Martin Pitt ]
25+ * debian/control: Drop Vcs-Bzr:, the branch doesn't exist, and we want to
26+ move to the UDD branch.
27+
28+ -- Verica Lazova <vericalcroft@gmail.com> Mon, 08 Oct 2012 15:42:42 +0200
29+
30 app-install-data-partner (12.12.04.1) precise; urgency=low
31
32 * Add desktop file and icon for VMware View Client (LP: #950993)
33
34=== modified file 'debian/control'
35--- debian/control 2011-12-12 11:57:33 +0000
36+++ debian/control 2012-11-15 06:07:23 +0000
37@@ -4,10 +4,10 @@
38 Maintainer: Michael Vogt <michael.vogt@ubuntu.com>
39 Build-Depends: debhelper (>= 8)
40 Standards-Version: 3.8.0
41-Vcs-Bzr: http://bazaar.launchpad.net/~ubuntu-core-dev/app-install-data-commercial/trunk
42
43 Package: app-install-data-partner
44 Architecture: all
45+Depends: ${misc:Depends}
46 Replaces: app-install-data-commercial (<< 11.9.04)
47 Description: Application Installer (data files for partner applications/repositories)
48 A pretty application installer.
49@@ -17,6 +17,7 @@
50
51 Package: app-install-data-commercial
52 Architecture: all
53+Depends: ${misc:Depends}
54 Description: Transitional package
55 This dummy package is provided for a smooth transition.
56 .
57
58=== modified file 'debian/install'
59--- debian/install 2011-12-12 11:57:33 +0000
60+++ debian/install 2012-11-15 06:07:23 +0000
61@@ -1,3 +1,3 @@
62 channels/*.{key,list,eula} /usr/share/app-install/channels
63-#desktop/*.desktop /usr/share/app-install/desktop
64-#icons/* /usr/share/app-install/icons
65+desktop/*.desktop /usr/share/app-install/desktop
66+icons/* /usr/share/app-install/icons
67
68=== added file 'desktop/acroread.desktop'
69--- desktop/acroread.desktop 1970-01-01 00:00:00 +0000
70+++ desktop/acroread.desktop 2012-11-15 06:07:23 +0000
71@@ -0,0 +1,14 @@
72+[Desktop Entry]
73+X-AppInstall-Package=acroread
74+X-AppInstall-Proprietary=true
75+X-AppInstall-Channel=precise-partner
76+X-AppInstall-LicenseUri=/usr/share/app-install/channels/precise-partner.eula
77+X-AppInstall-Architectures=i386,amd64
78+Encoding=UTF-8
79+Name=Adobe Reader 9
80+Comment=Adobe Reader allows view, navigate and print PDF documents, also fill PDF forms
81+Icon=acroread.png
82+Terminal=false
83+Type=Application
84+Categories=Application;Office;Viewer;
85+StartupNotify=true
86
87=== modified file 'desktop/flash10.desktop'
88--- desktop/flash10.desktop 2011-12-12 11:57:33 +0000
89+++ desktop/flash10.desktop 2012-11-15 06:07:23 +0000
90@@ -3,9 +3,10 @@
91 X-AppInstall-Proprietary=true
92 X-AppInstall-Channel=precise-partner
93 X-AppInstall-LicenseUri=/usr/share/app-install/channels/precise-partner.eula
94-X-AppInstall-Architectures=i386
95+X-AppInstall-Architectures=i386,amd64
96 Encoding=UTF-8
97-Name=Adobe Flash Plugin 10
98+Name=Adobe Flash Plugin 11 for browsers
99+Comment=Adobe Flash Player Plugin for Internet browsers (Firefox, Chromium) for playing of media and other dynamic content online
100 Icon=flash.png
101 Terminal=false
102 Type=Application
103
104=== added file 'desktop/skype.desktop'
105--- desktop/skype.desktop 1970-01-01 00:00:00 +0000
106+++ desktop/skype.desktop 2012-11-15 06:07:23 +0000
107@@ -0,0 +1,13 @@
108+[Desktop Entry]
109+X-AppInstall-Package=skype
110+X-AppInstall-Proprietary=true
111+X-AppInstall-Channel=precise-partner
112+X-AppInstall-LicenseUri=/usr/share/app-install/channels/precise-partner.eula
113+Name=Skype
114+Comment=Skype Internet Telephony
115+Exec=skype
116+Icon=skype.png
117+Terminal=false
118+Type=Application
119+Encoding=UTF-8
120+Categories=Network;Application;
121
122=== added file 'icons/acroread.png'
123Binary files icons/acroread.png 1970-01-01 00:00:00 +0000 and icons/acroread.png 2012-11-15 06:07:23 +0000 differ

Subscribers

People subscribed via source and target branches